Code review

Author: Keavon

libraries/math-parser/src/lib.rs

@@ -85,8 +85,11 @@ mod tests {
 	}
 
 	test_end_to_end! {
-		// Basic arithmetic and units
+		// Basic arithmetic
 		infix_addition: "5 + 5" => 10.,
+		infix_subtraction_units: "5 - 3" => 2.,
+		infix_multiplication_units: "4 * 4" => 16.,
+		infix_division_units: "8/2" => 4.,
 
 		// Order of operations
 		order_of_operations_negative_prefix: "-10 + 5" => -5.,

libraries/math-parser/src/parser.rs

@@ -52,8 +52,8 @@ pub fn chumsky_parser<'a>() -> impl Parser<'a, &'a str, Node, chumsky::extra::Er
 			just("e").map(|_| Node::Lit(Literal::Float(std::f64::consts::E))),
 			just("phi").or(just("φ")).map(|_| Node::Lit(Literal::Float(1.618_033_988_75))),
 			just("inf").or(just("∞")).map(|_| Node::Lit(Literal::Float(f64::INFINITY))),
-			just("i").map(|_| Node::Lit(Literal::Complex(Complex::new(0.0, 1.0)))), // Assuming Complex impl
-			just("G").map(|_| Node::Lit(Literal::Float(9.80665))),                  // gravity
+			just("i").map(|_| Node::Lit(Literal::Complex(Complex::new(0.0, 1.0)))), // Assuming `Complex` impl
+			just("G").map(|_| Node::Lit(Literal::Float(9.80665))),                  // Standard gravity on Earth
 		));
 
 		let ident = text::ident().padded();

libraries/math-parser/src/value.rs

@@ -62,10 +62,7 @@ impl Number {
 					BinaryOp::Div => lhs / rhs,
 					BinaryOp::Pow => lhs.powf(rhs),
 					BinaryOp::Leq => (lhs <= rhs) as u8 as f64,
-					BinaryOp::Lt => {
-						println!("{lhs} < {rhs}: {}", (lhs < rhs) as u8);
-						(lhs < rhs) as u8 as f64
-					}
+					BinaryOp::Lt => (lhs < rhs) as u8 as f64,
 					BinaryOp::Geq => (lhs >= rhs) as u8 as f64,
 					BinaryOp::Gt => (lhs > rhs) as u8 as f64,
 					BinaryOp::Eq => (lhs == rhs) as u8 as f64,