Use copy instead of cloning

timon-schelling · Keavon · commit dd6f28a3ef24 · 2025-08-03T12:20:57.000-07:00
diff --git a/editor/src/messages/dialog/export_dialog/export_dialog_message_handler.rs b/editor/src/messages/dialog/export_dialog/export_dialog_message_handler.rs
@@ -147,7 +147,7 @@ impl LayoutHolder for ExportDialogMessageHandler {
 
 		let checkbox_id = CheckboxId::new();
 		let transparent_background = vec![
-			TextLabel::new("Transparency").table_align(true).min_width(100).for_checkbox(checkbox_id.clone()).widget_holder(),
+			TextLabel::new("Transparency").table_align(true).min_width(100).for_checkbox(checkbox_id).widget_holder(),
 			Separator::new(SeparatorType::Unrelated).widget_holder(),
 			CheckboxInput::new(self.transparent_background)
 				.disabled(self.file_type == FileType::Jpg)
diff --git a/editor/src/messages/dialog/new_document_dialog/new_document_dialog_message_handler.rs b/editor/src/messages/dialog/new_document_dialog/new_document_dialog_message_handler.rs
@@ -82,7 +82,7 @@ impl LayoutHolder for NewDocumentDialogMessageHandler {
 
 		let checkbox_id = CheckboxId::new();
 		let infinite = vec![
-			TextLabel::new("Infinite Canvas").table_align(true).min_width(90).for_checkbox(checkbox_id.clone()).widget_holder(),
+			TextLabel::new("Infinite Canvas").table_align(true).min_width(90).for_checkbox(checkbox_id).widget_holder(),
 			Separator::new(SeparatorType::Unrelated).widget_holder(),
 			CheckboxInput::new(self.infinite)
 				.on_update(|checkbox_input: &CheckboxInput| NewDocumentDialogMessage::Infinite(checkbox_input.checked).into())
diff --git a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs b/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs
@@ -81,7 +81,7 @@ impl PreferencesDialogMessageHandler {
 					}
 					.into()
 				})
-				.for_label(checkbox_id.clone())
+				.for_label(checkbox_id)
 				.widget_holder(),
 			TextLabel::new("Zoom with Scroll")
 				.table_align(true)
@@ -178,7 +178,7 @@ impl PreferencesDialogMessageHandler {
 				.tooltip(vello_tooltip)
 				.disabled(!preferences.supports_wgpu())
 				.on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::UseVello { use_vello: checkbox_input.checked }.into())
-				.for_label(checkbox_id.clone())
+				.for_label(checkbox_id)
 				.widget_holder(),
 			TextLabel::new("Vello Renderer")
 				.table_align(true)
@@ -197,7 +197,7 @@ impl PreferencesDialogMessageHandler {
 			CheckboxInput::new(preferences.vector_meshes)
 				.tooltip(vector_mesh_tooltip)
 				.on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::VectorMeshes { enabled: checkbox_input.checked }.into())
-				.for_label(checkbox_id.clone())
+				.for_label(checkbox_id)
 				.widget_holder(),
 			TextLabel::new("Vector Meshes").table_align(true).tooltip(vector_mesh_tooltip).for_checkbox(checkbox_id).widget_holder(),
 		];
diff --git a/editor/src/messages/layout/utility_types/widgets/input_widgets.rs b/editor/src/messages/layout/utility_types/widgets/input_widgets.rs
@@ -49,7 +49,7 @@ impl Default for CheckboxInput {
 	}
 }
 
-#[derive(Clone, Debug, Eq, PartialEq, serde::Serialize, serde::Deserialize)]
+#[derive(Copy, Clone, Debug, Eq, PartialEq, serde::Serialize, serde::Deserialize)]
 pub struct CheckboxId(u64);
 
 impl CheckboxId {
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
@@ -2157,7 +2157,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Artboard Name".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2175,7 +2175,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("G/R/S Measurement".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2196,7 +2196,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Quick Measurement".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2214,7 +2214,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Transform Cage".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2232,7 +2232,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Transform Dial".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2250,7 +2250,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Transform Pivot".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2268,7 +2268,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Transform Origin".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2286,7 +2286,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Hover Outline".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2304,7 +2304,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Selection Outline".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2325,7 +2325,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Path".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2343,7 +2343,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Anchors".to_string()).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2362,7 +2362,7 @@ impl DocumentMessageHandler {
 										}
 										.into()
 									})
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new("Handles".to_string())
 									.disabled(!self.overlays_visibility_settings.anchors)
@@ -2410,7 +2410,7 @@ impl DocumentMessageHandler {
 										.into()
 									})
 									.tooltip(tooltip)
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new(name).tooltip(tooltip).for_checkbox(checkbox_id).widget_holder(),
 							]
@@ -2432,7 +2432,7 @@ impl DocumentMessageHandler {
 										.into()
 									})
 									.tooltip(tooltip)
-									.for_label(checkbox_id.clone())
+									.for_label(checkbox_id)
 									.widget_holder(),
 								TextLabel::new(name).tooltip(tooltip).for_checkbox(checkbox_id).widget_holder(),
 							]
diff --git a/editor/src/messages/tool/tool_messages/path_tool.rs b/editor/src/messages/tool/tool_messages/path_tool.rs
@@ -247,7 +247,7 @@ impl LayoutHolder for PathTool {
 				}
 			})
 			.tooltip(colinear_handles_tooltip)
-			.for_label(checkbox_id.clone())
+			.for_label(checkbox_id)
 			.widget_holder();
 		let colinear_handles_label = TextLabel::new("Colinear Handles")
 			.disabled(!self.tool_data.can_toggle_colinearity)

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ impl Default for CheckboxInput {`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
`52`		`-#[derive(Clone, Debug, Eq, PartialEq, serde::Serialize, serde::Deserialize)]`
	`52`	`+#[derive(Copy, Clone, Debug, Eq, PartialEq, serde::Serialize, serde::Deserialize)]`
`53`	`53`	`pub struct CheckboxId(u64);`
`54`	`54`
`55`	`55`	`impl CheckboxId {`
Original file line number	Diff line number	Diff line change
`@@ -2157,7 +2157,7 @@ impl DocumentMessageHandler {`
`2157`	`2157`	`}`
`2158`	`2158`	`.into()`
`2159`	`2159`	`})`
`2160`		`- .for_label(checkbox_id.clone())`
	`2160`	`+ .for_label(checkbox_id)`
`2161`	`2161`	`.widget_holder(),`
`2162`	`2162`	`TextLabel::new("Artboard Name".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2163`	`2163`	`]`
`@@ -2175,7 +2175,7 @@ impl DocumentMessageHandler {`
`2175`	`2175`	`}`
`2176`	`2176`	`.into()`
`2177`	`2177`	`})`
`2178`		`- .for_label(checkbox_id.clone())`
	`2178`	`+ .for_label(checkbox_id)`
`2179`	`2179`	`.widget_holder(),`
`2180`	`2180`	`TextLabel::new("G/R/S Measurement".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2181`	`2181`	`]`
`@@ -2196,7 +2196,7 @@ impl DocumentMessageHandler {`
`2196`	`2196`	`}`
`2197`	`2197`	`.into()`
`2198`	`2198`	`})`
`2199`		`- .for_label(checkbox_id.clone())`
	`2199`	`+ .for_label(checkbox_id)`
`2200`	`2200`	`.widget_holder(),`
`2201`	`2201`	`TextLabel::new("Quick Measurement".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2202`	`2202`	`]`
`@@ -2214,7 +2214,7 @@ impl DocumentMessageHandler {`
`2214`	`2214`	`}`
`2215`	`2215`	`.into()`
`2216`	`2216`	`})`
`2217`		`- .for_label(checkbox_id.clone())`
	`2217`	`+ .for_label(checkbox_id)`
`2218`	`2218`	`.widget_holder(),`
`2219`	`2219`	`TextLabel::new("Transform Cage".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2220`	`2220`	`]`
`@@ -2232,7 +2232,7 @@ impl DocumentMessageHandler {`
`2232`	`2232`	`}`
`2233`	`2233`	`.into()`
`2234`	`2234`	`})`
`2235`		`- .for_label(checkbox_id.clone())`
	`2235`	`+ .for_label(checkbox_id)`
`2236`	`2236`	`.widget_holder(),`
`2237`	`2237`	`TextLabel::new("Transform Dial".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2238`	`2238`	`]`
`@@ -2250,7 +2250,7 @@ impl DocumentMessageHandler {`
`2250`	`2250`	`}`
`2251`	`2251`	`.into()`
`2252`	`2252`	`})`
`2253`		`- .for_label(checkbox_id.clone())`
	`2253`	`+ .for_label(checkbox_id)`
`2254`	`2254`	`.widget_holder(),`
`2255`	`2255`	`TextLabel::new("Transform Pivot".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2256`	`2256`	`]`
`@@ -2268,7 +2268,7 @@ impl DocumentMessageHandler {`
`2268`	`2268`	`}`
`2269`	`2269`	`.into()`
`2270`	`2270`	`})`
`2271`		`- .for_label(checkbox_id.clone())`
	`2271`	`+ .for_label(checkbox_id)`
`2272`	`2272`	`.widget_holder(),`
`2273`	`2273`	`TextLabel::new("Transform Origin".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2274`	`2274`	`]`
`@@ -2286,7 +2286,7 @@ impl DocumentMessageHandler {`
`2286`	`2286`	`}`
`2287`	`2287`	`.into()`
`2288`	`2288`	`})`
`2289`		`- .for_label(checkbox_id.clone())`
	`2289`	`+ .for_label(checkbox_id)`
`2290`	`2290`	`.widget_holder(),`
`2291`	`2291`	`TextLabel::new("Hover Outline".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2292`	`2292`	`]`
`@@ -2304,7 +2304,7 @@ impl DocumentMessageHandler {`
`2304`	`2304`	`}`
`2305`	`2305`	`.into()`
`2306`	`2306`	`})`
`2307`		`- .for_label(checkbox_id.clone())`
	`2307`	`+ .for_label(checkbox_id)`
`2308`	`2308`	`.widget_holder(),`
`2309`	`2309`	`TextLabel::new("Selection Outline".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2310`	`2310`	`]`
`@@ -2325,7 +2325,7 @@ impl DocumentMessageHandler {`
`2325`	`2325`	`}`
`2326`	`2326`	`.into()`
`2327`	`2327`	`})`
`2328`		`- .for_label(checkbox_id.clone())`
	`2328`	`+ .for_label(checkbox_id)`
`2329`	`2329`	`.widget_holder(),`
`2330`	`2330`	`TextLabel::new("Path".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2331`	`2331`	`]`
`@@ -2343,7 +2343,7 @@ impl DocumentMessageHandler {`
`2343`	`2343`	`}`
`2344`	`2344`	`.into()`
`2345`	`2345`	`})`
`2346`		`- .for_label(checkbox_id.clone())`
	`2346`	`+ .for_label(checkbox_id)`
`2347`	`2347`	`.widget_holder(),`
`2348`	`2348`	`TextLabel::new("Anchors".to_string()).for_checkbox(checkbox_id).widget_holder(),`
`2349`	`2349`	`]`
`@@ -2362,7 +2362,7 @@ impl DocumentMessageHandler {`
`2362`	`2362`	`}`
`2363`	`2363`	`.into()`
`2364`	`2364`	`})`
`2365`		`- .for_label(checkbox_id.clone())`
	`2365`	`+ .for_label(checkbox_id)`
`2366`	`2366`	`.widget_holder(),`
`2367`	`2367`	`TextLabel::new("Handles".to_string())`
`2368`	`2368`	`.disabled(!self.overlays_visibility_settings.anchors)`
`@@ -2410,7 +2410,7 @@ impl DocumentMessageHandler {`
`2410`	`2410`	`.into()`
`2411`	`2411`	`})`
`2412`	`2412`	`.tooltip(tooltip)`
`2413`		`- .for_label(checkbox_id.clone())`
	`2413`	`+ .for_label(checkbox_id)`
`2414`	`2414`	`.widget_holder(),`
`2415`	`2415`	`TextLabel::new(name).tooltip(tooltip).for_checkbox(checkbox_id).widget_holder(),`
`2416`	`2416`	`]`
`@@ -2432,7 +2432,7 @@ impl DocumentMessageHandler {`
`2432`	`2432`	`.into()`
`2433`	`2433`	`})`
`2434`	`2434`	`.tooltip(tooltip)`
`2435`		`- .for_label(checkbox_id.clone())`
	`2435`	`+ .for_label(checkbox_id)`
`2436`	`2436`	`.widget_holder(),`
`2437`	`2437`	`TextLabel::new(name).tooltip(tooltip).for_checkbox(checkbox_id).widget_holder(),`
`2438`	`2438`	`]`
Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ impl LayoutHolder for PathTool {`
`247`	`247`	`}`
`248`	`248`	`})`
`249`	`249`	`.tooltip(colinear_handles_tooltip)`
`250`		`- .for_label(checkbox_id.clone())`
	`250`	`+ .for_label(checkbox_id)`
`251`	`251`	`.widget_holder();`
`252`	`252`	`let colinear_handles_label = TextLabel::new("Colinear Handles")`
`253`	`253`	`.disabled(!self.tool_data.can_toggle_colinearity)`