Error handling improvement

Author: jsjgdh

node-graph/nodes/vector/src/aperiodic_tiling.rs

@@ -45,7 +45,8 @@ fn match_two(p1: DVec2, q1: DVec2, p2: DVec2, q2: DVec2) -> DAffine2 {
 fn intersect(p1: DVec2, q1: DVec2, p2: DVec2, q2: DVec2) -> DVec2 {
 	let d = (q2.y - p2.y) * (q1.x - p1.x) - (q2.x - p2.x) * (q1.y - p1.y);
 	if d.abs() < 1e-12 {
-		panic!("parallel lines in intersect");
+		log::warn!("parallel lines in intersect");
+		return p1;
 	}
 	let ua = ((q2.x - p2.x) * (p1.y - p2.y) - (q2.y - p2.y) * (p1.x - p2.x)) / d;
 	p1 + ua * (q1 - p1)
@@ -93,16 +94,25 @@ impl MetaTile {
 		let (xf, tile) = &self.children[n];
 		let outline = match tile.as_ref() {
 			TileType::Meta(m) => &m.outline,
-			TileType::Hat(_) => unreachable!(),
+			TileType::Hat(_) => {
+				log::warn!("eval_child called on Hat leaf");
+				return DVec2::ZERO;
+			}
 		};
+		if outline.is_empty() {
+			return DVec2::ZERO;
+		}
 		xf.transform_point2(outline[i % outline.len()])
 	}
 
 	fn child_outline(&self, n: usize) -> (&DAffine2, &[DVec2]) {
 		let (xf, tile) = &self.children[n];
 		match tile.as_ref() {
 			TileType::Meta(m) => (xf, &m.outline),
-			TileType::Hat(_) => unreachable!(),
+			TileType::Hat(_) => {
+				log::warn!("child_outline called on Hat leaf");
+				(xf, &[])
+			}
 		}
 	}
 
@@ -216,14 +226,20 @@ fn shape_for_label<'a>(h: &'a Rc<TileType>, t: &'a Rc<TileType>, p: &'a Rc<TileT
 		3 => h,
 		4 => f,
 		5 => t,
-		_ => unreachable!(),
+		_ => {
+			log::warn!("Unknown label {}", label);
+			h // Default fallback
+		}
 	}
 }
 
 fn construct_patch(h: &Rc<TileType>, t: &Rc<TileType>, p: &Rc<TileType>, f: &Rc<TileType>) -> MetaTile {
 	let h_meta = match h.as_ref() {
 		TileType::Meta(m) => m,
-		_ => unreachable!(),
+		_ => {
+			log::warn!("Expected MetaTile for 'h' in construct_patch");
+			return MetaTile::new(Vec::new(), 0.0); // Return empty patch
+		}
 	};
 	let mut ret = MetaTile::new(Vec::new(), h_meta.width);
 
@@ -236,9 +252,15 @@ fn construct_patch(h: &Rc<TileType>, t: &Rc<TileType>, p: &Rc<TileType>, f: &Rc<
 				let nshp = shape_for_label(h, t, p, f, r[2]);
 				let nshp_meta = match nshp.as_ref() {
 					TileType::Meta(m) => m,
-					_ => unreachable!(),
+					_ => {
+						log::warn!("Expected MetaTile in construct_patch rule");
+						continue;
+					}
 				};
 				let idx = r[3] as usize;
+				if nshp_meta.outline.is_empty() {
+					continue;
+				}
 				ret.push(match_two(nshp_meta.outline[idx], nshp_meta.outline[(idx + 1) % nshp_meta.outline.len()], p_pt, q_pt), Rc::clone(nshp));
 			}
 			_ => {
@@ -249,9 +271,15 @@ fn construct_patch(h: &Rc<TileType>, t: &Rc<TileType>, p: &Rc<TileType>, f: &Rc<
 				let nshp = shape_for_label(h, t, p, f, r[4]);
 				let nshp_meta = match nshp.as_ref() {
 					TileType::Meta(m) => m,
-					_ => unreachable!(),
+					_ => {
+						log::warn!("Expected MetaTile in construct_patch rule");
+						continue;
+					}
 				};
 				let idx = r[5] as usize;
+				if nshp_meta.outline.is_empty() {
+					continue;
+				}
 				ret.push(match_two(nshp_meta.outline[idx], nshp_meta.outline[(idx + 1) % nshp_meta.outline.len()], p_pt, q_pt), Rc::clone(nshp));
 			}
 		}

node-graph/nodes/vector/src/generator_nodes.rs

@@ -404,10 +404,10 @@ fn aperiodic_tiling(
 	#[default(false)]
 	cull_viewport: bool,
 	#[expose]
-	#[default((0., 0.).into())]
+	#[default(0., 0.)]
 	culling_bound_min: DVec2,
 	#[expose]
-	#[default((100., 100.).into())]
+	#[default(100., 100.)]
 	culling_bound_max: DVec2,
 ) -> Table<Vector> {
 	let culling_bounds = if cull_viewport {