Skip to content

Remap Path tool point sliding to G G#2913

Merged
Keavon merged 17 commits into
masterfrom
gg_sliding
Aug 17, 2025
Merged

Remap Path tool point sliding to G G#2913
Keavon merged 17 commits into
masterfrom
gg_sliding

Conversation

@4adex
Copy link
Copy Markdown
Contributor

@4adex 4adex commented Jul 20, 2025

Closes #2715

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 20, 2025 11:44 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 25, 2025 00:58 Inactive
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jul 25, 2025

This doesn't appear to do anything, from what I can tell. Did you test it? Or misunderstand what is desired?

@Keavon Keavon marked this pull request as draft July 25, 2025 01:27
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 25, 2025 01:29 Inactive
@4adex
Copy link
Copy Markdown
Contributor Author

4adex commented Jul 25, 2025

https://4778b953.graphite.pages.dev/
It is working in the deployement, before your code review commit @Keavon
Screencast from 25-07-25 09:49:36 AM IST.webm
I will fix it

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jul 25, 2025

Oh, it doesn't work on ellipses. I tested your commit before doing my code review. (It sounds like I also broke something in my code review/)

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jul 25, 2025

We also need hints during G/R/S, including (when available) the subsequent G to slide. I seem to recall we already had working G/R/S hints but we don't seem to currently in the Path tool. Maybe I was just remembering the Select tool's ones.

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 27, 2025 05:02 Inactive
@4adex 4adex marked this pull request as ready for review July 27, 2025 07:26
@4adex 4adex marked this pull request as draft July 27, 2025 07:26
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 27, 2025 07:32 Inactive
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jul 28, 2025

Still supposed to be a draft?

@4adex
Copy link
Copy Markdown
Contributor Author

4adex commented Jul 28, 2025

The hints are not updated yet, but hints have been changed to dynamic ones in #2860 so was waiting for merger of that.

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 2, 2025 08:22 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 6, 2025 19:58 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 6, 2025 20:35 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 7, 2025 05:18 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 7, 2025 05:28 Inactive
@4adex 4adex marked this pull request as ready for review August 7, 2025 05:53
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 7, 2025 10:17 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 7, 2025 12:06 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 8, 2025 06:26 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 17, 2025 02:52 Inactive
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Aug 17, 2025

Feedback for a followup PR:

  • When we've reached one of the ends of travel for the segment, we'd like to automatically merge the sliding point and endpoint it's touching, while also correctly dealing with the handle (which needs to remain colinear if its endpoint anchor it's merging with was).
  • When sliding, we need Enter to confirm in addition to left click, and we need that confirmation mentioned in the hints
  • We want full G/R/S hints when in G, R, or S mode just like we do with G/R/S for the Select tool
    • And when in G mode, that's when we want to show the hint for "Slide Point" upon hitting G a second time, instead of having the hint currently show G G
  • We should support sliding multiple simulatneous anchors if they are on their own non-contiguous segments

@Keavon Keavon changed the title Point sliding on G G Remap Path tool point sliding to G G Aug 17, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 17, 2025 03:27 Inactive
@Keavon Keavon enabled auto-merge (squash) August 17, 2025 03:29
@Keavon Keavon merged commit 52174fa into master Aug 17, 2025
4 checks passed
@Keavon Keavon deleted the gg_sliding branch August 17, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Point sliding with G G

2 participants