remove inner enum from raster types#2929
Merged
Merged
Conversation
Firestar99
force-pushed
the
cleanup_raster_types
branch
from
b764fdd to
631ee41
Compare
Member
|
Yeah, I like this. That is cleaner. I think we can just probably just merge this |
TrueDoctor
approved these changes
Jul 25, 2025
Firestar99
force-pushed
the
cleanup_raster_types
branch
from
631ee41 to
676fe03
Compare
Collaborator
Author
|
It was just WIP cause I thought there may be some discussion on this, merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just want to throw in this suggestion and see what people think.
From an external perspective, this is equivalent to the current implementation on master.