Filter transform instances#2935
Closed
0HyperCube wants to merge 1 commit into
Closed
Conversation
Contributor
0HyperCube
commented
Jul 25, 2025
0HyperCube
commented
adamgerhant
reviewed
Jul 25, 2025
adamgerhant
reviewed
Jul 25, 2025
adamgerhant
reviewed
Jul 25, 2025
0HyperCube
force-pushed
the
filter-transform-instances
branch
from
137c24e to
9f6ea66
Compare
Contributor
Author
|
@Keavon closing because I'm not rebasing this yet again, I only just finished rebasing it the first time. Thanks. |
Member
|
I'm always happy to rebase things, just send me a message. I'll do this one now. |
Keavon
force-pushed
the
filter-transform-instances
branch
from
9f6ea66 to
0508da1
Compare
Member
|
Rebase is done. That only affected about 5 small conflicts, so I'm glad to see my name updates aren't causing too many nasty conflicts. |
Contributor
Author
|
@Keavon if you rebase, please make sure the code actually compiles… |
Member
|
This will instead be solved by the more generalized approach of #2988. But this was a really cool prototype, thanks for exploring this approach, it was valuable to learn from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.