Skip to content

Add fill tool support on strokes#2664

Closed
seam0s-dev wants to merge 40 commits intoGraphiteEditor:masterfrom
seam0s-dev:2615-fill-tool-on-strokes
Closed

Add fill tool support on strokes#2664
seam0s-dev wants to merge 40 commits intoGraphiteEditor:masterfrom
seam0s-dev:2615-fill-tool-on-strokes

Conversation

@seam0s-dev
Copy link
Copy Markdown
Contributor

This PR adds support for fill on strokes while using the fill tool as requested in #2615.

@seam0s-dev seam0s-dev closed this May 26, 2025
@seam0s-dev seam0s-dev reopened this May 26, 2025
@seam0s-dev
Copy link
Copy Markdown
Contributor Author

seam0s-dev commented May 26, 2025

Test cases:
stroke fill pattern.graphite.txt

@seam0s-dev seam0s-dev force-pushed the 2615-fill-tool-on-strokes branch from 9741537 to 1a64e29 Compare June 1, 2025 18:06
@seam0s-dev seam0s-dev marked this pull request as ready for review June 8, 2025 18:06
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jun 9, 2025

See the video for the issues this encounters:

capture_10_.mp4

Here's the file with this shape (remove the .txt from the file after downloading it):

issues.graphite.txt

@Keavon Keavon marked this pull request as draft June 9, 2025 00:38
@seam0s-dev
Copy link
Copy Markdown
Contributor Author

seam0s-dev commented Jun 9, 2025

@Keavon The issue does not seem to affect shapes constructed using pen tool:

ellipse_vs_path_shapes_fill_overlay.mp4

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jun 9, 2025

You likely need to take into account the local transform, the nested transform spaces to reach from local space to document space, and the stroke transform (which is affected by scaling or skewing a grouped layer, for example).

@Keavon Keavon force-pushed the 2615-fill-tool-on-strokes branch from 7f66924 to 535fba8 Compare June 20, 2025 08:48
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jun 20, 2025

I have force pushed this branch to move it to a new base. Ensure you have the branch checked out. Then please run git stash on any local changes (and ask me before following these steps if you have any un-pushed commits on your local machine). Then fetch this branch and git reset --hard origin/2615-fill-tool-on-strokes. And finally git stash pop your stashed local changes, if you stashed them.

@Keavon Keavon force-pushed the master branch 2 times, most recently from 316a737 to 532e913 Compare June 28, 2025 13:25
@Keavon Keavon force-pushed the master branch 4 times, most recently from ec51271 to e025103 Compare July 10, 2025 05:48
@seam0s-dev seam0s-dev force-pushed the 2615-fill-tool-on-strokes branch from 44f9e60 to f1f2ffe Compare July 22, 2025 08:58
@Keavon Keavon closed this Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants