Add the unit, display_decimal_places, and step parameter widget macro attributes#2706
Merged
Keavon merged 10 commits intoGraphiteEditor:masterfrom Jun 15, 2025
Merged
Add the unit, display_decimal_places, and step parameter widget macro attributes#2706Keavon merged 10 commits intoGraphiteEditor:masterfrom
unit, display_decimal_places, and step parameter widget macro attributes#2706Keavon merged 10 commits intoGraphiteEditor:masterfrom
Conversation
unit, display_decimal_places, and step macrosunit, display_decimal_places, and step parameter widget macro attributes
Keavon
approved these changes
Jun 15, 2025
Keavon
added a commit
that referenced
this pull request
Jun 20, 2025
… macro attributes (#2706) * UI working for spacing enum. * Implementations. * UI working for spacing enum. * Undo all changes. * unit, display_decimal_places, and step macro implementation. * Fixing tests. --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unitmacro for a unit suffix, eg. "°" or " px"display_decimal_placesto show certain amount of decimal places for float numbers (default 2)stepfor little arrows on each end of a number input to increment and decrement based on the step value (default 1.)Example Usage
Code:
Expected result shown in image after adjusting value to

2.51231237:Macros are not being used anywhere except in the
copy_to_pointsfunction inside ofvector_nodes.rs, however, these were already being used before and I believe they were not doing anything because aunitmacro did not exist. TheMultiplierfield already added a unit suffix of "x" so theunitmacro does not provide any utility, though, I have left it unchanged.The way I tested to make sure these macros work:
f64field to therepeatfunction invector_nodes.rswith the new macrosRepeatnode to a shapeRepeatnode changes depending on the parameters of the new macros