Skip to content

Improve node creation menu and categorization#2719

Merged
Keavon merged 2 commits intoGraphiteEditor:masterfrom
Ezbaze:node-editor-context-menu
Jun 24, 2025
Merged

Improve node creation menu and categorization#2719
Keavon merged 2 commits intoGraphiteEditor:masterfrom
Ezbaze:node-editor-context-menu

Conversation

@Ezbaze
Copy link
Copy Markdown
Contributor

@Ezbaze Ezbaze commented Jun 15, 2025

  • Fix the clickability area of categories in the node editor context menu to close Category text label isn't clickable in the Node Graph editor context menu #2718
  • Node editor context menu nodes category swaps:
    1. Circular Repeat: Vector → Instancing
    2. Copy to Points: Vector → Instancing
    3. Repeat: Vector → Instancing
    4. Switch: Text → Math: Logic
  • Organize code for certain nodes across files to reflect their new categories

Also resolves https://discordapp.com/channels/731730685944922173/881073965047636018/1383884104566706217 and https://discordapp.com/channels/731730685944922173/881073965047636018/1384323535316713542

@Ezbaze Ezbaze changed the title Fix clickability area of categories in the node editor context menu Node editor context menu & Node categories Jun 16, 2025
@Keavon Keavon force-pushed the master branch 2 times, most recently from 34dced3 to 5cacab2 Compare June 20, 2025 06:47
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jun 20, 2025

I have force pushed this branch to move it to a new base. Ensure you have the branch checked out. Then run git stash on any local changes (and ask me before following these steps if you have any un-pushed commits on your local machine). Then fetch this branch and git reset --hard origin/node-editor-context-menu. And finally git stash pop your stashed local changes, if you stashed them.

@Keavon Keavon changed the title Node editor context menu & Node categories Improve node creation menu and categorization Jun 23, 2025
@Firestar99
Copy link
Copy Markdown
Collaborator

I'd love to get this merged before I'm rearranging all the vector code and nodes into separate crates :D

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jun 23, 2025

@Firestar99 these are easy to replay on the latest master branch in the future, so no need to let this block you. When you're moving the node implementations around, feel free to reference this issue for how some of them got recategorized.

@Ezbaze Ezbaze closed this Jun 23, 2025
Signed-off-by: ezbaze <rybitwamateusz3@gmail.com>
@Ezbaze Ezbaze reopened this Jun 23, 2025
@Keavon Keavon merged commit 2ec0ff3 into GraphiteEditor:master Jun 24, 2025
4 checks passed
urisinger pushed a commit to urisinger/Graphite that referenced this pull request Jul 15, 2025
* Change node categories

Signed-off-by: ezbaze <rybitwamateusz3@gmail.com>

* Restore Ezbaze's other work that was lost in the rebase

---------

Signed-off-by: ezbaze <rybitwamateusz3@gmail.com>
Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Category text label isn't clickable in the Node Graph editor context menu

3 participants