Skip to content

Disable preprocessor insertion of IntoNodes in the graph to avoid intermittent math node type errors #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keavon merged 1 commit into from
Jun 30, 2025
Merged

Disable preprocessor insertion of IntoNodes in the graph to avoid intermittent math node type errors #2802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions editor/src/node_graph_executor/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,7 @@ impl NodeRuntime {
}

async fn update_network(&mut self, mut graph: NodeNetwork) -> Result<ResolvedDocumentNodeTypesDelta, String> {
if cfg!(not(test)) {
preprocessor::expand_network(&mut graph, &self.substitutions);
}
preprocessor::expand_network(&mut graph, &self.substitutions);

let scoped_network = wrap_network_in_scope(graph, self.editor_api.clone());

Expand Down
2 changes: 1 addition & 1 deletion node-graph/preprocessor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pub fn generate_node_substitutions() -> HashMap<String, DocumentNode> {
(
NodeId(i as u64),
match inputs.len() {
1 => {
1 if false => {
let input = inputs.iter().next().unwrap();
let input_ty = input.nested_type();

Expand Down
Loading