Skip to content

Fixes #2038: Safari click and drag fix #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seabeeberry wants to merge 2 commits into from
Closed

Fixes #2038: Safari click and drag fix #2916

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94d10a6
Placed PointerLock inside pointermove event handler to ensure Safari …
Jul 21, 2025
084f8e9
Applied review suggestion: pointermove now is not leaking when target…
Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions frontend/src/components/widgets/inputs/NumberInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,14 @@
if (alreadyActedGuard) return;
alreadyActedGuard = true;
isDragging = true;
beginDrag(e);

// We need to request pointer lock as immediately as possible for Safari compatibility
const target = e.target || undefined;
if (!(target instanceof HTMLElement)) return;

target.requestPointerLock();

beginDrag();
removeEventListener("pointermove", onMove);
Copy link
Copy Markdown
Member

@Keavon Keavon Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this now leaking the pointermove event now that we are sometimes early returning before this line? Seems like the target.requestPointerLock(); and beginDrag(); lines should be inside the if statement instead of the early return in its inverse.

};
// If it's a mouseup, we'll begin editing the text field.
Expand All @@ -340,13 +347,7 @@
addEventListener("pointerup", onUp);
}

function beginDrag(e: PointerEvent) {
// Get the click target
const target = e.target || undefined;
if (!(target instanceof HTMLElement)) return;

// Enter dragging state
target.requestPointerLock();
function beginDrag() {
initialValueBeforeDragging = value;
cumulativeDragDelta = 0;

Expand Down
Loading