Skip to content

Refactor eval_pathseg_euclidean() to use kurbo's faster/more accurate inv_arclen()#3969

Merged
Keavon merged 1 commit intomasterfrom
eval_pathseg_euclidean
Mar 28, 2026
Merged

Refactor eval_pathseg_euclidean() to use kurbo's faster/more accurate inv_arclen()#3969
Keavon merged 1 commit intomasterfrom
eval_pathseg_euclidean

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Mar 28, 2026

No description provided.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the eval_pathseg_euclidean function to utilize the inv_arclen method from the kurbo library, replacing a manual binary search implementation. Feedback suggests reintroducing a check for non-finite path lengths to ensure robustness, as the previous implementation included this guard.

Comment thread node-graph/libraries/vector-types/src/vector/algorithms/bezpath_algorithms.rs
@Keavon Keavon merged commit 865e971 into master Mar 28, 2026
8 of 11 checks passed
@Keavon Keavon deleted the eval_pathseg_euclidean branch March 28, 2026 23:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 27,772,245 (master) → 27,773,693 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     4|          4          +0.03%
D1mr                     359,206|    359,403          +0.05%
D1mw                     113,634|    113,571          -0.06%
DLmr                      31,884|     31,890          +0.02%
DLmw                      42,888|     42,893          +0.01%
Dr                     6,875,594|  6,875,706          +0.00%
Dw                     4,751,115|  4,751,118          +0.00%
EstimatedCycles       43,745,638| 43,740,645          -0.01%
I1MissRate                     0|          0          -3.95%
I1mr                      46,876|     45,028          -3.94%
ILmr                         822|        821          -0.12%
Ir                    27,772,245| 27,773,693          +0.01%
L1HitRate                     99|         99          +0.00%
L1hits                38,879,238| 38,882,515          +0.01%
LLHitRate                      1|          1          -0.39%
LLMissRate                     0|          0          +0.01%
LLdMissRate                    1|          1          +0.01%
LLhits                   444,122|    442,398          -0.39%
LLiMissRate                    0|          0          -0.13%
RamHitRate                     0|          0          +0.01%
RamHits                   75,594|     75,604          +0.01%
TotalRW               39,398,954| 39,400,517          +0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 14,014,495 (master) → 14,014,728 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.02%
D1mr                     178,116|    178,144          +0.02%
D1mw                      54,179|     54,107          -0.13%
DLmr                         799|        791          -1.00%
DLmw                      14,235|     14,240          +0.04%
Dr                     3,476,881|  3,476,955          +0.00%
Dw                     2,391,469|  2,391,513          +0.00%
EstimatedCycles       21,377,099| 21,372,784          -0.02%
I1MissRate                     0|          0          -4.77%
I1mr                      23,361|     22,246          -4.77%
ILmr                         687|        689          +0.29%
Ir                    14,014,495| 14,014,728          +0.00%
L1HitRate                     99|         99          +0.01%
L1hits                19,627,189| 19,628,699          +0.01%
LLHitRate                      1|          1          -0.48%
LLMissRate                     0|          0          -0.01%
LLdMissRate                    0|          0          -0.02%
LLhits                   239,935|    238,777          -0.48%
LLiMissRate                    0|          0          +0.29%
RamHitRate                     0|          0          -0.01%
RamHits                   15,721|     15,720          -0.01%
TotalRW               19,882,845| 19,883,196          +0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 3,106,245 (master) → 3,106,295 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.05%
D1mr                      36,882|     36,867          -0.04%
D1mw                      11,354|     11,349          -0.04%
DLmr                          13|         13          +0.00%
DLmw                       3,013|      3,017          +0.13%
Dr                       758,858|    758,916          +0.01%
Dw                       524,104|    524,143          +0.01%
EstimatedCycles        4,713,245|  4,712,878          -0.01%
I1MissRate                     0|          0          -2.96%
I1mr                       4,941|      4,795          -2.95%
ILmr                         685|        686          +0.15%
Ir                     3,106,245|  3,106,295          +0.00%
L1HitRate                     99|         99          +0.00%
L1hits                 4,336,030|  4,336,343          +0.01%
LLHitRate                      1|          1          -0.35%
LLMissRate                     0|          0          +0.13%
LLdMissRate                    0|          0          +0.12%
LLhits                    49,466|     49,295          -0.35%
LLiMissRate                    0|          0          +0.14%
RamHitRate                     0|          0          +0.13%
RamHits                    3,711|      3,716          +0.13%
TotalRW                4,389,207|  4,389,354          +0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 13,699,229 (master) → 13,699,304 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.08%
D1mr                     174,555|    174,462          -0.05%
D1mw                      51,611|     51,507          -0.20%
DLmr                          89|         89          +0.00%
DLmw                      11,733|     11,737          +0.03%
Dr                     3,356,230|  3,356,120          -0.00%
Dw                     2,337,979|  2,337,884          -0.00%
EstimatedCycles       20,747,010| 20,747,692          +0.00%
I1MissRate                     0|          0          +2.10%
I1mr                      17,637|     18,007          +2.10%
ILmr                         790|        790          +0.00%
Ir                    13,699,229| 13,699,304          +0.00%
L1HitRate                     99|         99          -0.00%
L1hits                19,149,635| 19,149,332          -0.00%
LLHitRate                      1|          1          +0.07%
LLMissRate                     0|          0          +0.03%
LLdMissRate                    0|          0          +0.04%
LLhits                   231,191|    231,360          +0.07%
LLiMissRate                    0|          0          -0.00%
RamHitRate                     0|          0          +0.03%
RamHits                   12,612|     12,616          +0.03%
TotalRW               19,393,438| 19,393,308          -0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 32,350,416 (master) → 32,348,859 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     4|          4          +0.04%
D1mr                     423,123|    423,428          +0.07%
D1mw                     129,499|    129,417          -0.06%
DLmr                      43,443|     43,456          +0.03%
DLmw                      57,497|     57,545          +0.08%
Dr                     7,977,054|  7,976,961          -0.00%
Dw                     5,517,609|  5,517,648          +0.00%
EstimatedCycles       51,318,513| 51,310,104          -0.02%
I1MissRate                     0|          0          -4.59%
I1mr                      52,454|     50,044          -4.59%
ILmr                         831|        835          +0.48%
Ir                    32,350,416| 32,348,859          -0.00%
L1HitRate                     99|         99          +0.00%
L1hits                45,240,003| 45,240,579          +0.00%
LLHitRate                      1|          1          -0.44%
LLMissRate                     0|          0          +0.07%
LLdMissRate                    1|          1          +0.06%
LLhits                   503,305|    501,053          -0.45%
LLiMissRate                    0|          0          +0.49%
RamHitRate                     0|          0          +0.07%
RamHits                  101,771|    101,836          +0.06%
TotalRW               45,845,079| 45,843,468          -0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 21,309,547 (master) → 21,307,750 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.03%
D1mr                     276,543|    276,546          +0.00%
D1mw                      77,612|     77,516          -0.12%
DLmr                      15,777|     15,786          +0.06%
DLmw                      44,495|     44,481          -0.03%
Dr                     5,282,098|  5,281,996          -0.00%
Dw                     3,644,823|  3,644,863          +0.00%
EstimatedCycles       33,626,388| 33,618,061          -0.02%
I1MissRate                     0|          0          -4.04%
I1mr                      35,390|     33,956          -4.05%
ILmr                         786|        779          -0.89%
Ir                    21,309,547| 21,307,750          -0.01%
L1HitRate                     99|         99          +0.01%
L1hits                29,846,923| 29,846,591          -0.00%
LLHitRate                      1|          1          -0.46%
LLMissRate                     0|          0          -0.01%
LLdMissRate                    1|          1          -0.01%
LLhits                   328,487|    326,972          -0.46%
LLiMissRate                    0|          0          -0.88%
RamHitRate                     0|          0          -0.01%
RamHits                   61,058|     61,046          -0.02%
TotalRW               30,236,468| 30,234,609          -0.01%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 51,181,277 (master) → 51,486,108 (HEAD) : $$\color{red}+0.60\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          -1.55%
D1mr                     552,431|    555,301          +0.52%
D1mw                     125,466|    129,041          +2.85%
DLmr                       4,219|      4,872         +15.48%
DLmw                      18,853|     25,423         +34.85%
Dr                    12,930,491| 13,202,610          +2.10%
Dw                     8,766,985|  9,045,683          +3.18%
EstimatedCycles       76,447,501| 77,523,685          +1.41%
I1MissRate                     0|          0         -14.82%
I1mr                      39,420|     33,779         -14.31%
ILmr                         244|        265          +8.61%
Ir                    51,181,277| 51,486,108          +0.60%
L1HitRate                     99|         99          +0.01%
L1hits                72,161,436| 73,016,280          +1.18%
LLHitRate                      1|          1          -2.08%
LLMissRate                     0|          0         +29.55%
LLdMissRate                    0|          0         +28.06%
LLhits                   694,001|    687,561          -0.93%
LLiMissRate                    0|          0          +7.96%
RamHitRate                     0|          0         +29.55%
RamHits                   23,316|     30,560         +31.07%
TotalRW               72,878,753| 73,734,401          +1.17%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 25,480,374 (master) → 25,493,003 (HEAD) : $$\color{red}+0.05\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.09%
D1mr                     268,334|    269,014          +0.25%
D1mw                      61,867|     61,174          -1.12%
DLmr                         885|        888          +0.34%
DLmw                       3,891|      3,646          -6.30%
Dr                     6,521,091|  6,524,901          +0.06%
Dw                     4,457,692|  4,463,065          +0.12%
EstimatedCycles       38,021,091| 38,023,839          +0.01%
I1MissRate                     0|          0         -12.74%
I1mr                      23,135|     20,197         -12.70%
ILmr                         177|        177          +0.00%
Ir                    25,480,374| 25,493,003          +0.05%
L1HitRate                     99|         99          +0.01%
L1hits                36,105,821| 36,130,584          +0.07%
LLHitRate                      1|          1          -0.84%
LLMissRate                     0|          0          -4.94%
LLdMissRate                    0|          0          -5.15%
LLhits                   348,383|    345,674          -0.78%
LLiMissRate                    0|          0          -0.05%
RamHitRate                     0|          0          -4.94%
RamHits                    4,953|      4,711          -4.89%
TotalRW               36,459,157| 36,480,969          +0.06%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 6,526,024 (master) → 6,399,709 (HEAD) : $$\color{lime}-1.94\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          -3.87%
D1mr                      65,826|     61,328          -6.83%
D1mw                      16,257|     15,908          -2.15%
DLmr                           2|          1         -50.00%
DLmw                         459|        512         +11.55%
Dr                     1,656,930|  1,620,984          -2.17%
Dw                     1,135,240|  1,112,052          -2.04%
EstimatedCycles        9,692,092|  9,486,153          -2.12%
I1MissRate                     0|          0          -7.92%
I1mr                       6,629|      5,986          -9.70%
ILmr                         174|        171          -1.72%
Ir                     6,526,024|  6,399,709          -1.94%
L1HitRate                     99|         99          +0.04%
L1hits                 9,229,482|  9,049,523          -1.95%
LLHitRate                      1|          1          -4.39%
LLMissRate                     0|          0          +9.90%
LLdMissRate                    0|          0         +13.69%
LLhits                    88,077|     82,538          -6.29%
LLiMissRate                    0|          0          +0.22%
RamHitRate                     0|          0          +9.90%
RamHits                      635|        684          +7.72%
TotalRW                9,318,194|  9,132,745          -1.99%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 27,436,386 (master) → 27,452,139 (HEAD) : $$\color{red}+0.06\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.23%
D1mr                     282,001|    281,606          -0.14%
D1mw                      70,260|     70,015          -0.35%
DLmr                         176|        173          -1.70%
DLmw                       4,167|      5,105         +22.51%
Dr                     6,990,990|  6,993,656          +0.04%
Dw                     4,843,938|  4,847,365          +0.07%
EstimatedCycles       40,884,566| 40,925,440          +0.10%
I1MissRate                     0|          0          -9.40%
I1mr                      17,197|     15,589          -9.35%
ILmr                         171|        170          -0.58%
Ir                    27,436,386| 27,452,139          +0.06%
L1HitRate                     99|         99          +0.01%
L1hits                38,901,856| 38,925,950          +0.06%
LLHitRate                      1|          1          -0.93%
LLMissRate                     0|          0         +20.62%
LLdMissRate                    0|          0         +21.47%
LLhits                   364,944|    361,762          -0.87%
LLiMissRate                    0|          0          -0.64%
RamHitRate                     0|          0         +20.62%
RamHits                    4,514|      5,448         +20.69%
TotalRW               39,271,314| 39,293,160          +0.06%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 60,727,684 (master) → 60,522,878 (HEAD) : $$\color{lime}-0.34\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          +1.32%
D1mr                     644,702|    643,742          -0.15%
D1mw                     153,151|    149,444          -2.42%
DLmr                      11,624|      9,637         -17.09%
DLmw                      32,383|     24,786         -23.46%
Dr                    15,536,863| 15,288,937          -1.60%
Dw                    10,591,708| 10,349,334          -2.29%
EstimatedCycles       91,552,357| 90,527,761          -1.12%
I1MissRate                     0|          0         -12.50%
I1mr                      43,360|     37,812         -12.80%
ILmr                         368|        331         -10.05%
Ir                    60,727,684| 60,522,878          -0.34%
L1HitRate                     99|         99          +0.00%
L1hits                86,015,042| 85,330,151          -0.80%
LLHitRate                      1|          1          +0.73%
LLMissRate                     0|          0         -21.05%
LLdMissRate                    0|          0         -20.28%
LLhits                   796,838|    796,244          -0.07%
LLiMissRate                    0|          0          -9.75%
RamHitRate                     0|          0         -21.05%
RamHits                   44,375|     34,754         -21.68%
TotalRW               86,856,255| 86,161,149          -0.80%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 37,400,877 (master) → 37,432,074 (HEAD) : $$\color{red}+0.08\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.13%
D1mr                     401,427|    402,208          +0.19%
D1mw                      90,266|     90,832          +0.63%
DLmr                       2,393|      2,395          +0.08%
DLmw                      11,838|     11,282          -4.70%
Dr                     9,485,033|  9,493,356          +0.09%
Dw                     6,434,351|  6,448,492          +0.22%
EstimatedCycles       55,845,635| 55,872,922          +0.05%
I1MissRate                     0|          0         -12.02%
I1mr                      31,493|     27,730         -11.95%
ILmr                         190|        187          -1.58%
Ir                    37,400,877| 37,432,074          +0.08%
L1HitRate                     99|         99          +0.01%
L1hits                52,797,075| 52,853,152          +0.11%
LLHitRate                      1|          1          -0.47%
LLMissRate                     0|          0          -3.96%
LLdMissRate                    0|          0          -4.03%
LLhits                   508,765|    506,906          -0.37%
LLiMissRate                    0|          0          -1.66%
RamHitRate                     0|          0          -3.96%
RamHits                   14,421|     13,864          -3.86%
TotalRW               53,320,261| 53,373,922          +0.10%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 24,865,535 (master) → 24,873,094 (HEAD) : $$\color{red}+0.03\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.72%
D1mr                     303,799|    302,221          -0.52%
D1mw                      63,888|     63,781          -0.17%
DLmr                      10,124|     10,142          +0.18%
DLmw                      10,526|     10,741          +2.04%
Dr                     6,433,355|  6,447,414          +0.22%
Dw                     4,347,454|  4,361,901          +0.33%
EstimatedCycles       38,529,168| 38,561,835          +0.08%
I1MissRate                     1|          1          -0.58%
I1mr                     149,139|    148,317          -0.55%
ILmr                       6,534|      6,522          -0.18%
Ir                    24,865,535| 24,873,094          +0.03%
L1HitRate                     99|         99          +0.01%
L1hits                35,129,518| 35,168,090          +0.11%
LLHitRate                      1|          1          -0.66%
LLMissRate                     0|          0          +0.71%
LLdMissRate                    0|          0          +0.86%
LLhits                   489,642|    486,914          -0.56%
LLiMissRate                    0|          0          -0.21%
RamHitRate                     0|          0          +0.71%
RamHits                   27,184|     27,405          +0.81%
TotalRW               35,646,344| 35,682,409          +0.10%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 319,060,432 (master) → 318,902,949 (HEAD) : $$\color{lime}-0.05\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     1|          1          -0.41%
D1mr                     794,138|    787,063          -0.89%
D1mw                     481,006|    478,214          -0.58%
DLmr                      14,924|     14,434          -3.28%
DLmw                      51,517|     51,476          -0.08%
Dr                    63,430,465| 63,244,689          -0.29%
Dw                    37,431,975| 37,245,534          -0.50%
EstimatedCycles      436,572,104|435,722,432          -0.19%
I1MissRate                     1|          1          -2.80%
I1mr                   2,322,024|  2,255,858          -2.85%
ILmr                       8,911|      8,914          +0.03%
Ir                   319,060,432|318,902,949          -0.05%
L1HitRate                     99|         99          +0.02%
L1hits               416,325,704|415,872,037          -0.11%
LLHitRate                      1|          1          -2.02%
LLMissRate                     0|          0          -0.58%
LLdMissRate                    0|          0          -0.43%
LLhits                 3,521,816|  3,446,311          -2.14%
LLiMissRate                    0|          0          +0.08%
RamHitRate                     0|          0          -0.58%
RamHits                   75,352|     74,824          -0.70%
TotalRW              419,922,872|419,393,172          -0.13%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 11,234,373 (master) → 11,062,383 (HEAD) : $$\color{lime}-1.53\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     2|          2          +1.55%
D1mr                      65,812|     66,044          +0.35%
D1mw                      24,973|     25,185          +0.85%
DLmr                         502|        526          +4.78%
DLmw                         990|      1,050          +6.06%
Dr                     2,813,877|  2,783,186          -1.09%
Dw                     2,042,429|  2,022,296          -0.99%
EstimatedCycles       16,854,565| 16,637,975          -1.29%
I1MissRate                     0|          0          +2.31%
I1mr                      50,934|     51,311          +0.74%
ILmr                       5,075|      5,089          +0.28%
Ir                    11,234,373| 11,062,383          -1.53%
L1HitRate                     99|         99          -0.02%
L1hits                15,948,960| 15,725,325          -1.40%
LLHitRate                      1|          1          +1.95%
LLMissRate                     0|          0          +2.92%
LLdMissRate                    0|          0          +6.75%
LLhits                   135,152|    135,875          +0.53%
LLiMissRate                    0|          0          +1.83%
RamHitRate                     0|          0          +2.92%
RamHits                    6,567|      6,665          +1.49%
TotalRW               16,090,679| 15,867,865          -1.38%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 24,783,343 (master) → 22,681,433 (HEAD) : $$\color{lime}-8.48\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     2|          2          +7.65%
D1mr                     159,135|    160,044          +0.57%
D1mw                      62,712|     63,129          +0.66%
DLmr                       2,598|      2,614          +0.62%
DLmw                       3,887|      3,438         -11.55%
Dr                     5,893,181|  5,449,864          -7.52%
Dw                     3,859,307|  3,663,452          -5.07%
EstimatedCycles       36,028,839| 33,274,361          -7.65%
I1MissRate                     0|          0          +6.95%
I1mr                      71,335|     69,825          -2.12%
ILmr                       4,191|      4,202          +0.26%
Ir                    24,783,343| 22,681,433          -8.48%
L1HitRate                     99|         99          -0.07%
L1hits                34,242,649| 31,501,751          -8.00%
LLHitRate                      1|          1          +8.71%
LLMissRate                     0|          0          +4.33%
LLdMissRate                    0|          0          -0.13%
LLhits                   282,506|    282,744          +0.08%
LLiMissRate                    0|          0          +9.55%
RamHitRate                     0|          0          +4.33%
RamHits                   10,676|     10,254          -3.95%
TotalRW               34,535,831| 31,794,749          -7.94%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,808,891,020 (master) → 1,761,460,398 (HEAD) : $$\color{lime}-2.62\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     0|          0          +0.88%
D1mr                   1,921,201|  1,912,536          -0.45%
D1mw                     906,956|    901,392          -0.61%
DLmr                     441,497|    437,852          -0.83%
DLmw                     529,756|    531,109          +0.26%
Dr                   427,176,081|421,212,194          -1.40%
Dw                   278,511,134|274,804,273          -1.33%
EstimatedCycles      2,560,179,793|2,503,099,965          -2.23%
I1MissRate                     0|          0          +5.76%
I1mr                   1,242,325|  1,279,452          +2.99%
ILmr                       6,068|      6,025          -0.71%
Ir                   1,808,891,020|1,761,460,398          -2.62%
L1HitRate                    100|        100          -0.00%
L1hits               2,510,507,753|2,453,383,485          -2.28%
LLHitRate                      0|          0          +3.16%
LLMissRate                     0|          0          +2.08%
LLdMissRate                    0|          0          +1.15%
LLhits                 3,093,161|  3,118,394          +0.82%
LLiMissRate                    0|          0          +1.96%
RamHitRate                     0|          0          +2.08%
RamHits                  977,321|    974,986          -0.24%
TotalRW              2,514,578,235|2,457,476,865          -2.27%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 21,723,169 (master) → 21,815,980 (HEAD) : $$\color{red}+0.43\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.69%
D1mr                     233,270|    235,296          +0.87%
D1mw                      55,284|     56,837          +2.81%
DLmr                       5,496|      5,494          -0.04%
DLmw                       7,735|      7,579          -2.02%
Dr                     5,470,055|  5,559,187          +1.63%
Dw                     3,693,506|  3,782,716          +2.42%
EstimatedCycles       33,017,242| 33,295,171          +0.84%
I1MissRate                     1|          1          -0.97%
I1mr                     114,444|    113,819          -0.55%
ILmr                       4,053|      4,043          -0.25%
Ir                    21,723,169| 21,815,980          +0.43%
L1HitRate                     99|         99          +0.00%
L1hits                30,483,732| 30,751,931          +0.88%
LLHitRate                      1|          1          -0.07%
LLMissRate                     0|          0          -1.83%
LLdMissRate                    0|          0          -3.08%
LLhits                   385,714|    388,836          +0.81%
LLiMissRate                    0|          0          -0.67%
RamHitRate                     0|          0          -1.83%
RamHits                   17,284|     17,116          -0.97%
TotalRW               30,886,730| 31,157,883          +0.88%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 8,304,493 (master) → 8,305,726 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     6|          6          +0.03%
D1mr                     212,854|    212,932          +0.04%
D1mw                       3,431|      3,413          -0.52%
DLmr                       3,298|      3,748         +13.64%
DLmw                          73|        142         +94.52%
Dr                     2,386,027|  2,386,130          +0.00%
Dw                     1,326,449|  1,326,361          -0.01%
EstimatedCycles       12,991,569| 13,008,543          +0.13%
I1MissRate                     0|          0          -1.21%
I1mr                         500|        494          -1.20%
ILmr                         211|        209          -0.95%
Ir                     8,304,493|  8,305,726          +0.01%
L1HitRate                     98|         98          -0.00%
L1hits                11,800,184| 11,801,378          +0.01%
LLHitRate                      2|          2          -0.23%
LLMissRate                     0|          0         +14.42%
LLdMissRate                    0|          0         +15.40%
LLhits                   213,203|    212,740          -0.22%
LLiMissRate                    0|          0          -0.96%
RamHitRate                     0|          0         +14.42%
RamHits                    3,582|      4,099         +14.43%
TotalRW               12,016,969| 12,018,217          +0.01%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 6,308,615 (master) → 6,308,232 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     5|          5          +0.68%
D1mr                     133,453|    134,442          +0.74%
D1mw                       3,803|      3,753          -1.31%
DLmr                      11,136|     10,830          -2.75%
DLmw                          87|         94          +8.05%
Dr                     1,883,427|  1,883,463          +0.00%
Dw                     1,072,157|  1,072,307          +0.01%
EstimatedCycles       10,159,341| 10,154,264          -0.05%
I1MissRate                     0|          0          +0.20%
I1mr                         512|        513          +0.20%
ILmr                         246|        257          +4.47%
Ir                     6,308,615|  6,308,232          -0.01%
L1HitRate                     99|         99          -0.01%
L1hits                 9,126,431|  9,125,294          -0.01%
LLHitRate                      1|          1          +0.97%
LLMissRate                     0|          0          -2.51%
LLdMissRate                    0|          0          -2.67%
LLhits                   126,299|    127,527          +0.97%
LLiMissRate                    0|          0          +4.48%
RamHitRate                     0|          0          -2.51%
RamHits                   11,469|     11,181          -2.51%
TotalRW                9,264,199|  9,264,002          -0.00%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(parametric-dunescape)
Instructions: 3,528,807 (master) → 3,526,952 (HEAD) : $$\color{lime}-0.05\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     5|          5          +0.25%
D1mr                      88,209|     88,428          +0.25%
D1mw                       2,707|      2,659          -1.77%
DLmr                          31|         30          -3.23%
DLmw                         NaN|        NaN          +0.00%
Dr                     1,062,233|  1,061,553          -0.06%
Dw                       622,181|    621,778          -0.06%
EstimatedCycles        5,584,673|  5,582,419          -0.04%
I1MissRate                     0|          0          +0.05%
I1mr                         462|        462          +0.00%
ILmr                         167|        168          +0.60%
Ir                     3,528,807|  3,526,952          -0.05%
L1HitRate                     98|         98          -0.00%
L1hits                 5,121,843|  5,118,734          -0.06%
LLHitRate                      2|          2          +0.24%
LLMissRate                     0|          0          +0.06%
LLdMissRate                    0|          0          -3.16%
LLhits                    91,180|     91,351          +0.19%
LLiMissRate                    0|          0          +0.65%
RamHitRate                     0|          0          +0.06%
RamHits                      198|        198          +0.00%
TotalRW                5,213,221|  5,210,283          -0.06%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(red-dress)
Instructions: 34,468,690 (master) → 34,467,578 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     4|          4          +0.00%
D1mr                     602,637|    602,606          -0.01%
D1mw                      30,729|     30,794          +0.21%
DLmr                     262,295|    262,633          +0.13%
DLmw                       1,345|      1,263          -6.10%
Dr                     9,836,152|  9,836,373          +0.00%
Dw                     5,214,924|  5,215,187          +0.01%
EstimatedCycles       59,977,604| 59,984,760          +0.01%
I1MissRate                     0|          0          -1.59%
I1mr                         501|        493          -1.60%
ILmr                         439|        439          +0.00%
Ir                    34,468,690| 34,467,578          -0.00%
L1HitRate                     99|         99          -0.00%
L1hits                48,885,899| 48,885,245          -0.00%
LLHitRate                      1|          1          -0.06%
LLMissRate                     1|          1          +0.10%
LLdMissRate                    2|          2          +0.09%
LLhits                   369,788|    369,558          -0.06%
LLiMissRate                    0|          0          +0.00%
RamHitRate                     1|          1          +0.10%
RamHits                  264,079|    264,335          +0.10%
TotalRW               49,519,766| 49,519,138          -0.00%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(valley-of-spires)
Instructions: 6,481,866 (master) → 6,480,349 (HEAD) : $$\color{lime}-0.02\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1MissRate                     6|          6          -0.03%
D1mr                     160,923|    160,772          -0.09%
D1mw                       2,960|      3,018          +1.96%
DLmr                         142|        269         +89.44%
DLmw                           4|         16        +300.00%
Dr                     1,873,576|  1,873,006          -0.03%
Dw                     1,048,245|  1,047,937          -0.03%
EstimatedCycles       10,071,223| 10,072,396          +0.01%
I1MissRate                     0|          0          -1.02%
I1mr                         481|        476          -1.04%
ILmr                         190|        183          -3.68%
Ir                     6,481,866|  6,480,349          -0.02%
L1HitRate                     98|         98          +0.00%
L1hits                 9,239,323|  9,237,026          -0.02%
LLHitRate                      2|          2          -0.11%
LLMissRate                     0|          0         +39.32%
LLdMissRate                    0|          0         +95.26%
LLhits                   164,028|    163,798          -0.14%
LLiMissRate                    0|          0          -3.66%
RamHitRate                     0|          0         +39.32%
RamHits                      336|        468         +39.29%
TotalRW                9,403,687|  9,401,292          -0.03%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Keavon