Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates numerous development dependencies across the project, including upgrades to TypeScript 6.0.2 and Svelte 5.55.1. It also adds notes in the package.json files to document blockers for future ESLint upgrades. The review feedback suggests using more standard keys like _comment or description for metadata in JSON files instead of the non-standard // and /// keys.
| "wasm:watch-production": "cargo watch --postpone --watch-when-idle --workdir=wrapper --shell \"wasm-pack build . --release --target=web -- --color=always\"" | ||
| }, | ||
| "//": "NOTE: `source-sans-pro` is never to be upgraded to 3.x because that renders 1px above its intended position.", | ||
| "///": "Waiting on <https://github.com/import-js/eslint-plugin-import/issues/3227> before we can update @eslint/js and eslint to 10.x", |
There was a problem hiding this comment.
The comment prefix /// is non-standard for JSON files. While technically valid as a key, it is not a standard way to document dependencies. Consider using a dedicated _comment or description field if this is intended to be machine-readable, or keep it as a standard comment key if the parser supports it.
| "check": "tsc --noEmit && eslint", | ||
| "fix": "eslint --fix" | ||
| }, | ||
| "//": "Waiting on <https://github.com/import-js/eslint-plugin-import/issues/3227> before we can update @eslint/js and eslint to 10.x", |
There was a problem hiding this comment.
The comment prefix // is non-standard for JSON files. While technically valid as a key, it is not a standard way to document dependencies. Consider using a dedicated _comment or description field if this is intended to be machine-readable, or keep it as a standard comment key if the parser supports it.
1 participant
This successfully includes support for TypeScript 6, its final version before their native port arrives in the following major version, which we can look forward to upgrading to upon its release soon.