Skip to content

Add tooltip descriptions#4005

Open
LennartKDeveloper wants to merge 3 commits intoGraphiteEditor:masterfrom
LennartKDeveloper:adding-tooltip_desciptions
Open

Add tooltip descriptions#4005
LennartKDeveloper wants to merge 3 commits intoGraphiteEditor:masterfrom
LennartKDeveloper:adding-tooltip_desciptions

Conversation

@LennartKDeveloper
Copy link
Copy Markdown

Replaced the TODO in shape_utility.rs with descriptive tooltips for all shape tools (Polygon, Star, Circle, Arc, Spiral, Grid, Arrow, Line, Rectangle, and Ellipse).

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements descriptive tooltips for various shape tools by replacing a placeholder match arm with specific descriptions for Polygon, Star, Circle, Arc, Spiral, Grid, Arrow, Line, Rectangle, and Ellipse. A review comment suggests refining the Grid tool's description to use 'cells' instead of 'rectangles' to more accurately reflect its support for isometric grids.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 4/5

  • This PR looks safe to merge from a code-risk perspective; the reported issue is process/policy related rather than a functional regression in editor/src/messages/tool/common_functionality/shapes/shape_utility.rs.
  • The most severe flagged item is PR title enforcement (imperative mood), which may block workflow compliance but should not impact runtime behavior or user-facing functionality.
  • Pay close attention to editor/src/messages/tool/common_functionality/shapes/shape_utility.rs - confirm no hidden code changes are tied to the title-policy warning.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/messages/tool/common_functionality/shapes/shape_utility.rs">

<violation number="1" location="editor/src/messages/tool/common_functionality/shapes/shape_utility.rs:72">
P1: Custom agent: **PR title enforcement**

PR title "Adding tooltip desciptions" violates the title rule requiring imperative mood. Rename it to an imperative form, e.g. "Add tooltip descriptions".</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@@ -69,8 +69,16 @@ impl ShapeType {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Custom agent: PR title enforcement

PR title "Adding tooltip desciptions" violates the title rule requiring imperative mood. Rename it to an imperative form, e.g. "Add tooltip descriptions".

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At editor/src/messages/tool/common_functionality/shapes/shape_utility.rs, line 72:

<comment>PR title "Adding tooltip desciptions" violates the title rule requiring imperative mood. Rename it to an imperative form, e.g. "Add tooltip descriptions".</comment>

<file context>
@@ -69,8 +69,16 @@ impl ShapeType {
 		(match self {
-			// TODO: Add descriptions to all the shape tools
-			_ => "",
+			Self::Polygon => "Draw a regular polygon.",
+			Self::Star => "Draw a star-shaped polygon.",
+			Self::Circle => "Draw a circle.",
</file context>

…lity.rs

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@LennartKDeveloper LennartKDeveloper changed the title Adding tooltip desciptions Add tooltip desciptions Apr 4, 2026
@LennartKDeveloper LennartKDeveloper changed the title Add tooltip desciptions Add tooltip descriptions Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant