Skip to content

Fix Layer Transformation #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsjgdh wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

Fix Layer Transformation #4008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion editor/src/messages/tool/tool_messages/select_tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use super::tool_prelude::*;
use crate::consts::*;
use crate::messages::input_mapper::utility_types::input_mouse::ViewportPosition;
use crate::messages::portfolio::document::graph_operation::utility_types::TransformIn;
use crate::messages::portfolio::document::graph_operation::utility_types::{ModifyInputsContext, TransformIn};
use crate::messages::portfolio::document::node_graph::document_node_definitions::DefinitionIdentifier;
use crate::messages::portfolio::document::overlays::utility_types::OverlayContext;
use crate::messages::portfolio::document::utility_types::document_metadata::{DocumentMetadata, LayerNodeIdentifier};
Expand Down Expand Up @@ -1179,7 +1179,13 @@ impl Fsm for SelectToolFsmState {
};

// TODO: Cache the result of `shallowest_unique_layers` to avoid this heavy computation every frame of movement, see https://github.com/GraphiteEditor/Graphite/pull/481
let transform_ref = DefinitionIdentifier::Network("Transform".into());
let mut transformed_nodes = HashSet::new();
for layer in document.network_interface.shallowest_unique_layers(&[]) {
let transform_node_id = ModifyInputsContext::locate_node_in_layer_chain(&transform_ref, layer, &document.network_interface);
if transform_node_id.is_some_and(|id| !transformed_nodes.insert(id)) {
continue;
}
responses.add_front(GraphOperationMessage::TransformChange {
layer,
transform: DAffine2::from_translation(mouse_delta),
Expand Down
Loading