Conversation
… type boundary newtype
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a nominal Artboard struct as a wrapper around Table, replacing the previous nested Table<Table> type throughout the codebase. This architectural change improves type safety and clarity by establishing a clear boundary for artboard content. The modifications span the node registry, rendering logic, serialization, and various node implementations to support the new Table type. I have no feedback to provide as there were no review comments to assess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the same approach taken by the
Graphicstruct which is an enum over multiple wrapped types acting as a boundary for the boundless type explosion from infinite nestings ofTable<Table<...<all graphical types>>>. Now,Artboardis a newtype script that wrapsTable<Graphic>just asGraphichas arms that wrapTable<all graphical types>. This represents an explicit loss of data purity that takes the form of a new named base type, not simply an extra nesting level of the base type.Followup to #4077. Partly closes #3779.