Fix pre-rename text domain on three REST strings#1674
Open
thisismyurl wants to merge 1 commit into
Open
Conversation
The declared Text Domain is 'gravity-pdf', but three REST argument strings in Rest_Download_Pdf.php still use the pre-rename 'gravity-forms-pdf-extended' domain, so they never resolve to a translation. Point them at 'gravity-pdf', matching the correct sibling calls in the same file (lines 144/151/378). The legacy-slug identity checks in the updater are left untouched.
There was a problem hiding this comment.
Pull request overview
Updates three REST API argument strings in Rest_Download_Pdf to use the plugin’s current text domain (gravity-pdf) so they can be translated correctly, aligning with other translation calls already in the same file.
Changes:
- Switch REST route arg
descriptionstrings fromgravity-forms-pdf-extendedtogravity-pdf. - Switch a REST validation error message string domain to
gravity-pdf. - Ensure text domain usage is consistent with existing strings in this REST controller.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three REST argument strings in
src/Rest/Rest_Download_Pdf.phpstill use the pre-rename'gravity-forms-pdf-extended'domain, while the plugin declaresText Domain: gravity-pdf. They never resolve to a translation as a result.This points them at
'gravity-pdf', matching the correct sibling calls in the same file (lines 144/151/378). I left the legacy-slug identity checks in the updater alone, since those reference the old slug on purpose.The REST download flow in Gravity PDF is thoughtfully built. Happy to help a few strings in it translate.
(full disclosure: AI helped me find the mismatch and confirm the updater checks were intentional; the change and this note are mine.)