fix(config): remove t.Parallel from tests sharing global singletons (#53)

Patel230 · web-flow · commit 072fcdf1f331 · 2026-06-26T22:01:35.000+05:30
* chore: add CODEOWNERS and dependabot.yml

Add CODEOWNERS for PR review routing and dependabot.yml for automated
dependency updates (gomod + github-actions, weekly, grouped).

* test: add t.Parallel() to unit tests for concurrent execution

* chore: remove dependabot.yml

* fix(config): remove t.Parallel from tests that share global singletons

Tests mutating credentials.SetDefaultStore and ResetCategoryRegistry
raced when run in parallel — remove t.Parallel only from those tests.
diff --git a/config/category_test.go b/config/category_test.go
@@ -18,7 +18,6 @@ func TestDefaultCategories_AllPresent(t *testing.T) {
 }
 
 func TestCategoryRegistry_Resolve(t *testing.T) {
-	t.Parallel()
 	ResetCategoryRegistry()
 	defer ResetCategoryRegistry()
 
@@ -34,7 +33,6 @@ func TestCategoryRegistry_Resolve(t *testing.T) {
 }
 
 func TestCategoryRegistry_ResolveFallback(t *testing.T) {
-	t.Parallel()
 	ResetCategoryRegistry()
 	defer ResetCategoryRegistry()
 
@@ -49,7 +47,6 @@ func TestCategoryRegistry_ResolveFallback(t *testing.T) {
 }
 
 func TestCategoryRegistry_Override(t *testing.T) {
-	t.Parallel()
 	ResetCategoryRegistry()
 	defer ResetCategoryRegistry()
 
@@ -66,7 +63,6 @@ func TestCategoryRegistry_Override(t *testing.T) {
 }
 
 func TestCategoryRegistry_ResolveWithDefaults(t *testing.T) {
-	t.Parallel()
 	ResetCategoryRegistry()
 	defer ResetCategoryRegistry()
 
@@ -89,7 +85,6 @@ func TestCategoryRegistry_ResolveWithDefaults(t *testing.T) {
 }
 
 func TestCategoryRegistry_AllCategories(t *testing.T) {
-	t.Parallel()
 	ResetCategoryRegistry()
 	defer ResetCategoryRegistry()
 
@@ -101,7 +96,6 @@ func TestCategoryRegistry_AllCategories(t *testing.T) {
 }
 
 func TestResolveCategory_Convenience(t *testing.T) {
-	t.Parallel()
 	ResetCategoryRegistry()
 	defer ResetCategoryRegistry()
 
diff --git a/config/config_test.go b/config/config_test.go
@@ -10,7 +10,6 @@ import (
 )
 
 func TestResolveProviderRequest(t *testing.T) {
-	t.Parallel()
 	// Clear provider env vars to test default resolution
 	os.Unsetenv("OPENAI_BASE_URL")
 	os.Unsetenv("OPENAI_API_BASE")
@@ -56,7 +55,6 @@ func TestIsLocalProviderURL(t *testing.T) {
 }
 
 func TestIsOpenAICompatibleRuntimeEnabled(t *testing.T) {
-	t.Parallel()
 	store := &credentials.MapStore{}
 	credentials.SetDefaultStore(store)
 	t.Cleanup(func() { credentials.SetDefaultStore(nil) })
diff --git a/config/runtime_test.go b/config/runtime_test.go
@@ -119,7 +119,6 @@ func TestProviderModelEnvKeys_AllProvidersPresent(t *testing.T) {
 }
 
 func TestResolveOpenAICompatibleRuntime_WithEnv(t *testing.T) {
-	t.Parallel()
 	store := &credentials.MapStore{}
 	credentials.SetDefaultStore(store)
 	t.Cleanup(func() { credentials.SetDefaultStore(nil) })
@@ -141,7 +140,6 @@ func TestResolveOpenAICompatibleRuntime_WithEnv(t *testing.T) {
 }
 
 func TestResolveOpenAICompatibleRuntime_GrokProvider(t *testing.T) {
-	t.Parallel()
 	store := &credentials.MapStore{}
 	credentials.SetDefaultStore(store)
 	t.Cleanup(func() { credentials.SetDefaultStore(nil) })
@@ -160,7 +158,6 @@ func TestResolveOpenAICompatibleRuntime_GrokProvider(t *testing.T) {
 }
 
 func TestResolveOpenAICompatibleRuntime_FallbackModel(t *testing.T) {
-	t.Parallel()
 	clearKeys := []string{
 		"OPENROUTER_API_KEY", "XAI_API_KEY", "GEMINI_API_KEY",
 		"ANTHROPIC_API_KEY", "CANOPYWAVE_API_KEY", "DEEPSEEK_API_KEY", "ZAI_API_KEY", "OPENAI_API_KEY",
@@ -180,7 +177,6 @@ func TestResolveOpenAICompatibleRuntime_FallbackModel(t *testing.T) {
 }
 
 func TestResolveOpenAICompatibleRuntime_NoKeys(t *testing.T) {
-	t.Parallel()
 	store := &credentials.MapStore{}
 	credentials.SetDefaultStore(store)
 	t.Cleanup(func() { credentials.SetDefaultStore(nil) })

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ func TestDefaultCategories_AllPresent(t *testing.T) {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`func TestCategoryRegistry_Resolve(t *testing.T) {`
`21`		`- t.Parallel()`
`22`	`21`	`ResetCategoryRegistry()`
`23`	`22`	`defer ResetCategoryRegistry()`
`24`	`23`
`@@ -34,7 +33,6 @@ func TestCategoryRegistry_Resolve(t *testing.T) {`
`34`	`33`	`}`
`35`	`34`
`36`	`35`	`func TestCategoryRegistry_ResolveFallback(t *testing.T) {`
`37`		`- t.Parallel()`
`38`	`36`	`ResetCategoryRegistry()`
`39`	`37`	`defer ResetCategoryRegistry()`
`40`	`38`
`@@ -49,7 +47,6 @@ func TestCategoryRegistry_ResolveFallback(t *testing.T) {`
`49`	`47`	`}`
`50`	`48`
`51`	`49`	`func TestCategoryRegistry_Override(t *testing.T) {`
`52`		`- t.Parallel()`
`53`	`50`	`ResetCategoryRegistry()`
`54`	`51`	`defer ResetCategoryRegistry()`
`55`	`52`
`@@ -66,7 +63,6 @@ func TestCategoryRegistry_Override(t *testing.T) {`
`66`	`63`	`}`
`67`	`64`
`68`	`65`	`func TestCategoryRegistry_ResolveWithDefaults(t *testing.T) {`
`69`		`- t.Parallel()`
`70`	`66`	`ResetCategoryRegistry()`
`71`	`67`	`defer ResetCategoryRegistry()`
`72`	`68`
`@@ -89,7 +85,6 @@ func TestCategoryRegistry_ResolveWithDefaults(t *testing.T) {`
`89`	`85`	`}`
`90`	`86`
`91`	`87`	`func TestCategoryRegistry_AllCategories(t *testing.T) {`
`92`		`- t.Parallel()`
`93`	`88`	`ResetCategoryRegistry()`
`94`	`89`	`defer ResetCategoryRegistry()`
`95`	`90`
`@@ -101,7 +96,6 @@ func TestCategoryRegistry_AllCategories(t *testing.T) {`
`101`	`96`	`}`
`102`	`97`
`103`	`98`	`func TestResolveCategory_Convenience(t *testing.T) {`
`104`		`- t.Parallel()`
`105`	`99`	`ResetCategoryRegistry()`
`106`	`100`	`defer ResetCategoryRegistry()`
`107`	`101`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ import (`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`func TestResolveProviderRequest(t *testing.T) {`
`13`		`- t.Parallel()`
`14`	`13`	`// Clear provider env vars to test default resolution`
`15`	`14`	`os.Unsetenv("OPENAI_BASE_URL")`
`16`	`15`	`os.Unsetenv("OPENAI_API_BASE")`
`@@ -56,7 +55,6 @@ func TestIsLocalProviderURL(t *testing.T) {`
`56`	`55`	`}`
`57`	`56`
`58`	`57`	`func TestIsOpenAICompatibleRuntimeEnabled(t *testing.T) {`
`59`		`- t.Parallel()`
`60`	`58`	`store := &credentials.MapStore{}`
`61`	`59`	`credentials.SetDefaultStore(store)`
`62`	`60`	`t.Cleanup(func() { credentials.SetDefaultStore(nil) })`