fix: H11 provider-registry drift (minimax_* missing from runtime map, docs 12→15) (#39)

* fix(client): register minimax_token_plan and minimax_payg in OpenAICompatibleProviders + DetectProvider

* test(client): add provider-registry drift test to prevent future mismatches

* docs: sync provider counts (12 → 15) in CREDENTIAL-SETUP-FLOW and DYNAMIC-MODEL-DISCOVERY

* test(client): make provider-registry drift test robust to test shuffling

The drift test was reading CoreProviders/OpenAICompatibleProviders directly,
so any test that called RegisterDynamicProvider at runtime (e.g.
TestDynamicProvider_OptIn_Registers) would pollute the maps and cause
TestProviderRegistry_NoDriftFromCatalog to fail under -shuffle=on.

Capture the static maps once at init() time into staticProviderNames and
compare against the snapshot. This is the same robustness pattern used by
other tests in the package.

Author: Patel230

client/provider_registry.go

@@ -64,6 +64,8 @@ var OpenAICompatibleProviders = map[string]ProviderRegistryConfig{
 	"kimi":                   {Name: "kimi", Type: ProviderTypeOpenAICompatible, BaseURL: config.DefaultKimiOpenAIBaseURL, EnvKey: "MOONSHOT_API_KEY", SupportsStreaming: true, SupportsTools: true, SupportsReasoning: true},
 	"xiaomi_mimo_payg":       {Name: "xiaomi_mimo_payg", Type: ProviderTypeOpenAICompatible, BaseURL: config.DefaultXiaomiOpenAIBaseURL, EnvKey: config.EnvXiaomiPaygAPIKey, SupportsStreaming: true, SupportsTools: true, SupportsReasoning: true},
 	"xiaomi_mimo_token_plan": {Name: "xiaomi_mimo_token_plan", Type: ProviderTypeOpenAICompatible, BaseURL: "", EnvKey: config.EnvXiaomiTokenPlanAPIKey, SupportsStreaming: true, SupportsTools: true, SupportsReasoning: true},
+	"minimax_token_plan":     {Name: "minimax_token_plan", Type: ProviderTypeOpenAICompatible, BaseURL: "https://api.minimax.io/v1", EnvKey: "MINIMAX_TOKEN_PLAN_API_KEY", SupportsStreaming: true, SupportsTools: true, SupportsReasoning: true},
+	"minimax_payg":           {Name: "minimax_payg", Type: ProviderTypeOpenAICompatible, BaseURL: "https://api.minimax.io/v1", EnvKey: "MINIMAX_PAYG_API_KEY", SupportsStreaming: true, SupportsTools: true, SupportsReasoning: true},
 }
 
 // GetProviders lists all available providers.
@@ -239,6 +241,12 @@ func DetectProvider() string {
 		"xiaomi_mimo_token_plan": func() bool {
 			return credentials.HasSecret(ctx, config.EnvXiaomiTokenPlanAPIKey)
 		},
+		"minimax_token_plan": func() bool {
+			return credentials.HasSecret(ctx, "MINIMAX_TOKEN_PLAN_API_KEY")
+		},
+		"minimax_payg": func() bool {
+			return credentials.HasSecret(ctx, "MINIMAX_PAYG_API_KEY")
+		},
 		"ollama": func() bool { return resolveEnvSecret("OLLAMA_BASE_URL") != "" },
 		"azure": func() bool {
 			return credentials.HasSecret(ctx, "AZURE_OPENAI_API_KEY") && resolveEnvSecret("AZURE_OPENAI_ENDPOINT") != ""

client/provider_registry_drift_test.go

@@ -0,0 +1,76 @@
+//nolint:errcheck
+package client
+
+import (
+	"sort"
+	"testing"
+
+	"github.com/GrayCodeAI/eyrie/catalog/registry"
+)
+
+// staticProviderNames is a snapshot of every provider in the static runtime
+// maps, captured at init() time. Tests that mutate the maps at runtime (e.g.
+// TestDynamicProvider_OptIn_Registers calling RegisterDynamicProvider) would
+// otherwise corrupt a naive len()-based drift check, so we always compare
+// against this snapshot.
+var staticProviderNames map[string]bool
+
+func init() {
+	staticProviderNames = make(map[string]bool, len(CoreProviders)+len(OpenAICompatibleProviders))
+	for k := range CoreProviders {
+		staticProviderNames[k] = true
+	}
+	for k := range OpenAICompatibleProviders {
+		staticProviderNames[k] = true
+	}
+}
+
+// TestProviderRegistry_NoDriftFromCatalog guards against future drift between
+// the static runtime provider maps (CoreProviders, OpenAICompatibleProviders)
+// and the authoritative spec list in catalog/registry. If a new ProviderSpec
+// is added to catalog/registry/providers.go without a corresponding static
+// runtime entry, or vice versa, the test fails and the PR is blocked.
+//
+// This regression test was introduced for H11 (provider-registry drift):
+// minimax_token_plan and minimax_payg were present in catalog/registry but
+// missing from OpenAICompatibleProviders, causing NewOpenAICompatibleClient
+// to mis-route callers to NewOpenAIClient with BaseURL="" (4xx).
+func TestProviderRegistry_NoDriftFromCatalog(t *testing.T) {
+	specs := registry.All()
+	specNames := make(map[string]bool, len(specs))
+	for _, s := range specs {
+		specNames[s.ProviderID] = true
+	}
+
+	// Every spec must be present in the static runtime snapshot.
+	var missingInRuntime []string
+	for _, s := range specs {
+		if !staticProviderNames[s.ProviderID] {
+			missingInRuntime = append(missingInRuntime, s.ProviderID)
+		}
+	}
+	if len(missingInRuntime) > 0 {
+		sort.Strings(missingInRuntime)
+		t.Fatalf(
+			"provider-registry drift: %d spec(s) in catalog/registry/providers.go "+
+				"are missing from the static runtime maps: %v",
+			len(missingInRuntime), missingInRuntime,
+		)
+	}
+
+	// Every static runtime entry must be present in catalog/registry.
+	var staleInRuntime []string
+	for name := range staticProviderNames {
+		if !specNames[name] {
+			staleInRuntime = append(staleInRuntime, name)
+		}
+	}
+	if len(staleInRuntime) > 0 {
+		sort.Strings(staleInRuntime)
+		t.Fatalf(
+			"provider-registry drift: %d provider(s) in client/provider_registry.go "+
+				"(static) are missing from catalog/registry/providers.go: %v",
+			len(staleInRuntime), staleInRuntime,
+		)
+	}
+}

docs/ARCHITECTURE.md

@@ -104,6 +104,8 @@ Auto-detects active provider from env vars in priority order:
 | 7 | `ZAI_API_KEY` | <img src="https://cdn.jsdelivr.net/gh/lucide-icons/lucide@latest/icons/bot.svg" width="16" height="16" alt="bot" /> ZAI |
 | 8 | — | <img src="https://cdn.jsdelivr.net/gh/lucide-icons/lucide@latest/icons/server.svg" width="16" height="16" alt="server" /> Ollama (localhost socket) |
 
+*Top 8 by priority; 7 more (`azure`, `bedrock`, `vertex`, `deepseek`, `opencodego`, `kimi`, `xiaomi_mimo_payg`, `xiaomi_mimo_token_plan`, `minimax_token_plan`, `minimax_payg`) — see [`CREDENTIAL-SETUP-FLOW.md`](./guides/CREDENTIAL-SETUP-FLOW.md).*
+
 ---
 
 ## <img src="https://cdn.jsdelivr.net/gh/lucide-icons/lucide@latest/icons/radio.svg" width="16" height="16" alt="radio" /> Streaming

docs/guides/CREDENTIAL-SETUP-FLOW.md

@@ -4,13 +4,14 @@
 
 See also: [DYNAMIC-MODEL-DISCOVERY.md](./DYNAMIC-MODEL-DISCOVERY.md)
 
-## Supported providers (12 — from `catalog/registry`)
+## Supported providers (15 — from `catalog/registry`)
 
 | Provider | ID | Credential | Picker models |
 |----------|-----|------------|---------------|
 | Anthropic | `anthropic` | `ANTHROPIC_API_KEY` | live `/v1/models` only |
 | OpenAI | `openai` | `OPENAI_API_KEY` | live `/v1/models` only |
 | Google Gemini | `gemini` | `GEMINI_API_KEY` | live models API only |
+| DeepSeek | `deepseek` | `DEEPSEEK_API_KEY` | live `/models` only |
 | OpenRouter | `openrouter` | `OPENROUTER_API_KEY` | live `/models` only |
 | xAI (Grok) | `grok` | `XAI_API_KEY` | live `/v1/models` only |
 | Z.AI | `z-ai` | `ZAI_API_KEY` | live `/models` only |
@@ -19,6 +20,8 @@ See also: [DYNAMIC-MODEL-DISCOVERY.md](./DYNAMIC-MODEL-DISCOVERY.md)
 | Kimi (Moonshot) | `kimi` | `MOONSHOT_API_KEY` | live `/models` only |
 | Xiaomi (MiMo) Pay-as-you-go | `xiaomi_mimo_payg` | `XIAOMI_MIMO_PAYG_API_KEY` | `https://api.xiaomimimo.com/v1` (`sk-` keys) |
 | Xiaomi (MiMo) Token Plan | `xiaomi_mimo_token_plan` | `XIAOMI_MIMO_TOKEN_PLAN_API_KEY` | region: `cn` / `sgp` / `ams` (`tp-` keys) |
+| MiniMax (minimax) Token Plan | `minimax_token_plan` | `MINIMAX_TOKEN_PLAN_API_KEY` | `https://api.minimax.io/v1` |
+| MiniMax (minimax) Pay-as-you-go | `minimax_payg` | `MINIMAX_PAYG_API_KEY` | `https://api.minimax.io/v1` |
 | Ollama (local) | `ollama` | `OLLAMA_BASE_URL` | live `/api/tags` only |
 
 Single source: `eyrie/catalog/registry/providers.go`

docs/guides/DYNAMIC-MODEL-DISCOVERY.md

@@ -37,14 +37,14 @@ User → Hawk /config
 
 | Area | Problem |
 |------|---------|
-| **Live fetch** | All 12 setup gateways have fetchers; some older gateways still have thin test coverage (z-ai, opencodego, kimi). MiMo split: `xiaomi_mimo_payg`, `xiaomi_mimo_token_plan` (`catalog/live/xiaomi_test.go`, `catalog/xiaomi/`). Anthropic, Gemini, Ollama RawJSON gaps remain |
+| **Live fetch** | All 15 setup gateways have fetchers; some older gateways still have thin test coverage (z-ai, opencodego, kimi). MiMo split: `xiaomi_mimo_payg`, `xiaomi_mimo_token_plan` (`catalog/live/xiaomi_test.go`, `catalog/xiaomi/`). Anthropic, Gemini, Ollama RawJSON gaps remain |
 | **Ollama** | No longer bypasses `ListModels`; RetryConfig moved to ProviderSpec. Remaining: hardcoded `== "ollama"` in validation |
 | **Registry drift** | ✅ Fixed — `CredentialProviderRegistry` and `liveDiscoverableDeployments` removed; `DefaultDeploymentEnvFallbacks` consolidated (Item 1) |
 | **Layering** | Hawk still has ~112 files with direct eyrie imports (Phase A facade done, B-D remain) |
 | **Legacy API** | `FetchModelCatalog` / `providers.go` slices coexist with catalog v1 |
 | **Merge policy** | ✅ Live replace — prefer-live providers fully replace models; offerings merge pricing/metadata |
 | **Display names** | `BuildSetupUI` has partial hardcoded provider labels |
-| **Docs** | ✅ `CREDENTIAL-SETUP-FLOW.md` lists all 12 gateways (incl. MiMo payg + token plan) with live-only picker |
+| **Docs** | ✅ `CREDENTIAL-SETUP-FLOW.md` lists all 15 gateways (incl. MiMo payg + token plan, DeepSeek, MiniMax token plan + payg) with live-only picker |
 
 ---
 
@@ -280,6 +280,7 @@ Provider-specific friendly text lives in eyrie, not hawk cmd.
 | **Anthropic** | `ANTHROPIC_API_KEY` | `GET /v1/models` | `/v1/models` fetcher | Rate limits on list |
 | **OpenAI** | `OPENAI_API_KEY` | `GET /v1/models` | `/v1/models` | Org-scoped model lists differ |
 | **Gemini** | `GEMINI_API_KEY` | `GET /v1beta/models` | Gemini models API | Key in query param |
+| **DeepSeek** | `DEEPSEEK_API_KEY` | `GET /models` | OpenAI-compat `/models` | `https://api.deepseek.com/v1` |
 | **OpenRouter** | `OPENROUTER_API_KEY` | `GET /models` | Already live | Largest dynamic catalog |
 | **Grok/xAI** | `XAI_API_KEY` | `GET /v1/models` | `/v1/models` | OpenAI-compatible |
 | **Z.AI** | `ZAI_API_KEY` | `GET /models` | OpenAI-compat `/models` | Base URL env fallbacks |
@@ -288,6 +289,8 @@ Provider-specific friendly text lives in eyrie, not hawk cmd.
 | **Kimi (Moonshot)** | `MOONSHOT_API_KEY` | `GET /models` | OpenAI-compat `/models` | Provider id `kimi` |
 | **Xiaomi (MiMo) Pay-as-you-go** | `XIAOMI_MIMO_PAYG_API_KEY` | `GET /v1/models` (`api-key`; Bearer on 401) | OpenAI: `api.xiaomimimo.com/v1` · Anthropic: `api.xiaomimimo.com/anthropic` | `xiaomi_mimo_payg`; chat via `MiMoClient` |
 | **Xiaomi (MiMo) Token Plan** | `XIAOMI_MIMO_TOKEN_PLAN_API_KEY` | `GET /v1/models` (region host) | OpenAI + Anthropic per region (`token-plan-{cn,sgp,ams}.xiaomimimo.com`) | `xiaomi_mimo_token_plan` + `xiaomi_mimo_token_plan_region` in provider.json |
+| **MiniMax (minimax) Token Plan** | `MINIMAX_TOKEN_PLAN_API_KEY` | `GET /v1/models` | OpenAI-compat `/v1/models` | `https://api.minimax.io/v1` |
+| **MiniMax (minimax) Pay-as-you-go** | `MINIMAX_PAYG_API_KEY` | `GET /v1/models` | OpenAI-compat `/v1/models` | `https://api.minimax.io/v1` |
 | **Ollama** | `OLLAMA_BASE_URL` | `GET /api/tags` | `/api/tags` | Zero models = error; no remote fallback in picker |
 
 ### Model discovery (all setup providers)
@@ -326,7 +329,7 @@ DiscoverCatalog(ctx, opts)
 
 ## 8. Merge policy
 
-**Implemented:** `discover.MergeCatalogV1WithPolicy` replaces deployment offerings from live fetch, then **fully replaces** model rows for prefer-live providers (all 12 setup gateways). Offerings merge pricing, capabilities, and `live_metadata` from the live catalog.
+**Implemented:** `discover.MergeCatalogV1WithPolicy` replaces deployment offerings from live fetch, then **fully replaces** model rows for prefer-live providers (all 15 setup gateways). Offerings merge pricing, capabilities, and `live_metadata` from the live catalog.
 
 Remote catalog JSON still supplies deployments, protocols, and bootstrap metadata — not picker model IDs for setup gateways.