Skip to content

Commit ca64bb8

Browse files
authored
refactor: replace emoji status glyphs with ASCII tokens (#37)
Eyrie returns user-facing strings that hawk pipes straight to the terminal (FormatPreflightReport, Report.Markdown) or to a markdown viewer (GetModelDeprecationWarning). These three functions previously embedded "✓", "✗", and "⚠" (U+2713 / U+2717 / U+26A0) — all in the dingbats / symbol block, which the hawk audit test (added in the parallel hawk commit) classifies as emoji. Replacing them with ASCII tokens ("+", "x", "[warn]") makes the output terminal-portable and keeps the no-emoji rule consistent across both repos. Existing tests continue to pass: - runtime/preflight_test.go's "warn icon" case asserts the substring "!", which the warn branch still emits. - verify/verify_test.go's TestReport_Markdown asserts on the table header / detail columns, not the status cell. - catalog/deprecation_test.go asserts on the "will be retired on" substring. The change is contained to three call sites; the data shape of PreflightCheck, Report, and DeprecationEntry is untouched.
1 parent f3abc3b commit ca64bb8

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

catalog/deprecation.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func GetModelDeprecationWarning(modelID, provider string) string {
3535
if !strings.Contains(canonical, key) || !ok || date == "" {
3636
continue
3737
}
38-
return fmt.Sprintf(" %s will be retired on %s. Consider switching to a newer model.", entry.ModelName, date)
38+
return fmt.Sprintf("[warn] %s will be retired on %s. Consider switching to a newer model.", entry.ModelName, date)
3939
}
4040
return ""
4141
}

runtime/preflight.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,12 @@ func FormatPreflightReport(r PreflightReport) string {
159159
b.WriteString("Preflight: setup incomplete\n")
160160
}
161161
for _, c := range r.Checks {
162-
icon := ""
162+
icon := "+"
163163
switch c.Status {
164164
case PreflightWarn:
165165
icon = "!"
166166
case PreflightFail:
167-
icon = ""
167+
icon = "x"
168168
}
169169
fmt.Fprintf(&b, " %s %s: %s\n", icon, c.Name, c.Detail)
170170
}

verify/verify.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,10 @@ func (r Report) Markdown() string {
194194
out += fmt.Sprintf("- tool_call_f1: %.2f\n\n", r.F1Score)
195195
out += "| case | result | latency | detail |\n|---|---|---|---|\n"
196196
for _, c := range r.Results {
197-
status := ""
197+
status := "+"
198198
detail := ""
199199
if !c.Passed {
200-
status = ""
200+
status = "x"
201201
detail = strings.Join(c.Failures, "; ")
202202
}
203203
out += fmt.Sprintf("| %s | %s | %s | %s |\n", c.ID, status, c.Latency.Round(time.Millisecond), detail)

0 commit comments

Comments
 (0)