-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathsight.go
More file actions
359 lines (311 loc) · 10.5 KB
/
Copy pathsight.go
File metadata and controls
359 lines (311 loc) · 10.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
package cmd
import (
"context"
"encoding/json"
"fmt"
"os"
"os/exec"
"strings"
"time"
"github.com/GrayCodeAI/eyrie/client"
sightLib "github.com/GrayCodeAI/sight"
hawkSight "github.com/GrayCodeAI/hawk/internal/bridge/sight"
hawkconfig "github.com/GrayCodeAI/hawk/internal/config"
"github.com/charmbracelet/lipgloss"
"github.com/spf13/cobra"
)
var (
sightBase string
sightPR int
sightConcerns string
sightModel string
sightFailOn string
sightFormat string
sightReflection bool
sightMode string // "review", "describe", "improve"
sightTimeout time.Duration
)
var sightCmd = &cobra.Command{
Use: "sight",
Short: "AI-powered code review on the current branch diff",
Long: `sight reviews code changes using an LLM, detecting security issues,
bugs, performance problems, and style concerns.
By default it reviews the diff between main and HEAD. Use --base to change
the comparison branch, or --mode to switch between review, describe, and improve.
Examples:
hawk sight
hawk sight --base develop
hawk sight --mode describe
hawk sight --mode improve --model claude-sonnet-4-20250514
hawk sight --concerns security,bugs --fail-on high --format json`,
RunE: func(cmd *cobra.Command, args []string) error {
hawkconfig.PrepareCredentialDiscovery(context.Background())
diff, err := getDiff()
if err != nil {
return fmt.Errorf("failed to get diff: %w", err)
}
if strings.TrimSpace(diff) == "" {
cmd.Println("No changes found.")
return nil
}
// Build eyrie client using hawk's configured provider
prov := provider
if prov == "" {
prov = client.DetectProvider()
}
eyrieClient := client.Client(&client.EyrieConfig{Provider: prov})
var sightOpts []sightLib.Option
if sightModel != "" {
sightOpts = append(sightOpts, sightLib.WithModel(sightModel))
}
if sightConcerns != "" {
concerns := strings.Split(sightConcerns, ",")
for i := range concerns {
concerns[i] = strings.TrimSpace(concerns[i])
}
sightOpts = append(sightOpts, sightLib.WithConcerns(concerns...))
}
if sightFailOn != "" {
sightOpts = append(sightOpts, sightLib.WithFailOn(sightLib.ParseSeverity(sightFailOn)))
}
if sightReflection {
sightOpts = append(sightOpts, sightLib.WithReflection(true))
}
bridge := hawkSight.NewBridge(eyrieClient, prov, sightOpts...)
if !bridge.Ready() {
return fmt.Errorf("sight bridge failed to initialize")
}
ctx := context.Background()
if sightTimeout > 0 {
var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(ctx, sightTimeout)
defer cancel()
}
mode := sightMode
if mode == "" {
mode = "review"
}
switch mode {
case "review":
return runSightReview(ctx, bridge, diff)
case "describe":
return runSightDescribe(ctx, bridge, diff)
case "improve":
return runSightImprove(ctx, bridge, diff)
default:
return fmt.Errorf("unknown mode %q; use review, describe, or improve", mode)
}
},
}
func init() {
sightCmd.Flags().StringVar(&sightBase, "base", "main", "base branch for diff comparison")
sightCmd.Flags().IntVar(&sightPR, "pr", 0, "pull request number (uses GitHub API to get diff)")
sightCmd.Flags().StringVar(&sightConcerns, "concerns", "", "comma-separated concerns (security,bugs,performance,correctness,style)")
sightCmd.Flags().StringVar(&sightModel, "model", "", "LLM model to use for review")
sightCmd.Flags().StringVar(&sightFailOn, "fail-on", "critical", "minimum severity to cause exit code 1 (info,low,medium,high,critical)")
sightCmd.Flags().StringVar(&sightFormat, "format", "terminal", "output format: terminal, json")
sightCmd.Flags().BoolVar(&sightReflection, "reflection", false, "enable self-reflection pass to validate findings")
sightCmd.Flags().StringVar(&sightMode, "mode", "review", "operation mode: review, describe, improve")
sightCmd.Flags().DurationVar(&sightTimeout, "timeout", 2*time.Minute, "timeout for the LLM review operation (e.g. 30s, 2m)")
}
// getDiff obtains the diff to review, either from a PR number or git diff.
func getDiff() (string, error) {
if sightPR > 0 {
// Use gh CLI to fetch the PR diff
out, err := exec.CommandContext(context.Background(), "gh", "pr", "diff", fmt.Sprintf("%d", sightPR)).Output()
if err != nil {
return "", fmt.Errorf("gh pr diff failed: %w", err)
}
return string(out), nil
}
base := sightBase
if base == "" {
base = "main"
}
out, err := exec.CommandContext(context.Background(), "git", "diff", base+"...HEAD").Output()
if err != nil {
// Fallback to two-dot syntax
out, err = exec.CommandContext(context.Background(), "git", "diff", base, "HEAD").Output()
if err != nil {
return "", fmt.Errorf("git diff %s...HEAD failed: %w", base, err)
}
}
return string(out), nil
}
func runSightReview(ctx context.Context, bridge *hawkSight.Bridge, diff string) error {
result, err := bridge.Review(ctx, diff)
if err != nil {
return fmt.Errorf("sight review failed: %w", err)
}
switch sightFormat {
case "json":
enc := json.NewEncoder(os.Stdout)
enc.SetIndent("", " ")
if err := enc.Encode(result); err != nil {
return err
}
default:
fmt.Print(formatSightTerminal(result))
}
if result.Failed() {
return fmt.Errorf("sight: one or more checks failed")
}
return nil
}
func runSightDescribe(ctx context.Context, bridge *hawkSight.Bridge, diff string) error {
desc, err := bridge.Describe(ctx, diff)
if err != nil {
return fmt.Errorf("sight describe failed: %w", err)
}
switch sightFormat {
case "json":
enc := json.NewEncoder(os.Stdout)
enc.SetIndent("", " ")
if err := enc.Encode(desc); err != nil {
return err
}
default:
fmt.Print(formatDescriptionTerminal(desc))
}
return nil
}
func runSightImprove(ctx context.Context, bridge *hawkSight.Bridge, diff string) error {
result, err := bridge.Improve(ctx, diff)
if err != nil {
return fmt.Errorf("sight improve failed: %w", err)
}
switch sightFormat {
case "json":
enc := json.NewEncoder(os.Stdout)
enc.SetIndent("", " ")
if err := enc.Encode(result); err != nil {
return err
}
default:
fmt.Print(formatImprovementsTerminal(result))
}
return nil
}
// formatSightTerminal renders review results using lipgloss styles.
func formatSightTerminal(result *sightLib.Result) string {
var b strings.Builder
titleStyle := lipgloss.NewStyle().Bold(true).Foreground(lipgloss.Color("12"))
critStyle := lipgloss.NewStyle().Bold(true).Foreground(lipgloss.Color("9"))
highStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("9"))
medStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("11"))
lowStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("14"))
infoStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("8"))
dimStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("8"))
b.WriteString(titleStyle.Render("Sight Code Review"))
b.WriteString("\n")
b.WriteString(dimStyle.Render(fmt.Sprintf("Reviewed %d files, %d hunks", result.Stats.FilesReviewed, result.Stats.HunksAnalyzed)))
b.WriteString("\n\n")
if len(result.Findings) == 0 {
b.WriteString(lipgloss.NewStyle().Foreground(lipgloss.Color("10")).Render("No issues found."))
b.WriteString("\n")
return b.String()
}
for _, f := range result.Findings {
var sevLabel string
switch f.Severity {
case sightLib.SeverityCritical:
sevLabel = critStyle.Render("CRITICAL")
case sightLib.SeverityHigh:
sevLabel = highStyle.Render("HIGH")
case sightLib.SeverityMedium:
sevLabel = medStyle.Render("MEDIUM")
case sightLib.SeverityLow:
sevLabel = lowStyle.Render("LOW")
default:
sevLabel = infoStyle.Render("INFO")
}
loc := f.File
if f.Line > 0 {
loc = fmt.Sprintf("%s:%d", f.File, f.Line)
}
b.WriteString(fmt.Sprintf(" [%s] [%s] %s\n", sevLabel, f.Concern, loc))
b.WriteString(fmt.Sprintf(" %s\n", f.Message))
if f.Fix != "" {
b.WriteString(dimStyle.Render(fmt.Sprintf(" Fix: %s", f.Fix)))
b.WriteString("\n")
}
b.WriteString("\n")
}
b.WriteString(dimStyle.Render("---"))
b.WriteString("\n")
b.WriteString(fmt.Sprintf("%d finding(s) total", result.Stats.FindingsTotal))
for sev, count := range result.Stats.BySeverity {
b.WriteString(fmt.Sprintf(" %s:%d", sev, count))
}
b.WriteString("\n")
if result.Failed() {
b.WriteString(critStyle.Render(fmt.Sprintf("FAILED (threshold: %s)", result.FailOn)))
b.WriteString("\n")
}
return b.String()
}
// formatDescriptionTerminal renders a PR description for the terminal.
func formatDescriptionTerminal(desc *sightLib.Description) string {
var b strings.Builder
titleStyle := lipgloss.NewStyle().Bold(true).Foreground(lipgloss.Color("12"))
dimStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("8"))
b.WriteString(titleStyle.Render(desc.Title))
b.WriteString("\n\n")
b.WriteString(desc.Summary)
b.WriteString("\n\n")
if len(desc.Changes) > 0 {
b.WriteString("Changes:\n")
for _, c := range desc.Changes {
b.WriteString(fmt.Sprintf(" - %s\n", c))
}
b.WriteString("\n")
}
if desc.ChangeType != "" {
b.WriteString(dimStyle.Render(fmt.Sprintf("Type: %s Risk: %s", desc.ChangeType, desc.Risk)))
b.WriteString("\n")
}
if desc.TestPlan != "" {
b.WriteString(dimStyle.Render(fmt.Sprintf("Test plan: %s", desc.TestPlan)))
b.WriteString("\n")
}
return b.String()
}
// formatImprovementsTerminal renders improvement suggestions for the terminal.
func formatImprovementsTerminal(result *sightLib.ImproveResult) string {
var b strings.Builder
titleStyle := lipgloss.NewStyle().Bold(true).Foreground(lipgloss.Color("12"))
dimStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("8"))
codeStyle := lipgloss.NewStyle().Foreground(lipgloss.Color("10"))
b.WriteString(titleStyle.Render("Sight Improvements"))
b.WriteString("\n\n")
if len(result.Improvements) == 0 {
b.WriteString("Code looks clean. No improvements suggested.\n")
return b.String()
}
for i, imp := range result.Improvements {
loc := imp.File
if imp.Line > 0 {
loc = fmt.Sprintf("%s:%d", imp.File, imp.Line)
}
b.WriteString(fmt.Sprintf("%d. [%s] %s\n", i+1, imp.Category, loc))
b.WriteString(fmt.Sprintf(" %s\n", imp.Description))
if imp.Before != "" {
b.WriteString(dimStyle.Render(" Before: "))
b.WriteString(imp.Before)
b.WriteString("\n")
}
if imp.After != "" {
b.WriteString(codeStyle.Render(" After: "))
b.WriteString(imp.After)
b.WriteString("\n")
}
if imp.Reasoning != "" {
b.WriteString(dimStyle.Render(fmt.Sprintf(" Why: %s", imp.Reasoning)))
b.WriteString("\n")
}
b.WriteString("\n")
}
b.WriteString(dimStyle.Render(fmt.Sprintf("%d improvement(s) suggested.", len(result.Improvements))))
b.WriteString("\n")
return b.String()
}