fix: resolve all lint issues (ineffassign, misspell nolint)

Author: Patel230

engine/budget_allocator.go

@@ -276,10 +276,6 @@ func (ba *BudgetAllocator) Rebalance() {
 
 		// Shrink to the midpoint between min and current, proportional to usage.
 		// If usage is 0.0, shrink to minimum. If usage is 0.4, shrink less.
-		targetUsage := alloc.Usage
-		if targetUsage < 0.1 {
-			targetUsage = 0.1
-		}
 		// Target size: what would make usage ~70% at the used amount.
 		usedTokens := int(float64(alloc.CurrentTokens) * alloc.Usage)
 		targetSize := int(float64(usedTokens) / 0.7)

engine/error_grouper_test.go

@@ -151,7 +151,7 @@ func TestFindGroup(t *testing.T) {
 	eg.Add("undefined variable foo", "main.go", 10, "")
 
 	// Find with same normalized pattern
-	found := eg.FindGroup("undefined variable bar")
+	_ = eg.FindGroup("undefined variable bar")
 	// These won't match because "foo" and "bar" are short words not quoted
 	// Let's use a case that will match
 	eg.Add(`cannot find "x" in scope`, "a.go", 1, "")

engine/git_provider.go

@@ -603,7 +603,7 @@ func parseGitConfig(content string) (string, string, string) {
 
 // parseRemoteURL extracts provider, owner, and repo from a git remote URL.
 func parseRemoteURL(url string) (string, string, string) {
-	provider := "github"
+	var provider string
 
 	// Normalize URL
 	url = strings.TrimSuffix(url, ".git")

eval/tasks_go.go

@@ -1040,7 +1040,7 @@ func Register(name, email string, age int, password string) error {
 				return err
 			}
 
-			test := `package main
+			_ = `package main
 
 import "testing"
 
@@ -1086,7 +1086,7 @@ func TestRegisterInvalidPassword(t *testing.T) {
 }
 `
 			// Need to add strings import to test
-			test = `package main
+			test := `package main
 
 import (
 	"strings"

permissions/osv_checker.go

@@ -62,7 +62,7 @@ func NewOSVChecker() *OSVChecker {
 		{Package: "crossenv", Ecosystem: "npm", Advisory: "MAL-2017-0001", Severity: "CRITICAL", Description: "typosquat of cross-env - credential stealer", DateAdded: time.Date(2017, 8, 1, 0, 0, 0, 0, time.UTC)},
 		{Package: "lodahs", Ecosystem: "npm", Advisory: "MAL-2019-0001", Severity: "HIGH", Description: "typosquat of lodash - data exfiltration", DateAdded: time.Date(2019, 6, 15, 0, 0, 0, 0, time.UTC)},
 		{Package: "lodashs", Ecosystem: "npm", Advisory: "MAL-2019-0002", Severity: "HIGH", Description: "typosquat of lodash - data exfiltration", DateAdded: time.Date(2019, 6, 15, 0, 0, 0, 0, time.UTC)},
-		{Package: "expresss", Ecosystem: "npm", Advisory: "MAL-2020-0001", Severity: "HIGH", Description: "typosquat of express - backdoor", DateAdded: time.Date(2020, 3, 10, 0, 0, 0, 0, time.UTC)},
+		{Package: "expresss", Ecosystem: "npm", Advisory: "MAL-2020-0001", Severity: "HIGH", Description: "typosquat of express - backdoor", DateAdded: time.Date(2020, 3, 10, 0, 0, 0, 0, time.UTC)}, //nolint:misspell
 		{Package: "babelcli", Ecosystem: "npm", Advisory: "MAL-2017-0002", Severity: "HIGH", Description: "typosquat of babel-cli - credential stealer", DateAdded: time.Date(2017, 8, 1, 0, 0, 0, 0, time.UTC)},
 		{Package: "mongose", Ecosystem: "npm", Advisory: "MAL-2017-0003", Severity: "HIGH", Description: "typosquat of mongoose - credential stealer", DateAdded: time.Date(2017, 8, 1, 0, 0, 0, 0, time.UTC)},
 		{Package: "d3.js", Ecosystem: "npm", Advisory: "MAL-2017-0004", Severity: "HIGH", Description: "typosquat of d3 - credential stealer", DateAdded: time.Date(2017, 8, 1, 0, 0, 0, 0, time.UTC)},
@@ -74,7 +74,7 @@ func NewOSVChecker() *OSVChecker {
 		{Package: "node-request", Ecosystem: "npm", Advisory: "MAL-2019-0004", Severity: "HIGH", Description: "typosquat of request - backdoor", DateAdded: time.Date(2019, 4, 5, 0, 0, 0, 0, time.UTC)},
 		{Package: "discordi.js", Ecosystem: "npm", Advisory: "MAL-2021-0010", Severity: "HIGH", Description: "typosquat of discord.js - token stealer", DateAdded: time.Date(2021, 9, 1, 0, 0, 0, 0, time.UTC)},
 		{Package: "discord.jss", Ecosystem: "npm", Advisory: "MAL-2021-0011", Severity: "HIGH", Description: "typosquat of discord.js - token stealer", DateAdded: time.Date(2021, 9, 1, 0, 0, 0, 0, time.UTC)},
-		{Package: "electorn", Ecosystem: "npm", Advisory: "MAL-2022-0020", Severity: "HIGH", Description: "typosquat of electron - backdoor", DateAdded: time.Date(2022, 4, 12, 0, 0, 0, 0, time.UTC)},
+		{Package: "electorn", Ecosystem: "npm", Advisory: "MAL-2022-0020", Severity: "HIGH", Description: "typosquat of electron - backdoor", DateAdded: time.Date(2022, 4, 12, 0, 0, 0, 0, time.UTC)}, //nolint:misspell
 		{Package: "axios-https", Ecosystem: "npm", Advisory: "MAL-2023-0001", Severity: "HIGH", Description: "typosquat of axios - data exfiltration", DateAdded: time.Date(2023, 1, 15, 0, 0, 0, 0, time.UTC)},
 		{Package: "react-dev-utils-cdn", Ecosystem: "npm", Advisory: "MAL-2023-0002", Severity: "HIGH", Description: "typosquat - credential stealer", DateAdded: time.Date(2023, 2, 10, 0, 0, 0, 0, time.UTC)},
 

session/checkpoint.go

@@ -289,7 +289,7 @@ func (cm *CheckpointManager) FormatCheckpoints() string {
 	now := time.Now()
 	for i, cp := range cm.Checkpoints {
 		age := formatAge(now.Sub(cp.Timestamp))
-		name := cp.Name
+		var name string
 		if cp.Auto {
 			name = "auto-checkpoint"
 		} else {