Commit 3bf56fc
authored
fix: resolve all outstanding code quality issues (#54)
* fix: resolve all outstanding issues across hawk + eyrie
hawk:
- C4: SQLite context.Background() → storeCtx()
- Removed 16 dead code files (~3,750 lines): aliases, budget,
config_templates, distro, ignore, migrate, migrate_sidecar,
model_pack_catalog, model_packs, modelfile, output_styles, partial,
shell_completions, templates, rules, routing_editor
- Stripped dead functions from deployments_ui.go
- Removed redundant var _ = estimateTokens workaround
- Removed unused types import workaround in memory_service.go
eyrie:
- C4: silenced resp.Body.Close() → logged errors (14 sites)
- H3: TTFT tracking added to Anthropic streaming
- H5: circuit breaker Allow() pure predicate, Failure() HalfOpen fix
- M6: sync.Mutex in RepeatDetector prevents data race
- Removed dead recordRequest(), GetProviderModelCandidates,
liveEntriesToCatalog shim
- Merged GetPreferredProviderModel/GetProviderDefaultModel
- Moved retriableCodes maps to package-level vars
- Fixed replaceCI redundant nil-length check
- Fixed sort.SliceStable race in shrink (moved to init())
- Updated all callers and tests
* fix: address PR review comments
- sqlite_store.go: revert ctx/storeCtx dead code (always nil)
- daemon.go: constantTimeEqual uses subtle.ConstantTimeCompare + len check1 parent 1b57cec commit 3bf56fc
41 files changed
Lines changed: 45 additions & 7859 deletions
File tree
- cmd
- internal
- config
- daemon
- engine
- search
- session
- tool
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| 100 | + | |
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments