Skip to content

Commit 3bf56fc

Browse files
authored
fix: resolve all outstanding code quality issues (#54)
* fix: resolve all outstanding issues across hawk + eyrie hawk: - C4: SQLite context.Background() → storeCtx() - Removed 16 dead code files (~3,750 lines): aliases, budget, config_templates, distro, ignore, migrate, migrate_sidecar, model_pack_catalog, model_packs, modelfile, output_styles, partial, shell_completions, templates, rules, routing_editor - Stripped dead functions from deployments_ui.go - Removed redundant var _ = estimateTokens workaround - Removed unused types import workaround in memory_service.go eyrie: - C4: silenced resp.Body.Close() → logged errors (14 sites) - H3: TTFT tracking added to Anthropic streaming - H5: circuit breaker Allow() pure predicate, Failure() HalfOpen fix - M6: sync.Mutex in RepeatDetector prevents data race - Removed dead recordRequest(), GetProviderModelCandidates, liveEntriesToCatalog shim - Merged GetPreferredProviderModel/GetProviderDefaultModel - Moved retriableCodes maps to package-level vars - Fixed replaceCI redundant nil-length check - Fixed sort.SliceStable race in shrink (moved to init()) - Updated all callers and tests * fix: address PR review comments - sqlite_store.go: revert ctx/storeCtx dead code (always nil) - daemon.go: constantTimeEqual uses subtle.ConstantTimeCompare + len check
1 parent 1b57cec commit 3bf56fc

41 files changed

Lines changed: 45 additions & 7859 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

cmd/daemon.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ func runDaemonStart(_ *cobra.Command, _ []string) error {
9797
return sess, nil
9898
}
9999

100+
daemon.SetVersion(version)
100101
srv := daemon.New(daemon.Config{Port: daemonPort, Host: daemonHost, APIKey: apiKey}, factory)
101102

102103
// Wire a lightweight provider-connectivity readiness probe. The default

internal/config/aliases.go

Lines changed: 0 additions & 81 deletions
This file was deleted.

internal/config/aliases_test.go

Lines changed: 0 additions & 104 deletions
This file was deleted.

internal/config/budget.go

Lines changed: 0 additions & 91 deletions
This file was deleted.

0 commit comments

Comments
 (0)