fix: resolve lint errors, update Go to 1.26.3, and fix golangci-lint v2 config

Author: Patel230

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  GO_VERSION: "1.26.1"
+  GO_VERSION: "1.26.3"
 
 jobs:
   # -------------------------------------------------------------------------

.golangci.yml

@@ -14,41 +14,42 @@ linters:
     - bodyclose
     - unconvert
     - whitespace
-
-linters-settings:
-  errcheck:
-    check-type-assertions: true
-    check-blank: false
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - performance
-    disabled-checks:
-      - hugeParam
-      - rangeValCopy
-      - appendAssign
-  staticcheck:
-    checks:
-      - all
-      - -SA1019
+  settings:
+    errcheck:
+      check-type-assertions: true
+      check-blank: false
+    govet:
+      enable-all: true
+      disable:
+        - fieldalignment
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - performance
+      disabled-checks:
+        - hugeParam
+        - rangeValCopy
+        - appendAssign
+    staticcheck:
+      checks:
+        - all
+        - -SA1019
+  exclusions:
+    paths:
+      - .gomodcache
+      - vendor
+    rules:
+      - path: _test\.go
+        linters:
+          - gocritic
+          - noctx
+          - bodyclose
+          - errcheck
+          - unused
+      - path: cmd/
+        linters:
+          - noctx
 
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
-  exclude-dirs:
-    - .gomodcache
-    - vendor
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - gocritic
-        - noctx
-        - bodyclose
-        - errcheck
-    - path: cmd/
-      linters:
-        - noctx

auth/device_flow.go

@@ -72,7 +72,7 @@ func (df *DeviceFlow) RequestCode(ctx context.Context) (*DeviceCodeResponse, err
 	if err != nil {
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode != http.StatusOK {
 		return nil, fmt.Errorf("device auth request failed: HTTP %d", resp.StatusCode)
@@ -132,7 +132,7 @@ func (df *DeviceFlow) exchangeCode(ctx context.Context, deviceCode string) (*Tok
 	if err != nil {
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	var raw map[string]interface{}
 	if err := json.NewDecoder(resp.Body).Decode(&raw); err != nil {
@@ -145,6 +145,8 @@ func (df *DeviceFlow) exchangeCode(ctx context.Context, deviceCode string) (*Tok
 
 	jsonData, _ := json.Marshal(raw)
 	var token TokenResponse
-	json.Unmarshal(jsonData, &token)
+	if err := json.Unmarshal(jsonData, &token); err != nil {
+		return nil, err
+	}
 	return &token, nil
 }

cmd/chat_stream.go

@@ -56,31 +56,6 @@ func (m *chatModel) startStream() {
 	}()
 }
 
-// renderGlimmerVerb renders the spinner verb with a sweeping 3-color wave
-func renderGlimmerVerb(verb string, glimmerPos int) string {
-	if len(verb) == 0 {
-		return ""
-	}
-	// 3 colors: vivid orange, bright orange, warm amber
-	colors := []string{"255;94;14", "255;140;50", "255;180;80"}
-	runes := []rune(verb)
-
-	var b strings.Builder
-	for i, r := range runes {
-		// Wave: each char picks a color based on position + time, cycling 1→2→3→2→1→2→3...
-		dist := abs((i+glimmerPos)%5 - 2)
-		if dist == 0 {
-			b.WriteString("\033[1;38;2;" + colors[0] + "m" + string(r))
-		} else if dist == 1 {
-			b.WriteString("\033[1;38;2;" + colors[1] + "m" + string(r))
-		} else {
-			b.WriteString("\033[1;38;2;" + colors[2] + "m" + string(r))
-		}
-	}
-	b.WriteString("\033[0m")
-	return b.String()
-}
-
 func abs(x int) int {
 	if x < 0 {
 		return -x

tool/agent.go

@@ -5,13 +5,8 @@ import (
 	"encoding/json"
 	"fmt"
 	"sync"
-	"time"
 )
 
-// backgroundCompletionTimeout is the maximum time to wait for background
-// sub-agents in a single background-completion cycle.
-const backgroundCompletionTimeout = 2 * time.Minute
-
 type AgentTool struct{}
 
 func (AgentTool) Name() string      { return "Agent" }

tool/web_search_brave.go

@@ -97,11 +97,7 @@ func (c *braveClient) search(ctx context.Context, query string, count int) ([]se
 		if len(results) >= count {
 			break
 		}
-		results = append(results, searchResult{
-			Title:       r.Title,
-			URL:         r.URL,
-			Description: r.Description,
-		})
+		results = append(results, searchResult(r))
 	}
 
 	return results, nil

trace/langfuse.go

@@ -81,7 +81,7 @@ func (c *LangfuseClient) Trace(ctx context.Context, ev TraceEvent) {
 	c.mu.Unlock()
 
 	if shouldFlush {
-		go c.Flush(ctx)
+		go func() { _ = c.Flush(ctx) }()
 	}
 }
 
@@ -113,7 +113,7 @@ func (c *LangfuseClient) Flush(ctx context.Context) error {
 	if err != nil {
 		return err
 	}
-	resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 	if resp.StatusCode >= 400 {
 		return fmt.Errorf("langfuse: HTTP %d", resp.StatusCode)
 	}

trace/session_trace.go

@@ -265,11 +265,12 @@ func (st *SessionTrace) FormatTree() string {
 // formatSpan recursively renders a span and its children into the builder.
 func formatSpan(b *strings.Builder, span *SessionSpan, prefix string, isLast bool, isRoot bool) {
 	// Write the connector.
-	if isRoot {
+	switch {
+	case isRoot:
 		// No connector for the root span.
-	} else if isLast {
+	case isLast:
 		b.WriteString(prefix + "└── ")
-	} else {
+	default:
 		b.WriteString(prefix + "├── ")
 	}
 
@@ -282,7 +283,7 @@ func formatSpan(b *strings.Builder, span *SessionSpan, prefix string, isLast boo
 			dur = time.Since(span.StartTime)
 		}
 	}
-	b.WriteString(fmt.Sprintf("%s [%s]", span.Name, formatDuration(dur)))
+	fmt.Fprintf(b, "%s [%s]", span.Name, formatDuration(dur))
 
 	// Write selected attributes inline.
 	attrParts := formatInlineAttrs(span)

update/update.go

@@ -1,6 +1,7 @@
 package update
 
 import (
+	"context"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -25,7 +26,7 @@ type ReleaseInfo struct {
 
 // Check checks for available updates.
 func Check(currentVersion string) (*ReleaseInfo, error) {
-	req, err := http.NewRequest("GET", updateURL, nil)
+	req, err := http.NewRequestWithContext(context.Background(), "GET", updateURL, nil)
 	if err != nil {
 		return nil, err
 	}