chore: add microservice architecture scaffolding#8
Closed
Patel230 wants to merge 8 commits into
Closed
Conversation
Add .env.example, api/openapi.yaml, deploy/docker/docker-compose.yml, docs/architecture.md, and .github/workflows/docker.yml for GHCI build+push CI.
Fix errcheck on rows.Close(), simplify bool comparison, remove unused knownFields var, fix empty badge links, and run go work sync to update module consistency.
hawk's go.work references external/ symlinks to sibling repos that don't exist in the Docker build context.
Add //go:build !windows constraint to safewrite.go (uses unix syscalls), create safewrite_windows.go with portable fallback, skip tests on Windows, and run go mod download to add missing go.sum entry for golang.org/x/tools.
The Windows stub needed formatting. Also add the /go.mod hash for golang.org/x/tools v0.45.0 that was missing from go.sum, causing the Docker build to fail.
hawk depends on eyrie packages (credentials, runtime, setup, catalog/registry) that aren't in the published v0.5.0. Clone eyrie into the builder and add a replace directive.
The replace directive needs go mod tidy (not just download) to resolve all transitive dependencies from the local eyrie clone. Use -mod=mod to allow go.mod changes during build.
COPY . . was overwriting go.mod that had the replace directive. Move the replace + go mod tidy to after the source copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary