fix: io.ReadAll errors, json.Marshal errors, bedrock host extraction, mcp marshal, openapi path params, context bounds

Author: Patel230

azure.go

@@ -201,7 +201,7 @@ func (p *AzureOpenAIProvider) Stream(ctx context.Context, config StreamConfig, m
 	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
-		respBody, _ := io.ReadAll(resp.Body)
+		respBody, _ := io.ReadAll(resp.Body) // best-effort for error message
 		return Message{}, fmt.Errorf("Azure OpenAI error (%d): %s", resp.StatusCode, string(respBody))
 	}
 

bedrock.go

@@ -235,7 +235,8 @@ func (p *BedrockProvider) signRequest(req *http.Request, payload string) {
 
 	host := req.Host
 	if host == "" {
-		host = strings.Split(strings.Split(req.URL.Host, ":")[0], ".")[0]
+		// Strip port if present, use full hostname (not just first segment).
+		host = req.URL.Hostname()
 	}
 
 	hashedPayload := fmt.Sprintf("%x", sha256.Sum256([]byte(payload)))

context.go

@@ -310,10 +310,12 @@ func CompactMessagesTiered(messages []Message, cfg ContextConfig) []Message {
 			var summary string
 			if len(calls) > 0 {
 				summary = fmt.Sprintf("[Assistant used %d tool(s)]", len(calls))
-			} else if len(msg.Content) > 200 {
-				summary = msg.Content[:200]
 			} else {
-				summary = msg.Content
+				if len(msg.Content) > 200 {
+					summary = msg.Content[:200]
+				} else {
+					summary = msg.Content
+				}
 			}
 			compacted = append(compacted, Message{Role: "assistant", Content: summary})
 			// Skip adjacent tool result messages.

mcp/helpers.go

@@ -41,21 +41,24 @@ func ConnectHTTP(ctx context.Context, url string, headers map[string]string) (*M
 
 // initialize performs the MCP initialize handshake.
 func (c *McpClient) initialize(ctx context.Context) error {
-	params, _ := json.Marshal(map[string]interface{}{
+	params, err := json.Marshal(map[string]interface{}{
 		"protocolVersion": "2024-11-05",
 		"capabilities":    map[string]interface{}{},
 		"clientInfo": map[string]interface{}{
 			"name":    "iteragent",
 			"version": "0.1.0",
 		},
 	})
+	if err != nil {
+		return fmt.Errorf("marshal initialize params: %w", err)
+	}
 	req := JsonRpcRequest{
 		JSONRPC: "2.0",
 		Method:  "initialize",
 		Params:  params,
 	}
-	_, err := c.Transport.Send(ctx, req)
-	return err
+	_, sendErr := c.Transport.Send(ctx, req)
+	return sendErr
 }
 
 // ListTools returns the list of tools advertised by the MCP server.
@@ -82,10 +85,13 @@ func (c *McpClient) ListTools(ctx context.Context) ([]Tool, error) {
 
 // CallTool invokes a tool by name with the given arguments.
 func (c *McpClient) CallTool(ctx context.Context, name string, args map[string]interface{}) (*CallToolResult, error) {
-	paramsRaw, _ := json.Marshal(map[string]interface{}{
+	paramsRaw, err := json.Marshal(map[string]interface{}{
 		"name":      name,
 		"arguments": args,
 	})
+	if err != nil {
+		return nil, fmt.Errorf("marshal call params: %w", err)
+	}
 	req := JsonRpcRequest{
 		JSONRPC: "2.0",
 		Method:  "tools/call",

openapi/adapter.go

@@ -371,7 +371,8 @@ func (a *Adapter) callOperation(ctx context.Context, path, method string, op *Op
 		case "query":
 			queryParams = append(queryParams, fmt.Sprintf("%s=%s", url.QueryEscape(param.Name), url.QueryEscape(val)))
 		case "path":
-			u = strings.ReplaceAll(u, "{"+param.Name+"}", val)
+			// Use exact token replacement to avoid partial matches (e.g. {id} vs {id_extra}).
+			u = strings.ReplaceAll(u, "{"+param.Name+"}", url.PathEscape(val))
 		}
 	}
 
@@ -381,7 +382,10 @@ func (a *Adapter) callOperation(ctx context.Context, path, method string, op *Op
 
 	var bodyReader io.Reader
 	if op.RequestBody != nil {
-		bodyData, _ := json.Marshal(args)
+		bodyData, err := json.Marshal(args)
+		if err != nil {
+			return "", fmt.Errorf("marshal request body: %w", err)
+		}
 		bodyReader = strings.NewReader(string(bodyData))
 	} else {
 		bodyReader = strings.NewReader("")

vertex.go

@@ -131,7 +131,10 @@ func (p *VertexProvider) Complete(ctx context.Context, messages []Message, opts
 	}
 	defer resp.Body.Close()
 
-	respBody, _ := io.ReadAll(resp.Body)
+	respBody, err := io.ReadAll(resp.Body)
+	if err != nil {
+		return "", fmt.Errorf("read response body: %w", err)
+	}
 
 	if resp.StatusCode != http.StatusOK {
 		return "", fmt.Errorf("Vertex AI error (%d): %s", resp.StatusCode, string(respBody))