test message

Author: Patel230

internal/agent/pool.go

@@ -177,7 +177,10 @@ func (p *Pool) Close() {
 	p.rateLimiter.Stop()
 	p.mu.Lock()
 	for _, agent := range p.agents {
-		_ = agent.Close() // best-effort cleanup
+		func() {
+			defer func() { recover() }() // prevent one agent panic from skipping cleanup of others
+			_ = agent.Close()
+		}()
 	}
 	p.agents = nil
 	p.mu.Unlock()

internal/evolution/engine.go

@@ -180,6 +180,8 @@ func (e *Engine) clearSessionPlan() {
 	path := filepath.Join(e.repoPath, "SESSION_PLAN.md")
 	if err := os.Remove(path); err == nil {
 		e.logger.Info("cleared SESSION_PLAN.md after successful merge")
+	} else if !os.IsNotExist(err) {
+		e.logger.Warn("failed to clear SESSION_PLAN.md", "err", err)
 	}
 }
 
@@ -240,7 +242,10 @@ func (e *Engine) Run(ctx context.Context, p iteragent.Provider, issues string) (
 		return result, runErr
 	}
 
-	hasChanges, _ := e.hasChanges(ctx)
+	hasChanges, changesErr := e.hasChanges(ctx)
+	if changesErr != nil {
+		e.logger.Warn("could not determine if changes exist, assuming no changes", "err", changesErr)
+	}
 	if !hasChanges {
 		e.logger.Info("no changes detected, skipping PR flow")
 		result.Status = "no_changes"
@@ -409,7 +414,10 @@ func (e *Engine) auditLog(eventType, tool, detail string) {
 		entry["detail"] = detail
 	}
 
-	data, _ := json.Marshal(entry)
+	data, err := json.Marshal(entry)
+	if err != nil {
+		return
+	}
 
 	e.auditMu.Lock()
 	defer e.auditMu.Unlock()

internal/evolution/memory.go

@@ -24,7 +24,11 @@ func (e *Engine) appendLearningJSONL(title, source, context, takeaway string) er
 	}
 
 	dayBytes, _ := os.ReadFile(filepath.Join(e.repoPath, "DAY_COUNT"))
-	day, _ := strconv.Atoi(strings.TrimSpace(string(dayBytes)))
+	dayStr := strings.TrimSpace(string(dayBytes))
+	day, err := strconv.Atoi(dayStr)
+	if err != nil && dayStr != "" {
+		e.logger.Warn("DAY_COUNT is not a valid integer, defaulting to 0", "value", dayStr)
+	}
 
 	entry := map[string]interface{}{
 		"type":     "lesson",
@@ -66,7 +70,11 @@ func (e *Engine) appendFailureJSONL(taskTitle, reason string) error {
 	}
 
 	dayBytes, _ := os.ReadFile(filepath.Join(e.repoPath, "DAY_COUNT"))
-	day, _ := strconv.Atoi(strings.TrimSpace(string(dayBytes)))
+	dayStr := strings.TrimSpace(string(dayBytes))
+	day, err := strconv.Atoi(dayStr)
+	if err != nil && dayStr != "" {
+		e.logger.Warn("DAY_COUNT is not a valid integer, defaulting to 0", "value", dayStr)
+	}
 
 	entry := map[string]interface{}{
 		"type":  "failure",
@@ -126,7 +134,12 @@ func trimFailuresJSONL(path string, maxAge time.Duration) {
 	if len(kept) == 0 {
 		return
 	}
-	_ = os.WriteFile(path, []byte(strings.Join(kept, "\n")+"\n"), 0o644)
+	// Write atomically: temp file then rename, so a crash mid-write can't corrupt the file.
+	tmp := path + ".tmp"
+	if err := os.WriteFile(tmp, []byte(strings.Join(kept, "\n")+"\n"), 0o644); err != nil {
+		return
+	}
+	_ = os.Rename(tmp, path)
 }
 
 // recentFailures reads memory/failures.jsonl and returns the last N entries

internal/evolution/parsing.go

@@ -32,10 +32,14 @@ func parseSessionPlanTasks(plan string) []planTask {
 			var num int
 			var title string
 			if idx := strings.IndexByte(rest, ':'); idx >= 0 {
-				fmt.Sscanf(rest[:idx], "%d", &num)
+				if n, _ := fmt.Sscanf(rest[:idx], "%d", &num); n == 0 {
+					num = len(tasks) + 1
+				}
 				title = strings.TrimSpace(rest[idx+1:])
 			} else {
-				fmt.Sscanf(rest, "%d", &num)
+				if n, _ := fmt.Sscanf(rest, "%d", &num); n == 0 {
+					num = len(tasks) + 1
+				}
 				title = rest
 			}
 			current = &planTask{Number: num, Title: title}
@@ -150,7 +154,7 @@ func parseIssueResponses(plan string) []issueResponse {
 			rest := strings.TrimPrefix(line, "- #")
 			var num int
 			fmt.Sscanf(rest, "%d", &num)
-			if num == 0 {
+			if num <= 0 || num > 999999 {
 				continue
 			}
 			status := "comment"

internal/evolution/phases.go

@@ -337,7 +337,9 @@ func (e *Engine) executeTask(ctx context.Context, p iteragent.Provider, task pla
 		e.logger.Info("task succeeded on retry", "number", task.Number)
 	} else {
 		e.logger.Warn("task failed after retry, skipping", "number", task.Number)
-		_ = e.appendFailureJSONL(task.Title, firstLine(failReason))
+		if err := e.appendFailureJSONL(task.Title, firstLine(failReason)); err != nil {
+			e.logger.Warn("failed to record task failure", "task", task.Title, "err", err)
+		}
 	}
 }
 
@@ -386,7 +388,9 @@ func (e *Engine) runTaskAttempt(ctx context.Context, p iteragent.Provider, task
 		return false, errCtx
 	}
 
-	_ = e.appendLearningJSONL(firstLine(extractCommitMessage(taskOutput)), "evolution", task.Description, "")
+	if err := e.appendLearningJSONL(firstLine(extractCommitMessage(taskOutput)), "evolution", task.Description, ""); err != nil {
+		e.logger.Warn("failed to record task learning", "task", task.Title, "err", err)
+	}
 	return true, ""
 }
 

internal/evolution/phases_communicate.go

@@ -128,15 +128,20 @@ func (e *Engine) persistJournalEntry(journalEntry string, day string) {
 
 	journalPath := filepath.Join(e.repoPath, "docs/JOURNAL.md")
 	_ = os.MkdirAll(filepath.Dir(journalPath), 0o755)
-	journal, _ := os.ReadFile(journalPath)
+	journal, err := os.ReadFile(journalPath)
+	if err != nil && !os.IsNotExist(err) {
+		e.logger.Warn("failed to read JOURNAL.md, will overwrite", "err", err)
+	}
 
 	header := "# iterate Evolution Journal\n"
 	if !strings.HasPrefix(string(journal), header) {
 		journal = []byte(header)
 	}
 	rest := strings.TrimPrefix(strings.TrimPrefix(string(journal), header), "\n")
 	newContent := header + "\n" + extracted + "\n\n" + rest
-	_ = os.WriteFile(journalPath, []byte(newContent), 0o644)
+	if err := os.WriteFile(journalPath, []byte(newContent), 0o644); err != nil {
+		e.logger.Warn("failed to write JOURNAL.md", "err", err)
+	}
 }
 
 // issueAlreadyCommented checks if the bot already commented on an issue today.
@@ -154,17 +159,24 @@ func (e *Engine) issueAlreadyCommented(ctx context.Context, issueNum int, day st
 
 // postIssueComments posts GitHub comments for addressed issues.
 func (e *Engine) postIssueComments(ctx context.Context, p iteragent.Provider, tools []iteragent.Tool, systemPrompt string, skills *iteragent.SkillSet, plan string) {
+	day := e.readDayCount()
 	responses := parseIssueResponses(plan)
 	for _, resp := range responses {
+		if e.issueAlreadyCommented(ctx, resp.IssueNum, day) {
+			e.logger.Info("skipping already-commented issue", "issue", resp.IssueNum, "day", day)
+			continue
+		}
 		body := fmt.Sprintf("Status: %s\nReason: %s", resp.Status, resp.Reason)
 		userMsg := fmt.Sprintf(`Post a GitHub issue comment on issue #%d. Be brief. Sign off with your day count.
 
 Body: %s
 
 Use: gh issue comment %d --repo %s --body "..."`, resp.IssueNum, body, resp.IssueNum, e.repo)
+		issueCtx, issueCancel := context.WithTimeout(ctx, 90*time.Second)
 		a := e.newAgent(p, tools, systemPrompt, skills)
-		e.forwardEvents(a.Prompt(ctx, userMsg))
+		e.forwardEvents(a.Prompt(issueCtx, userMsg))
 		a.Finish()
+		issueCancel()
 	}
 }
 

internal/social/engine.go

@@ -401,7 +401,12 @@ func trimSocialJSONL(path string) {
 	if len(kept) == 0 {
 		return
 	}
-	_ = os.WriteFile(path, []byte(strings.Join(kept, "\n")+"\n"), 0o644)
+	// Write atomically: temp file then rename to avoid partial writes on crash.
+	tmp := path + ".tmp"
+	if err := os.WriteFile(tmp, []byte(strings.Join(kept, "\n")+"\n"), 0o644); err != nil {
+		return
+	}
+	_ = os.Rename(tmp, path)
 }
 
 // --- GitHub REST API calls ---

scripts/build/generate_stats.py

@@ -7,6 +7,7 @@
 """
 
 import json
+import os
 import subprocess
 import sys
 from datetime import datetime, timedelta, timezone
@@ -135,6 +136,7 @@ def main():
     # Generate stats
     stats = generate_stats(repo_path)
     stats_file = f"{repo_path}/docs/stats.json"
+    os.makedirs(os.path.dirname(stats_file), exist_ok=True)
     with open(stats_file, "w") as f:
         json.dump(stats, f, indent=2)
     print(f"Stats written to {stats_file}")
@@ -143,6 +145,7 @@ def main():
     # Generate weekly summary
     summary = generate_weekly_summary(repo_path)
     summary_file = f"{repo_path}/memory/weekly_summary.md"
+    os.makedirs(os.path.dirname(summary_file), exist_ok=True)
     with open(summary_file, "w") as f:
         f.write(summary)
     print(f"\nSummary written to {summary_file}")

scripts/build/track_coverage.py

@@ -99,7 +99,9 @@ def main():
     print(json.dumps(entry))
 
     # Append to history
+    import os
     history_file = f"{repo_path}/memory/coverage_history.jsonl"
+    os.makedirs(os.path.dirname(history_file), exist_ok=True)
     with open(history_file, "a") as f:
         f.write(json.dumps(entry) + "\n")