fix: capture streaming output in all evolution phases

Fixed critical bug where phases only captured output from EventMessageEnd,
but the API streams content through EventMessageUpdate events.

Changes:
- reviewPR: Now accumulates content from EventMessageUpdate streaming
- RunPlanPhase: Captures streaming output for plan extraction
- runTaskAttempt: Accumulates task output from streaming events
- RunCommunicatePhase: Captures journal entry from streaming

This fixes the empty review comments and plan generation failures.
All phases now properly handle streaming API responses.

Author: Patel230

internal/evolution/git.go

@@ -212,50 +212,66 @@ func (e *Engine) reviewPR(ctx context.Context, p iteragent.Provider, tools []ite
 	}
 
 	a := e.newAgent(p, tools, systemPrompt, skills)
-	var reviewOutput string
+	var reviewBuilder strings.Builder
+	var finalContent string
 	for ev := range a.Prompt(ctx, userMsg) {
 		if e.eventSink != nil {
 			select {
 			case e.eventSink <- ev:
 			default:
 			}
 		}
+		// Accumulate content from streaming updates
+		if ev.Type == string(iteragent.EventMessageUpdate) {
+			reviewBuilder.WriteString(ev.Content)
+		}
 		if ev.Type == string(iteragent.EventMessageEnd) {
-			reviewOutput = ev.Content
+			finalContent = ev.Content
 		}
 	}
 	a.Finish()
 
-	low := strings.ToLower(reviewOutput)
-	passed := strings.Contains(low, "lgtm") || strings.Contains(low, "looks good")
+	// Use accumulated content or final content, whichever is longer
+	reviewText := reviewBuilder.String()
+	if len(finalContent) > len(reviewText) {
+		reviewText = finalContent
+	}
+
+	// Fallback if still empty
+	if strings.TrimSpace(reviewText) == "" {
+		reviewText = "Review completed but no output was generated. Please check the code manually."
+	}
+
+	low := strings.ToLower(reviewText)
+	passed := strings.Contains(low, "lgtm") || strings.Contains(low, "looks good") || strings.Contains(low, "approved")
 
 	if passed {
 		// Only post comment for final successful review
-		e.postReviewComment(ctx, reviewOutput, true)
+		e.postReviewComment(ctx, reviewText, true)
 		e.logger.Info("PR self-review passed")
 		return nil
 	}
 
 	// Reviewer found issues — try to auto-fix them (only on first review)
 	if len(isReReview) > 0 && isReReview[0] {
 		// Already tried auto-fix, still failed
-		e.postReviewComment(ctx, reviewOutput, false)
+		e.postReviewComment(ctx, reviewText, false)
 		return fmt.Errorf("review blocked merge: issues remain after auto-fix")
 	}
 
 	e.logger.Warn("PR self-review found issues — attempting auto-fix")
 
-	fixed, fixErr := e.autoFixIssues(ctx, p, tools, systemPrompt, skills, reviewOutput)
+	fixed, fixErr := e.autoFixIssues(ctx, p, tools, systemPrompt, skills, reviewText)
 	if fixErr != nil {
 		e.logger.Error("auto-fix failed", "err", fixErr)
 		// Post the original review + auto-fix failure
-		e.postReviewComment(ctx, reviewOutput+"\n\n---\n**Auto-fix failed:** "+fixErr.Error(), false)
+		e.postReviewComment(ctx, reviewText+"\n\n---\n**Auto-fix failed:** "+fixErr.Error(), false)
 		return fmt.Errorf("review blocked merge: %w", fixErr)
 	}
 
 	if !fixed {
 		e.logger.Warn("auto-fix could not resolve all issues — blocking merge")
-		e.postReviewComment(ctx, reviewOutput+"\n\n---\n**Auto-fix:** Could not resolve all issues automatically.", false)
+		e.postReviewComment(ctx, reviewText+"\n\n---\n**Auto-fix:** Could not resolve all issues automatically.", false)
 		return fmt.Errorf("review blocked merge: auto-fix could not resolve all issues")
 	}
 

internal/evolution/phases.go

@@ -26,14 +26,24 @@ func (e *Engine) RunPlanPhase(ctx context.Context, p iteragent.Provider, issues
 	systemPrompt := buildSystemPrompt(e.repoPath, string(identity))
 	a := e.newAgent(p, e.tools, systemPrompt, e.skills)
 
+	var contentBuilder strings.Builder
 	var lastContent string
 	for ev := range a.Prompt(ctx, userMessage) {
+		if ev.Type == string(iteragent.EventMessageUpdate) {
+			contentBuilder.WriteString(ev.Content)
+		}
 		if ev.Type == string(iteragent.EventMessageEnd) {
 			lastContent = ev.Content
 		}
 	}
 	a.Finish()
 
+	// Use accumulated content or final content, whichever is longer
+	accumulatedContent := contentBuilder.String()
+	if len(accumulatedContent) > len(lastContent) {
+		lastContent = accumulatedContent
+	}
+
 	// Extract plan from agent output if it didn't write the file via tool call.
 	planPath := filepath.Join(e.repoPath, "SESSION_PLAN.md")
 	if _, err := os.Stat(planPath); os.IsNotExist(err) && lastContent != "" {
@@ -353,9 +363,13 @@ func (e *Engine) runTaskAttempt(ctx context.Context, p iteragent.Provider, task
 	userMsg += "\n\nAfter implementing, run: go build ./... && go test ./...\nThen commit your changes using a conventional commit message (e.g. feat: ..., fix: ..., chore: ..., refactor: ..., test: ..., docs: ...)."
 
 	a := e.newAgent(p, tools, systemPrompt, skills)
+	var outputBuilder strings.Builder
 	var taskOutput string
 	var taskErr error
 	for ev := range a.Prompt(ctx, userMsg) {
+		if ev.Type == string(iteragent.EventMessageUpdate) {
+			outputBuilder.WriteString(ev.Content)
+		}
 		if ev.Type == string(iteragent.EventMessageEnd) {
 			taskOutput = ev.Content
 		}
@@ -365,6 +379,12 @@ func (e *Engine) runTaskAttempt(ctx context.Context, p iteragent.Provider, task
 	}
 	a.Finish()
 
+	// Use accumulated content or final content, whichever is longer
+	accumulatedOutput := outputBuilder.String()
+	if len(accumulatedOutput) > len(taskOutput) {
+		taskOutput = accumulatedOutput
+	}
+
 	if taskErr != nil {
 		e.logger.Warn("task error", "number", task.Number, "err", taskErr)
 		_ = e.revert(ctx)

internal/evolution/phases_communicate.go

@@ -83,14 +83,24 @@ Rules:
 - If nothing happened, write "Evolution session completed." as the body`, recentCommits, day, day)
 
 	a := e.newAgent(p, nil, minimalPrompt, nil)
+	var entryBuilder strings.Builder
 	var journalEntry string
 	for ev := range a.Prompt(journalCtx, journalMsg) {
+		if ev.Type == string(iteragent.EventMessageUpdate) {
+			entryBuilder.WriteString(ev.Content)
+		}
 		if ev.Type == string(iteragent.EventMessageEnd) {
 			journalEntry = strings.TrimSpace(ev.Content)
 		}
 	}
 	a.Finish()
 
+	// Use accumulated content or final content, whichever is longer
+	accumulatedEntry := strings.TrimSpace(entryBuilder.String())
+	if len(accumulatedEntry) > len(journalEntry) {
+		journalEntry = accumulatedEntry
+	}
+
 	e.persistJournalEntry(journalEntry, day)
 }