fix: TOML parser edge cases, git timeout, dead code removal

- config: handle values containing '=' and proper quote stripping
- incremental: use exec.CommandContext with 30s timeout for git diff
- filter: remove unused firstErr variable

Author: Patel230

config.go

@@ -91,7 +91,7 @@ func findConfigFile(dir string) string {
 }
 
 // parseTOMLConfig parses a simplified TOML format.
-// Supports key = "value", key = true/false, key = 123, and [section] headers.
+// Supports key = "value", key = true/false, key = 123, arrays, and [section] headers.
 func parseTOMLConfig(content string) (*FileConfig, error) {
 	cfg := &FileConfig{
 		Prompts: make(map[string]string),
@@ -109,13 +109,10 @@ func parseTOMLConfig(content string) (*FileConfig, error) {
 			continue
 		}
 
-		parts := strings.SplitN(line, "=", 2)
-		if len(parts) != 2 {
+		key, value, ok := parseTOMLKeyValue(line)
+		if !ok {
 			continue
 		}
-		key := strings.TrimSpace(parts[0])
-		value := strings.TrimSpace(parts[1])
-		value = strings.Trim(value, `"'`)
 
 		if section == "prompts" {
 			cfg.Prompts[key] = value
@@ -150,6 +147,25 @@ func parseTOMLConfig(content string) (*FileConfig, error) {
 	return cfg, nil
 }
 
+// parseTOMLKeyValue splits a TOML line into key and value, handling quoted values
+// that may contain '=' signs.
+func parseTOMLKeyValue(line string) (key, value string, ok bool) {
+	idx := strings.Index(line, "=")
+	if idx < 0 {
+		return "", "", false
+	}
+	key = strings.TrimSpace(line[:idx])
+	value = strings.TrimSpace(line[idx+1:])
+	// Strip matching outer quotes
+	if len(value) >= 2 {
+		if (value[0] == '"' && value[len(value)-1] == '"') ||
+			(value[0] == '\'' && value[len(value)-1] == '\'') {
+			value = value[1 : len(value)-1]
+		}
+	}
+	return key, value, key != ""
+}
+
 func parseTOMLArray(s string) []string {
 	s = strings.Trim(s, "[]")
 	parts := strings.Split(s, ",")

filter.go

@@ -56,7 +56,6 @@ func FilterFindings(ctx context.Context, provider Provider, findings []Finding,
 	sem := make(chan struct{}, config.MaxParallel)
 	var wg sync.WaitGroup
 	var mu sync.Mutex
-	var firstErr error
 
 	for i, finding := range toFilter {
 		wg.Add(1)
@@ -92,9 +91,6 @@ func FilterFindings(ctx context.Context, provider Provider, findings []Finding,
 		}
 	}
 
-	if firstErr != nil {
-		return confirmed, results, firstErr
-	}
 	return confirmed, results, nil
 }
 

incremental.go

@@ -6,6 +6,7 @@ import (
 	"os/exec"
 	"strings"
 	"sync"
+	"time"
 )
 
 // IncrementalState tracks the last-reviewed commit SHA for incremental reviews.
@@ -50,7 +51,7 @@ func ReviewIncremental(ctx context.Context, base, head string, state *Incrementa
 		}
 	}
 
-	diffText, err := gitDiffRange(base, head)
+	diffText, err := gitDiffRange(ctx, base, head)
 	if err != nil {
 		return nil, fmt.Errorf("sight: incremental diff failed: %w", err)
 	}
@@ -76,16 +77,23 @@ func ReviewIncremental(ctx context.Context, base, head string, state *Incrementa
 	return result, nil
 }
 
-// gitDiffRange runs `git diff base...head` and returns the output.
-func gitDiffRange(base, head string) (string, error) {
+// gitDiffRange runs `git diff base...head` with a context timeout.
+func gitDiffRange(ctx context.Context, base, head string) (string, error) {
+	// Default 30s timeout if context has no deadline
+	if _, ok := ctx.Deadline(); !ok {
+		var cancel context.CancelFunc
+		ctx, cancel = context.WithTimeout(ctx, 30*time.Second)
+		defer cancel()
+	}
+
 	// Try three-dot syntax first (merge-base diff)
-	out, err := exec.Command("git", "diff", base+"..."+head).Output()
+	out, err := exec.CommandContext(ctx, "git", "diff", base+"..."+head).Output()
 	if err == nil {
 		return string(out), nil
 	}
 
 	// Fall back to two-dot syntax
-	out, err = exec.Command("git", "diff", base, head).Output()
+	out, err = exec.CommandContext(ctx, "git", "diff", base, head).Output()
 	if err != nil {
 		return "", fmt.Errorf("git diff %s %s failed: %w", base, head, err)
 	}