Commit 12379d6
committed
fix: re-apply docker.go S1039 + add staticcheck.conf
The previous commit's docker.go edits did not actually land in the
tree (git log confirmed the file was untouched by 3e054db). Re-
applying: WriteString(fmt.Sprintf("literal")) → WriteString("literal")
at lines 879 and 1555.
Also adding staticcheck.conf at repo root. dominikh/staticcheck-action
reads this file directly — it does NOT read .golangci.yml's
linters-settings.staticcheck. The Static Analysis job kept failing on
U1000 unused findings in:
- edit_cmd.go atomicWrite
- learn.go learningStatistics
- savings_cmd_test.go mockWriter
- elixir/haskell/rust/swift language wrappers (under construction)
Because all of those are registration-pattern or planned-feature code,
U1000 is disabled project-wide via staticcheck.conf checks directive.
golangci-lint bug persists: its prebuilt v1.x binaries are all linked
against Go 1.24, and install-mode goinstall still produced the same
error. Next step there is either v2.x (with config migration) or
running staticcheck directly and dropping golangci-lint from the Lint
step.1 parent 3e054db commit 12379d6
2 files changed
Lines changed: 15 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
876 | 876 | | |
877 | 877 | | |
878 | 878 | | |
879 | | - | |
| 879 | + | |
880 | 880 | | |
881 | 881 | | |
882 | 882 | | |
| |||
1552 | 1552 | | |
1553 | 1553 | | |
1554 | 1554 | | |
1555 | | - | |
| 1555 | + | |
1556 | 1556 | | |
1557 | 1557 | | |
1558 | 1558 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
0 commit comments