refactor: remove tok types compatibility shim#60
Open
Patel230 wants to merge 7 commits into
Open
Conversation
…boundary
tok was the original host of the ecosystem's shared types. Now that
hawk-core-contracts owns those contracts, tok/types still carried a full
duplicate of Severity/Finding (and friends) that nothing imported.
Convert tok/types into a deprecated compatibility shim that re-exports
github.com/GrayCodeAI/hawk-core-contracts/types via type aliases, mirroring
hawk/shared/types. This makes contracts the single source of truth and removes
the duplicate definitions while keeping any existing importer compiling.
Also wires the ecosystem boundary guard (scripts/check-ecosystem-boundaries.sh)
into the Makefile and CI, and aligns the README/ARCHITECTURE docs.
- go.mod: depend on hawk-core-contracts via local replace (engine-tier pattern)
- types/{severity,finding}.go: alias contracts types, mark deprecated
- build, vet, and types tests pass; boundary guard passes
…lace Match the ecosystem binding convention: depend on the published module version; local-dev resolution lives in a gitignored go.work, not in committed go.mod. - go.mod: require hawk-core-contracts v0.1.0 (was v0.0.0), remove the `replace => ../hawk-core-contracts`
Now that hawk-core-contracts v0.1.0 is published, record its module checksums so CI (which has no local go.work override) resolves it from the network. Verified: GOWORK=off go build ./... passes.
Patel230
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tok/typestok/typescompatibility shim after verifying no in-workspace importers remaintokfocused on token/compression responsibilities and retain the ecosystem boundary guardTest plan
/bin/sh ./scripts/check-ecosystem-boundaries.shGOCACHE=$PWD/.gocache go test ./...