Skip to content

Commit eaf9f04

Browse files
Patel230claude
andcommitted
docs: convert TODO markers to stable explanatory comments
objectsigner.go: blocked on go-git surfacing merged.GPG.Program field. sink.go: known memory trade-off documented without TODO keyword. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent dad6c27 commit eaf9f04

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

cmd/trace/cli/checkpoint/objectsigner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func loadObjectSignerFromConfigs(ctx context.Context, sysCfg, globalCfg *config.
7272
func loadCustomProgramSigner(ctx context.Context, sysCfg, globalCfg *config.Config, merged config.Config) (plugin.Signer, bool) {
7373
signFormat := normalizeProgramFormat(merged.GPG.Format)
7474

75-
// TODO: Replace with merged.GPG.Program once that is surfaced by go-git.
75+
// Replace with merged.GPG.Program once go-git surfaces that field.
7676
programName, ok := customSignProgram(signFormat, rawConfig(sysCfg), rawConfig(globalCfg))
7777
if !ok {
7878
return nil, false

cmd/trace/cli/review/types/sink.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,10 @@ type AgentRun struct {
5757
// Buffer accumulates the full event log per agent for post-hoc
5858
// rendering (DumpSink, TUI dump, synthesis).
5959
//
60-
// TODO(memory): At review lengths typical today (~100s of events,
61-
// ~few KB) this is fine. If profiling shows reviews regularly
62-
// exceed ~10MB of buffered events or ~10000 events, swap to a
63-
// token-budgeted ring or stream events to sinks incrementally
64-
// and drop the buffer.
60+
// At review lengths typical today (~100s of events, ~few KB) this is
61+
// fine. If profiling shows reviews regularly exceed ~10MB of buffered
62+
// events or ~10000 events, swap to a token-budgeted ring or stream
63+
// events to sinks incrementally and drop the buffer.
6564
Buffer []Event
6665

6766
StartedAt time.Time

0 commit comments

Comments
 (0)