chore: add linter config, fix staticcheck issues — dead code, deprecated APIs, timeouts

Author: Patel230

.golangci.yml

@@ -0,0 +1,12 @@
+version: "2"
+
+linters:
+  default: none
+  enable:
+    - govet
+    - ineffassign
+    - misspell
+
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

cmd/yaad/admin.go

@@ -6,6 +6,7 @@ import (
 	"net/http"
 	"os"
 	"path/filepath"
+	"time"
 
 	"github.com/spf13/cobra"
 	"github.com/GrayCodeAI/yaad/internal/bench"
@@ -93,7 +94,8 @@ var doctorCmd = &cobra.Command{
 			}
 		}
 
-		resp, err := http.Get("http://localhost:3456/yaad/health")
+		client := http.Client{Timeout: 2 * time.Second}
+		resp, err := client.Get("http://localhost:3456/yaad/health")
 		serverRunning := err == nil && resp.StatusCode == 200
 		if resp != nil {
 			resp.Body.Close()

engine/query.go

@@ -9,6 +9,8 @@ import (
 
 	"github.com/GrayCodeAI/yaad/intent"
 	"github.com/GrayCodeAI/yaad/storage"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 )
 
 // queryConfidenceThreshold is the minimum node confidence required to include
@@ -122,7 +124,7 @@ func synthesizeWhat(question string, nodes []*storage.Node) string {
 		if !ok {
 			continue
 		}
-		b.WriteString(fmt.Sprintf("[%s]\n", strings.Title(typ)))
+			b.WriteString(fmt.Sprintf("[%s]\n", cases.Title(language.English).String(typ)))
 		for _, n := range group {
 			b.WriteString(formatNodeBullet(n))
 		}
@@ -137,7 +139,7 @@ func synthesizeWhat(question string, nodes []*storage.Node) string {
 		if typ == "" {
 			b.WriteString("[Other]\n")
 		} else {
-			b.WriteString(fmt.Sprintf("[%s]\n", strings.Title(typ)))
+		b.WriteString(fmt.Sprintf("[%s]\n", cases.Title(language.English).String(typ)))
 		}
 		for _, n := range group {
 			b.WriteString(formatNodeBullet(n))

graph/graph.go

@@ -10,11 +10,7 @@ import (
 	"github.com/GrayCodeAI/yaad/storage"
 )
 
-const (
-	defaultBFSDepth     = 2
-	defaultImpactDepth  = 3
-	defaultSubgraphDepth = 2
-)
+
 
 // Acyclic edge types — cycle detection enforced on insert.
 var validEdgeTypes = map[string]bool{

integration_test.go

@@ -814,7 +814,7 @@ func TestTLSCertGeneration(t *testing.T) {
 		t.Fatal(err)
 	}
 	if tlsCfg == nil {
-		t.Error("tls: nil config returned")
+		t.Fatal("tls: nil config returned")
 	}
 	if len(tlsCfg.Certificates) == 0 {
 		t.Error("tls: no certificates generated")

intent/intent.go

@@ -113,15 +113,6 @@ func Classify(query string) Intent {
 	return bestIntent
 }
 
-func containsAny(s string, keywords ...string) bool {
-	for _, k := range keywords {
-		if strings.Contains(s, k) {
-			return true
-		}
-	}
-	return false
-}
-
 // String returns a human-readable intent name.
 func (i Intent) String() string {
 	switch i {

internal/tui/tui.go

@@ -40,7 +40,6 @@ var (
 	dimStyle   = lipgloss.NewStyle().Foreground(gray)
 	nodeStyle  = lipgloss.NewStyle().Foreground(white)
 	selectedStyle = lipgloss.NewStyle().Background(darkGray).Foreground(white)
-	borderStyle = lipgloss.NewStyle().Border(lipgloss.RoundedBorder()).BorderForeground(purple).Padding(0, 1)
 
 	typeColors = map[string]lipgloss.Color{
 		"convention": green, "decision": blue, "bug": red,

privacy/filter.go

@@ -62,9 +62,6 @@ var strictOnlyPatterns = []*regexp.Regexp{
 	regexp.MustCompile(`\b(?:(?:25[0-5]|2[0-4]\d|[01]?\d\d?)\.){3}(?:25[0-5]|2[0-4]\d|[01]?\d\d?)\b`),
 }
 
-// patterns is kept for backward compatibility — contains all patterns (Strict behavior).
-var patterns = append(append(append([]*regexp.Regexp{}, secretPatterns...), piiPatterns...), strictOnlyPatterns...)
-
 // Filter replaces secrets in content with [REDACTED] using DefaultFilterLevel.
 func Filter(content string) string {
 	return FilterWithLevel(content, DefaultFilterLevel)

storage/sqlite_test.go

@@ -362,6 +362,9 @@ func TestSearchNodesWithSpecialChars(t *testing.T) {
 	if err != nil {
 		t.Fatalf("SearchNodes: %v", err)
 	}
+	if len(results) == 0 {
+		t.Error("expected at least one result for quoted search")
+	}
 }
 
 func TestEscapeFTS5(t *testing.T) {