Commit df99a3a
authored
chore: deploy-audit cleanup — drop fictional binary scaffolding, fix version embed (#19)
A deploy-readiness audit on the hawk-eco set surfaced several files in this
repo that referenced a `yaad` binary, a Homebrew bottle, and a Docker image
— none of which yaad actually produces. yaad is a Go library (no `cmd/`,
no `package main`, no goreleaser config). All four are removed and the
runtime version constant is wired up correctly.
Removed
-------
- install.sh — fetched `yaad_${OS}_${ARCH}` from GitHub Releases and
invoked `yaad auto`. No binary exists, no goreleaser is configured to
build one, and there is no `auto` subcommand. Following this script
would always fail.
- Formula/yaad.rb — Homebrew formula pointed at
`releases/download/v0.2.0/yaad_<os>_<arch>` artifacts that have never
been published, ran `yaad --version` against an absent binary, and was
still pinned at `0.2.0` while the rest of the repo had re-baselined to
`0.1.0` (CHANGELOG explicitly claimed it had been rebaselined — it had
not). Will return once a binary actually ships.
- deploy/docker/docker-compose.yml + .dockerignore — `dockerfile:
Dockerfile` with context `../../`; no Dockerfile is present anywhere
in the repo. `docker compose build` would fail on first invocation.
Consumers wire `internal/server.RESTServer` into their own daemons,
or use `hawk daemon` which embeds yaad.
- deploy/ directory — removed (empty after the compose file went away).
Fixed
-----
- internal/version/version.go: `Version` is now populated at compile
time via `go:embed` from the new `internal/version/VERSION` file
(kept in sync with the root VERSION via `make sync-version`).
Previously hard-coded to `"dev"` and only overrideable through
ldflags — but yaad has no build path that sets those ldflags, so
every `go build` / `go install` / `go get` reported `dev` regardless
of the VERSION file. Matches the pattern eyrie + tok already use.
- Makefile: documents the go:embed pattern in the versioning comment
and adds a `make sync-version` target that copies root VERSION into
internal/version/VERSION.
- CHANGELOG.md: dropped the (false) claim that Formula/yaad.rb was
rebaselined; documents the removal of install.sh / Formula /
deploy/docker; documents the version.go embed switch.
Pinned
------
- .github/workflows/ci.yml: deadcode pinned to v0.30.0 (was `@latest`).
Matches eyrie + hawk and gives reproducible CI.
Validation
----------
- go build ./... — clean
- go vet ./... — clean
- gofumpt -l . / goimports -l . — clean
- golangci-lint run --timeout=5m — 0 issues
- go test ./internal/version/... -v — all 5 tests PASS
- go test ./... -short — all 33 packages PASS
- govulncheck ./... — no vulnerabilities1 parent d76ee40 commit df99a3a
9 files changed
Lines changed: 61 additions & 148 deletions
File tree
- .github/workflows
- Formula
- deploy/docker
- internal/version
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
| 169 | + | |
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
| 13 | + | |
| 14 | + | |
16 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
17 | 37 | | |
18 | 38 | | |
19 | 39 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
| |||
29 | 32 | | |
30 | 33 | | |
31 | 34 | | |
32 | | - | |
| 35 | + | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| |||
91 | 94 | | |
92 | 95 | | |
93 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
94 | 101 | | |
95 | 102 | | |
96 | 103 | | |
| |||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
7 | 6 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | | - | |
17 | | - | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
| 25 | + | |
23 | 26 | | |
24 | 27 | | |
25 | | - | |
26 | | - | |
| 28 | + | |
| 29 | + | |
27 | 30 | | |
28 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
29 | 37 | | |
30 | 38 | | |
31 | | - | |
| 39 | + | |
| 40 | + | |
32 | 41 | | |
33 | 42 | | |
34 | 43 | | |
| |||
0 commit comments