-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve SupportBundleService performance, stability, and test coverage #25555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
todvora
wants to merge
48
commits into
master
Choose a base branch
from
feature/support-bundle-tweaks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
9853e81
Minor tweaks and full backend test
todvora b4a97e0
Avoid creating unnecessary executor
todvora 509e183
Parallelize information collection
todvora dca5bed
timestamp cleanup
todvora ce0b060
Code simplification
todvora 45e5431
Better datanode log transfer
todvora 34c2a80
Prevent thread blocking, run all tasks in parallel. Run the test agai…
todvora 1c3cd41
more parallelism for tasks, decreases bundle build time
todvora e8ac420
Code cleanup
todvora 370fa7c
private constants
todvora e38e66c
increase call timeout to 30s
todvora 5618d64
better threading model
todvora 975833f
better closing of zip entries
todvora 7478d95
Add buffering for zip writing
todvora 49d2800
code cleanup and readability
todvora 5425a22
Merge branch 'master' into feature/support-bundle-tweaks
todvora 496f838
Added test to verify valid content of the support bundle
todvora b05c6aa
added changelog
todvora 3d2eefb
Merge branch 'master' into feature/support-bundle-tweaks
todvora ffada39
Merge branch 'master' into feature/support-bundle-tweaks
todvora e6c416e
Merge branch 'master' into feature/support-bundle-tweaks
patrickmann 1e5662d
failure tolerant future handling for cluster and datanode infos
todvora 2f4f246
Added support for errors during bundle creation
todvora 039ab13
code cleanup
todvora 7a2d834
safer future error handling, added node call errors
todvora 8a302ef
fixed test
todvora ee423a4
Merge branch 'master' into feature/support-bundle-tweaks
todvora 108af82
Merge branch 'master' into feature/support-bundle-tweaks
todvora d9aebb6
Fix datanode logs in test instances
todvora b9ef0a9
Use selfsigned startup for support bundle ITs
todvora 9c458c7
Merge branch 'master' into feature/support-bundle-tweaks
todvora 4063561
Merge branch 'master' into feature/support-bundle-tweaks
todvora 214a6d5
fix leaked resource in IT
todvora fcedce3
code cleanup
todvora e48d943
Merge branch 'master' into feature/support-bundle-tweaks
todvora 0979b05
Merge branch 'master' into feature/support-bundle-tweaks
todvora 8a65e3b
Merge branch 'master' into feature/support-bundle-tweaks
todvora 223476f
Merge branch 'master' into feature/support-bundle-tweaks
todvora f5690f5
safer stream handling for support bundle
todvora 64e78b3
Merge branch 'master' into feature/support-bundle-tweaks
todvora b834c6e
debug logging
todvora c974158
rename paths
todvora cb435a8
fix path traversal test
todvora a003dde
url encoding enabled in test
todvora c3c7361
url encoding enabled in test
todvora 1d5194b
fix encoding
todvora 08f6c1f
removed failing test
todvora d9c3fa8
Merge branch 'master' into feature/support-bundle-tweaks
todvora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| type = "c" | ||
| message = "Support bundle improvements and fixes - parallelism, memory consumption, resource and error handling" | ||
|
|
||
| issues = ["graylog-plugin-enterprise#13625"] | ||
| pulls = ["25555"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.