Handle events overview when event definition is missing (6.2)#25737
Draft
Conversation
* Handle case where event definition is missing * add cl entry (cherry picked from commit c53ffba)
ryan-carroll-graylog
requested review from
danotorrey,
kingzacko1,
linuspahl and
zeeklop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #25548 to
6.2.Description
When an event definition is deleted, the Events Overview widget on the search page would throw errors and show error toast notifications if the event definition column was displayed. This change gracefully handles missing event definitions by falling back to displaying the raw event definition ID — matching the existing behavior on the Alerts page.
Motivation and Context
Fixes graylog-plugin-enterprise#13756
When users delete event definitions, existing events still reference the old definition ID. The
EventDefinitionNamecomponent would attempt to fetch the deleted definition, get a 404, and thedefaultOnErrorwrapper would display an error toast for every affected row. Additionally, the component returnednullfor the cell content whendisplayAsLinkwas true, leaving empty cells.Changes
EventDefinitionName.tsx: When the event definition fetch fails or returns no data, render the event definition ID as plain text instead of returningnulluseEventDefinition.tsx(incomponents/events/events/hooks/): RemoveddefaultOnErrorwrapper to prevent error toast notifications on expected 404s; exposedisErrorfrom the queryEventDetails.test.tsx: Updated mocks to include the newisErrorfieldTypes of changes
/prd Graylog2/graylog-plugin-enterprise#13967