Use endpoint to get list of predefined layout variants#25947
Open
maxiadlovskii wants to merge 17 commits into
Open
Use endpoint to get list of predefined layout variants#25947maxiadlovskii wants to merge 17 commits into
maxiadlovskii wants to merge 17 commits into
Conversation
linuspahl
reviewed
May 21, 2026
| const url = ({ entityListId }: Props): string => qualifyUrl(`/entitylists/preferences/list_predefined/${entityListId}`); | ||
|
|
||
| const fetchLayoutVariants = (props: Props): Promise<Array<LayoutVariant>> => | ||
| fetch('POST', url(props), props.timerange).then((response: Array<LayoutVariantJSON>) => |
Contributor
There was a problem hiding this comment.
Can't we use the API stubs here?
| ) : ( | ||
| <EntityDataTable<T, M> | ||
| entities={list} | ||
| key={`${tableLayout?.entityTableId}${tableLayout?.layoutVariant}`} |
Contributor
There was a problem hiding this comment.
I would really like to avoid this, because it unmounts the complete table.
Contributor
Author
There was a problem hiding this comment.
It's rendered when we change the layout. Since the layout is likely different, it's not a big problem to rerender it. As we need to reset the inner state of the component (columns order and columns width), that is one of the React recommendations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: To test the feature, turn on GRAYLOG_FEATURE_SHOW_ALERTS_PREDEFINED_LAYOUTS flag
Description
This PR uses the BE endpoint to get layout variants. After this change, the user can switch between variants. If user change something we also store that to specific variant
Motivation and Context
fix: https://github.com/Graylog2/graylog-plugin-enterprise/issues/14096
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/nocl
/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/14188