Limit beats packet compressed and decompressed sizes#26141
Open
kroepke wants to merge 2 commits into
Open
Conversation
…igured maximums avoid allocating/copying the entire buffer after decompression so we can check for pathological payloads that would consume way too much memory both limits are configurable per input, so that if the defaults are too small for a specific user, they can override
Member
Author
|
Currently based on #26139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When dealing with compressed beats payloads, we haven't limited their size.
Now we have individual limits for the sizes of the compressed and decompressed payload buffers.
For the decompressed buffer we now also avoid an unnecessary copy and check for exceeding the configured limit during decompression, which can help avoiding pathological decompression bombs.
Motivation and Context
Without limits and due to eager allocation it was possible to exhaust the available memory.
The defaults should be sensible for running with default beats batch sizes, but they are configurable per input in case users need higher limits (at the expense of more memory usage).
How Has This Been Tested?
Unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: