Add a Type filter and column to the Event Definitions list#26279
Add a Type filter and column to the Event Definitions list#26279danotorrey wants to merge 13 commits into
Conversation
Expose the event definition config type as a filterable, sortable attribute so the Event Definitions list can be narrowed by type (Filter & Aggregation, plus any plugin-contributed types). Options are sourced from the eventDefinitionTypes plugin registry and gated by the same useCondition() check the create form uses, so only available types are offered. Also adds an optional (non-default) Type column. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Use a flexible width with a minimum instead of staticWidth, which disables column resizing (enableResizing: \!staticWidth). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Render the type options as the same searchless menu the Status/Source filters use (StaticOptionsList) instead of SuggestionsList. With only a handful of types a search box adds no value, and this keeps the filter consistent with the other static-enum filters on the page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Revert the StaticOptionsList change and keep the SuggestionsList-based filter (with the search field), so the Event Definitions and Security Events type filters stay consistent. Adds the changelog entry for the new filter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
danotorrey
changed the title
|
@danotorrey Just a heads up there are some merge conflicts. Also functionality looks good! Is it possible to get the pretty print version of the type value in the selected filter area. We use it everywhere else, but in the selected filter we use the actual type name like |
Resolve conflict in useEventDefinitions.ts: master refactored the hook to use direct fetch/PaginationURL instead of EventDefinitionsStore. Re-applied the type filter_component splice on top of master's fetchEventDefinitions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The selected-type filter chip showed the raw config.type value (e.g. `sigma-v1`) because the list reused the Streams FilterValueRenderers, which has no `type` renderer. Add an event-definitions FilterValueRenderers with a `type` renderer that reuses EventDefinitionTypeRenderer, so the chip shows the plugin display name to match the Type column. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@danotorrey I no longer see |
Add an optional hideFromCreation flag to EventDefinitionType so a type can be hidden from the create wizard's condition-type dropdown while still being listed as a filter option. Previously both the wizard and the type filter keyed off useCondition, conflating availability/licensing with wizard visibility. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kingzacko1
left a comment
kingzacko1
left a comment
There was a problem hiding this comment.
This LGTM and tests successfully.
Separate issue that we may want to do the same human readable filter on the Alerts & Events tab too, but definitely think it can be done in a small separate PR:
|
@kingzacko1 Thanks for testing again! Had my comment all drafted up but forgot to post:
Good catch on the Alerts side. I'll add a PR to address that too... |
|
@kingzacko1 Also dropping |
2 participants
Overview
Add a Type filter and column to the Event Definitions list.
Allows:
This matches the Event Definition Type filter that is already available on the Alerts page.
Motivation
The Event Definitions page (
Alerts → Event Definitions) can be filtered by Source, Status, and Tags, but not by the definition's type. On instances with many definitions there's no quick way to narrow to a single type.Approach
config.typeas a filterable, sortableEntityAttributeon the event definitions list — same mechanism as the existingstatusfilter.eventDefinitionTypesplugin registry, so any plugin-registered type is selectable by its display name. Options are gated byuseCondition()so only available types are offered.Notes
Multiple selected types are OR-joined (
DbFilterExpressionParsergroups same-field filters). Option labels come from the plugin registry rather than a backendfilterOptionsenum, so plugin-contributed type names stay out of the server.A new optional
hideFromCreationflag onEventDefinitionTypelets a type be hidden from the create wizard's condition-type dropdown while still appearing as a filter option. See the paired enterprise PR./prd Graylog2/graylog-plugin-enterprise#14625
Assisted with Claude Code