Fix truncated change indicator on search submit button#26549
Open
dennisoelkers wants to merge 6 commits into
Open
Fix truncated change indicator on search submit button#26549dennisoelkers wants to merge 6 commits into
dennisoelkers wants to merge 6 commits into
Conversation
The dirty-state change indicator on the search submit button was being clipped by the button's overflow. Add a `showOverflow` prop to `Button` and enable it for the search submit button so the indicator renders fully. Fixes Graylog2/graylog-plugin-enterprise#14690 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dennisoelkers
force-pushed
the
fix/14690-search-button-change-indicator-truncated
branch
from
7d60569 to
a3d99cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dirty-state change indicator on the search submit button was being clipped because the button clips its overflow. This adds an opt-in
showOverflowprop to theButtoncomponent (applyingoverflow: visibleto the button and its.mantine-Button-label) and enables it on the search submit button so the indicator renders fully.Motivation and Context
Fixes a regression introduced in #26424. The change indicator dot shown when the search query is dirty was truncated by the button's overflow clipping.
Fixes Graylog2/graylog-plugin-enterprise#14690
How Has This Been Tested?
Manually verified on the search page that the change indicator on the submit button is no longer truncated when the query is dirty.
Screenshots (if appropriate):
Types of changes
Checklist:
/nocl Fixing unreleased regression