Support images in Assembly page body content#78
Merged
Conversation
blockToHtml() in the Notion fetch script had no case for "image" blocks, so any image placed in an assembly's Notion page body was silently dropped before it ever reached assemblies.json. Add image support: download/rehost to public/assets/assembly-images/ (mirroring the existing logo/photo/icon pattern) and emit <img>/<figure> markup.
✅ Deploy Preview for green-software-foundation ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where images embedded in an Assembly's Notion page body were being silently dropped during the fetch process. Images are now downloaded and rehosted to
public/assets/assembly-images/(since Notion's file URLs expire after ~1 hour) and rendered as<img>or<figure>elements in thedetailsHtmlfield.Changes
blockToHtml()function — addedimagecase to handle both external and Notion-hosted file URLs; made the functionasyncto support asynchronous file downloadsdownloadFile()helper, emits<img>tags with lazy loading, wraps in<figure>/<figcaption>when captions are presentpublic/assets/assembly-images/created and gitignored alongside other Notion-fetched asset directoriesblocks.map(blockToHtml)toawait Promise.all(blocks.map(blockToHtml))infetchAssemblies()to handle async block conversiondocs/notion.mdanddocs/pages/assemblies.mdto document image support and note which block types remain unsupported (video, embed, callout, table, etc.)Implementation Details
<figcaption>when presenthttps://claude.ai/code/session_018GKoRr67ykTcYco527HKoL