Remove hatch duplication on Research Computer, add Error for when that happens (#4126)

Author: jurrejelle

src/main/java/com/gregtechceu/gtceu/api/capability/recipe/IRecipeCapabilityHolder.java

@@ -1,5 +1,6 @@
 package com.gregtechceu.gtceu.api.capability.recipe;
 
+import com.gregtechceu.gtceu.GTCEu;
 import com.gregtechceu.gtceu.api.machine.trait.RecipeHandlerList;
 
 import it.unimi.dsi.fastutil.objects.Reference2ObjectOpenHashMap;
@@ -9,6 +10,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import java.util.stream.Collectors;
 
 public interface IRecipeCapabilityHolder {
 
@@ -34,11 +36,25 @@ default List<IRecipeHandler<?>> getCapabilitiesFlat(IO io, RecipeCapability<?> c
                 .getOrDefault(cap, Collections.emptyList());
     }
 
-    default void addHandlerList(RecipeHandlerList handler) {
-        if (handler == RecipeHandlerList.NO_DATA) return;
-        IO io = handler.getHandlerIO();
-        getCapabilitiesProxy().computeIfAbsent(io, i -> new ArrayList<>()).add(handler);
-        var entrySet = handler.getHandlerMap().entrySet();
+    default void addHandlerList(RecipeHandlerList handlerList) {
+        if (handlerList == RecipeHandlerList.NO_DATA) return;
+        IO io = handlerList.getHandlerIO();
+
+        var existingHandlers = getCapabilitiesProxy().getOrDefault(io, Collections.emptyList()).stream()
+                .flatMap(tempHandlerList -> tempHandlerList.getHandlersFlat().stream())
+                .collect(Collectors.toSet());
+
+        for (var handler : handlerList.getHandlersFlat()) {
+            if (existingHandlers.contains(handler)) {
+                GTCEu.LOGGER.error("Do not add the same handler twice, as this could cause duplication bugs! " +
+                        "Handler {} in List {}",
+                        handler.getClass().getName(),
+                        handlerList.getClass().getName());
+            }
+        }
+
+        getCapabilitiesProxy().computeIfAbsent(io, i -> new ArrayList<>()).add(handlerList);
+        var entrySet = handlerList.getHandlerMap().entrySet();
         var inner = getCapabilitiesFlat().computeIfAbsent(io, i -> new Reference2ObjectOpenHashMap<>(entrySet.size()));
         for (var entry : entrySet) {
             var entryList = entry.getValue();

src/main/java/com/gregtechceu/gtceu/api/machine/trait/RecipeHandlerList.java

@@ -196,6 +196,14 @@ public Map<RecipeCapability<?>, List<Object>> handleRecipe(IO io, GTRecipe recip
         return copy;
     }
 
+    public List<IRecipeHandler<?>> getHandlersFlat() {
+        List<IRecipeHandler<?>> handlerList = new ArrayList<>();
+        for (var handlerEntry : getHandlerMap().entrySet()) {
+            handlerList.addAll(handlerEntry.getValue());
+        }
+        return handlerList;
+    }
+
     private record Subscription(List<ISubscription> subs) implements ISubscription {
 
         @Override

src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/ResearchStationMachine.java

@@ -12,7 +12,6 @@
 import com.gregtechceu.gtceu.api.machine.feature.multiblock.IMultiPart;
 import com.gregtechceu.gtceu.api.machine.multiblock.MultiblockDisplayText;
 import com.gregtechceu.gtceu.api.machine.multiblock.WorkableElectricMultiblockMachine;
-import com.gregtechceu.gtceu.api.machine.trait.RecipeHandlerList;
 import com.gregtechceu.gtceu.api.machine.trait.RecipeLogic;
 import com.gregtechceu.gtceu.api.recipe.ActionResult;
 import com.gregtechceu.gtceu.api.recipe.GTRecipe;
@@ -64,7 +63,6 @@ public void onStructureFormed() {
                     return;
                 }
                 this.objectHolder = iObjectHolder;
-                addHandlerList(RecipeHandlerList.of(IO.IN, iObjectHolder.getAsHandler()));
             }
 
             part.self().holder.self()