Allow Stocking Buses/Hatches to respect Paint when selecting inputs.#4881
Open
DilithiumThoride wants to merge 1 commit into
Open
Allow Stocking Buses/Hatches to respect Paint when selecting inputs.#4881DilithiumThoride wants to merge 1 commit into
DilithiumThoride wants to merge 1 commit into
Conversation
…Requested by TTFTCUTS.
DilithiumThoride
added
type: bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When Painting was implemented on Input Buses/Hatches as a means of input (and output) group isolation, it was implicitly applied to ME hatches as they inherit Paintable. However, the code for what items are polled by Stocking Input Buses/Hatches was not updated to account for the existence of Paint groups, meaning that regardless of Paint a single item could only exist in a single Stocking Input anywhere in a machine. (Distinct Buses did still function for them however, indicating that group separation would still be appropriate.)
(Fix was requested by TTFTCUTS who got very annoyed at Stocking Hatches not doing this.)
Implementation Details
Modified the function that checks whether a Stocking Input should deduplicate an input, to also check for if the other hatch has a different paint group.
AI Usage
Outcome
Painted Stocking Inputs can now contain inputs that are present in other Painted/Distinct Stocking Inputs, allowing better use with paint groups.
How Was This Tested
Okay this one is actually not explicitly tested yet, I figured out how to fix it because I know how the Paint code works but not how to make an in-game test for it.
"It compiles and automated tests pass".