Fix MachineDefinition.getBlockEntityType()'s generic being too broad#4903
Open
screret wants to merge 1 commit into
Open
Fix MachineDefinition.getBlockEntityType()'s generic being too broad#4903screret wants to merge 1 commit into
MachineDefinition.getBlockEntityType()'s generic being too broad#4903screret wants to merge 1 commit into
Conversation
Just so MachineModel doesn't need to check if the BEs it gets are machines
YoungOnionMC
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Just so MachineModel doesn't need to check if the BEs it gets are machines
Implementation Details
Actual fix is the last change in MachineBuilder (the one that adds
<MetaMachine>to the block entity builder creation).The rest are just making generic types stricter.
AI Usage
Outcome
MachineModel doesn't need to check if the BEs it's given are actually machines. -7 lines of code.
How Was This Tested
Ran game, still works.