Skip to content

Commit 408204c

Browse files
committed
add method to configure panel
remove width/height methods
1 parent 18b9b16 commit 408204c

12 files changed

Lines changed: 49 additions & 46 deletions

src/main/java/gregtech/api/cover/CoverWithUI.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,24 +69,20 @@ default GTGuiTheme getUITheme() {
6969

7070
@Override
7171
default ModularPanel buildUI(SidedPosGuiData guiData, PanelSyncManager guiSyncManager) {
72-
var panel = GTGuis.createPanel(getPickItem(), getWidth(), getHeight());
72+
var panel = confgurePanel(GTGuis.createPanel(getPickItem(), 100, 100), false);
7373
var w = createUI(panel, guiSyncManager);
7474
return panel.childIf(w != null, w)
7575
.child(createTitleRow(getPickItem()).pos(5, 5))
7676
.bindPlayerInventory();
7777
}
7878

79-
default int getWidth() {
80-
return 176;
81-
}
82-
83-
default int getHeight() {
84-
return 192;
79+
default ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
80+
return panel;
8581
}
8682

8783
default @NotNull ModularPanel getSmallGUI(@NotNull SidedPosGuiData guiData,
8884
@NotNull PanelSyncManager guiSyncManager) {
89-
var panel = GTGuis.createPopupPanel(getPickItem().getTranslationKey(), getWidth(), 100);
85+
var panel = confgurePanel(GTGuis.createPopupPanel(getPickItem().getTranslationKey(), 100, 100), true);
9086
var w = createUI(panel, guiSyncManager);
9187
return panel.childIf(w != null, w)
9288
.child(createTitleRow(getPickItem()).pos(5, 5))

src/main/java/gregtech/common/covers/CoverConveyor.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@
6262
import it.unimi.dsi.fastutil.objects.Object2ObjectOpenCustomHashMap;
6363
import it.unimi.dsi.fastutil.objects.ObjectOpenCustomHashSet;
6464
import org.jetbrains.annotations.NotNull;
65+
import org.jetbrains.annotations.Nullable;
6566

6667
import java.util.Collections;
6768
import java.util.Map;
@@ -502,11 +503,11 @@ public boolean usesMui2() {
502503
}
503504

504505
@Override
505-
public int getHeight() {
506-
return 192 + 18;
506+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
507+
return panel.height(210);
507508
}
508509

509-
public @NotNull ParentWidget<Column> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
510+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
510511
getItemFilterContainer().setMaxTransferSize(getMaxStackSize());
511512

512513
var column = new Column().top(24).margin(7, 0)

src/main/java/gregtech/common/covers/CoverFluidRegulator.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import it.unimi.dsi.fastutil.objects.Object2IntOpenHashMap;
3131
import org.apache.logging.log4j.message.FormattedMessage;
3232
import org.jetbrains.annotations.NotNull;
33+
import org.jetbrains.annotations.Nullable;
3334

3435
import java.util.Arrays;
3536
import java.util.Map;
@@ -241,12 +242,12 @@ private boolean shouldDisplayAmountSlider() {
241242
}
242243

243244
@Override
244-
public int getHeight() {
245-
return super.getHeight() + 36;
245+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
246+
return panel.height(228);
246247
}
247248

248249
@Override
249-
public @NotNull ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
250+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
250251
var transferMode = new EnumSyncValue<>(TransferMode.class, this::getTransferMode, this::setTransferMode);
251252
transferMode.updateCacheFromSource(true);
252253
syncManager.syncValue("transfer_mode", transferMode);

src/main/java/gregtech/common/covers/CoverFluidVoiding.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import com.cleanroommc.modularui.widgets.ToggleButton;
3434
import com.cleanroommc.modularui.widgets.layout.Row;
3535
import org.jetbrains.annotations.NotNull;
36+
import org.jetbrains.annotations.Nullable;
3637

3738
public class CoverFluidVoiding extends CoverPump {
3839

@@ -70,12 +71,12 @@ public void renderCover(@NotNull CCRenderState renderState, @NotNull Matrix4 tra
7071
}
7172

7273
@Override
73-
public int getHeight() {
74-
return super.getHeight() - 22;
74+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
75+
return panel.height(170);
7576
}
7677

7778
@Override
78-
public @NotNull ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
79+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
7980
var isWorking = new BooleanSyncValue(this::isWorkingEnabled, this::setWorkingEnabled);
8081

8182
return super.createUI(mainPanel, syncManager)

src/main/java/gregtech/common/covers/CoverFluidVoidingAdvanced.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.cleanroommc.modularui.widget.ParentWidget;
2929
import com.cleanroommc.modularui.widgets.textfield.TextFieldWidget;
3030
import org.jetbrains.annotations.NotNull;
31+
import org.jetbrains.annotations.Nullable;
3132

3233
import java.util.function.Predicate;
3334

@@ -99,12 +100,13 @@ public VoidingMode getVoidingMode() {
99100
}
100101

101102
@Override
102-
public int getHeight() {
103-
return super.getHeight() + 42;
103+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
104+
return super.confgurePanel(panel, isSmallGui)
105+
.height(212);
104106
}
105107

106108
@Override
107-
public @NotNull ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
109+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
108110
var voidingMode = new EnumSyncValue<>(VoidingMode.class, this::getVoidingMode, this::setVoidingMode);
109111
syncManager.syncValue("voiding_mode", voidingMode);
110112

src/main/java/gregtech/common/covers/CoverItemVoiding.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
import com.cleanroommc.modularui.value.sync.PanelSyncManager;
2929
import com.cleanroommc.modularui.widget.ParentWidget;
3030
import com.cleanroommc.modularui.widgets.ToggleButton;
31-
import com.cleanroommc.modularui.widgets.layout.Column;
3231
import com.cleanroommc.modularui.widgets.layout.Row;
3332
import org.jetbrains.annotations.NotNull;
33+
import org.jetbrains.annotations.Nullable;
3434

3535
public class CoverItemVoiding extends CoverConveyor {
3636

@@ -72,12 +72,13 @@ void voidAny(IItemHandler myItemHandler) {
7272
}
7373

7474
@Override
75-
public int getHeight() {
76-
return 192 - 22;
75+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
76+
return super.confgurePanel(panel, isSmallGui)
77+
.height(170);
7778
}
7879

7980
@Override
80-
public @NotNull ParentWidget<Column> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
81+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
8182
var isWorking = new BooleanSyncValue(this::isWorkingEnabled, this::setWorkingEnabled);
8283

8384
return super.createUI(mainPanel, guiSyncManager)

src/main/java/gregtech/common/covers/CoverItemVoidingAdvanced.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
import com.cleanroommc.modularui.value.sync.PanelSyncManager;
2424
import com.cleanroommc.modularui.value.sync.StringSyncValue;
2525
import com.cleanroommc.modularui.widget.ParentWidget;
26-
import com.cleanroommc.modularui.widgets.layout.Column;
2726
import com.cleanroommc.modularui.widgets.layout.Row;
2827
import com.cleanroommc.modularui.widgets.textfield.TextFieldWidget;
2928
import org.jetbrains.annotations.NotNull;
29+
import org.jetbrains.annotations.Nullable;
3030

3131
import java.util.Map;
3232

@@ -88,12 +88,13 @@ protected void voidOverflow(IItemHandler myItemHandler) {
8888
}
8989

9090
@Override
91-
public int getHeight() {
92-
return 192 + 18;
91+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
92+
return super.confgurePanel(panel, isSmallGui)
93+
.height(210);
9394
}
9495

9596
@Override
96-
public @NotNull ParentWidget<Column> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
97+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
9798
var voidingMode = new EnumSyncValue<>(VoidingMode.class, this::getVoidingMode, this::setVoidingMode);
9899
guiSyncManager.syncValue("voiding_mode", voidingMode);
99100

src/main/java/gregtech/common/covers/CoverPump.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public boolean usesMui2() {
187187
return true;
188188
}
189189

190-
public @NotNull ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
190+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager syncManager) {
191191
getFluidFilterContainer().setMaxTransferSize(getMaxTransferRate());
192192
var manualIOmode = new EnumSyncValue<>(ManualImportExportMode.class,
193193
this::getManualImportExportMode, this::setManualImportExportMode);

src/main/java/gregtech/common/covers/CoverRoboticArm.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
import com.cleanroommc.modularui.value.sync.PanelSyncManager;
2626
import com.cleanroommc.modularui.value.sync.StringSyncValue;
2727
import com.cleanroommc.modularui.widget.ParentWidget;
28-
import com.cleanroommc.modularui.widgets.layout.Column;
2928
import com.cleanroommc.modularui.widgets.layout.Row;
3029
import com.cleanroommc.modularui.widgets.textfield.TextFieldWidget;
3130
import org.jetbrains.annotations.NotNull;
31+
import org.jetbrains.annotations.Nullable;
3232

3333
import java.util.Iterator;
3434
import java.util.Map;
@@ -191,12 +191,13 @@ private boolean shouldDisplayAmountSlider() {
191191
}
192192

193193
@Override
194-
public int getHeight() {
195-
return 192 + 36 + 18 + 2;
194+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
195+
return super.confgurePanel(panel, isSmallGui)
196+
.height(248);
196197
}
197198

198199
@Override
199-
public @NotNull ParentWidget<Column> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
200+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager guiSyncManager) {
200201
EnumSyncValue<TransferMode> transferMode = new EnumSyncValue<>(TransferMode.class, this::getTransferMode,
201202
this::setTransferMode);
202203
guiSyncManager.syncValue("transfer_mode", transferMode);

src/main/java/gregtech/common/covers/CoverStorage.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import gregtech.api.cover.CoverDefinition;
55
import gregtech.api.cover.CoverWithUI;
66
import gregtech.api.cover.CoverableView;
7-
import gregtech.api.mui.GTGuis;
87
import gregtech.client.renderer.texture.Textures;
98

109
import net.minecraft.entity.player.EntityPlayer;
@@ -22,12 +21,11 @@
2221
import codechicken.lib.render.pipeline.IVertexOperation;
2322
import codechicken.lib.vec.Cuboid6;
2423
import codechicken.lib.vec.Matrix4;
25-
import com.cleanroommc.modularui.api.drawable.IKey;
2624
import com.cleanroommc.modularui.api.widget.IWidget;
27-
import com.cleanroommc.modularui.factory.SidedPosGuiData;
2825
import com.cleanroommc.modularui.screen.ModularPanel;
2926
import com.cleanroommc.modularui.value.sync.PanelSyncManager;
3027
import com.cleanroommc.modularui.value.sync.SyncHandlers;
28+
import com.cleanroommc.modularui.widget.ParentWidget;
3129
import com.cleanroommc.modularui.widgets.ItemSlot;
3230
import com.cleanroommc.modularui.widgets.layout.Grid;
3331
import org.jetbrains.annotations.ApiStatus;
@@ -89,12 +87,12 @@ public boolean usesMui2() {
8987
}
9088

9189
@Override
92-
public int getHeight() {
93-
return MAX_HEIGHT;
90+
public ModularPanel confgurePanel(ModularPanel panel, boolean isSmallGui) {
91+
return panel.height(MAX_HEIGHT);
9492
}
9593

9694
@Override
97-
public @Nullable IWidget createUI(ModularPanel mainPanel, PanelSyncManager manager) {
95+
public @Nullable ParentWidget<?> createUI(ModularPanel mainPanel, PanelSyncManager manager) {
9896
manager.registerSlotGroup("item_inv", this.storageHandler.getSlots());
9997

10098
int rowSize = this.storageHandler.getSlots();

0 commit comments

Comments
 (0)