Make Ender Cover and Virtual Registry Abstract (#2510)

Author: ghzdude

src/main/java/gregtech/api/mui/GTGuiTextures.java

@@ -206,6 +206,8 @@ public static class IDs {
             "textures/gui/widget/button_public_private.png",
             18, 36, 18, 18, true);
 
+    public static final UITexture MENU_OVERLAY = fullImage("textures/gui/overlay/menu_overlay.png");
+
     // todo bronze/steel/primitive fluid slots?
 
     // SLOT OVERLAYS

src/main/java/gregtech/api/mui/GTGuis.java

@@ -9,6 +9,7 @@
 
 import net.minecraft.item.ItemStack;
 
+import com.cleanroommc.modularui.api.widget.Interactable;
 import com.cleanroommc.modularui.factory.GuiManager;
 import com.cleanroommc.modularui.screen.ModularPanel;
 import com.cleanroommc.modularui.utils.Alignment;
@@ -62,7 +63,15 @@ public PopupPanel(@NotNull String name, int width, int height, boolean disableBe
             super(name);
             size(width, height).align(Alignment.Center);
             background(GTGuiTextures.BACKGROUND_POPUP);
-            child(ButtonWidget.panelCloseButton().top(5).right(5));
+            child(ButtonWidget.panelCloseButton().top(5).right(5)
+                    .onMousePressed(mouseButton -> {
+                        if (mouseButton == 0 || mouseButton == 1) {
+                            this.closeIfOpen(true);
+                            Interactable.playButtonClickSound();
+                            return true;
+                        }
+                        return false;
+                    }));
             this.disableBelow = disableBelow;
             this.closeOnOutsideClick = closeOnOutsideClick;
         }

src/main/java/gregtech/api/mui/sync/GTFluidSyncHandler.java

@@ -0,0 +1,224 @@
+package gregtech.api.mui.sync;
+
+import gregtech.api.util.GTUtility;
+
+import net.minecraft.entity.item.EntityItem;
+import net.minecraft.entity.player.EntityPlayer;
+import net.minecraft.item.ItemStack;
+import net.minecraft.network.PacketBuffer;
+import net.minecraft.util.SoundCategory;
+import net.minecraft.util.SoundEvent;
+import net.minecraftforge.fluids.FluidStack;
+import net.minecraftforge.fluids.IFluidTank;
+import net.minecraftforge.fluids.capability.CapabilityFluidHandler;
+import net.minecraftforge.fluids.capability.IFluidHandlerItem;
+
+import com.cleanroommc.modularui.network.NetworkUtils;
+import com.cleanroommc.modularui.value.sync.SyncHandler;
+import org.jetbrains.annotations.NotNull;
+
+public class GTFluidSyncHandler extends SyncHandler {
+
+    private static final int TRY_CLICK_CONTAINER = 1;
+
+    private final IFluidTank tank;
+    private boolean canDrainSlot = true;
+    private boolean canFillSlot = true;
+
+    public GTFluidSyncHandler(IFluidTank tank) {
+        this.tank = tank;
+    }
+
+    public FluidStack getFluid() {
+        return this.tank.getFluid();
+    }
+
+    public int getCapacity() {
+        return this.tank.getCapacity();
+    }
+
+    public GTFluidSyncHandler canDrainSlot(boolean canDrainSlot) {
+        this.canDrainSlot = canDrainSlot;
+        return this;
+    }
+
+    public boolean canDrainSlot() {
+        return this.canDrainSlot;
+    }
+
+    public GTFluidSyncHandler canFillSlot(boolean canFillSlot) {
+        this.canFillSlot = canFillSlot;
+        return this;
+    }
+
+    public boolean canFillSlot() {
+        return this.canFillSlot;
+    }
+
+    @Override
+    public void readOnClient(int id, PacketBuffer buf) {
+        if (id == TRY_CLICK_CONTAINER) {
+            replaceCursorItemStack(NetworkUtils.readItemStack(buf));
+        }
+    }
+
+    @Override
+    public void readOnServer(int id, PacketBuffer buf) {
+        if (id == TRY_CLICK_CONTAINER) {
+            var stack = tryClickContainer(buf.readBoolean());
+            if (!stack.isEmpty())
+                syncToClient(TRY_CLICK_CONTAINER, buffer -> NetworkUtils.writeItemStack(buffer, stack));
+        }
+    }
+
+    public ItemStack tryClickContainer(boolean tryFillAll) {
+        ItemStack playerHeldStack = getSyncManager().getCursorItem();
+        if (playerHeldStack.isEmpty())
+            return ItemStack.EMPTY;
+
+        ItemStack useStack = GTUtility.copy(1, playerHeldStack);
+        IFluidHandlerItem fluidHandlerItem = useStack
+                .getCapability(CapabilityFluidHandler.FLUID_HANDLER_ITEM_CAPABILITY, null);
+        if (fluidHandlerItem == null) return ItemStack.EMPTY;
+
+        FluidStack tankFluid = tank.getFluid();
+        FluidStack heldFluid = fluidHandlerItem.drain(Integer.MAX_VALUE, false);
+
+        // nothing to do, return
+        if (tankFluid == null && heldFluid == null)
+            return ItemStack.EMPTY;
+
+        // tank is empty, try to fill tank
+        if (canFillSlot && tankFluid == null) {
+            return fillTankFromStack(fluidHandlerItem, heldFluid, tryFillAll);
+
+            // hand is empty, try to drain tank
+        } else if (canDrainSlot && heldFluid == null) {
+            return drainTankFromStack(fluidHandlerItem, tankFluid, tryFillAll);
+
+            // neither is empty but tank is not full, try to fill tank
+        } else if (canFillSlot && tank.getFluidAmount() < tank.getCapacity() && heldFluid != null) {
+            return fillTankFromStack(fluidHandlerItem, heldFluid, tryFillAll);
+        }
+
+        return ItemStack.EMPTY;
+    }
+
+    private ItemStack fillTankFromStack(IFluidHandlerItem fluidHandler, @NotNull FluidStack heldFluid,
+                                        boolean tryFillAll) {
+        ItemStack heldItem = getSyncManager().getCursorItem();
+        if (heldItem.isEmpty()) return ItemStack.EMPTY;
+
+        FluidStack currentFluid = tank.getFluid();
+        // Fluid type does not match
+        if (currentFluid != null && !currentFluid.isFluidEqual(heldFluid)) return ItemStack.EMPTY;
+
+        int freeSpace = tank.getCapacity() - tank.getFluidAmount();
+        if (freeSpace <= 0) return ItemStack.EMPTY;
+
+        ItemStack itemStackEmptied = ItemStack.EMPTY;
+        int fluidAmountTaken = 0;
+
+        FluidStack drained = fluidHandler.drain(freeSpace, true);
+        if (drained != null && drained.amount > 0) {
+            itemStackEmptied = fluidHandler.getContainer();
+            fluidAmountTaken = drained.amount;
+        }
+        if (itemStackEmptied == ItemStack.EMPTY) {
+            return ItemStack.EMPTY;
+        }
+
+        // find out how many fills we can do
+        // same round down behavior as drain
+        int additional = tryFillAll ? Math.min(freeSpace / fluidAmountTaken, heldItem.getCount()) : 1;
+        FluidStack copiedFluidStack = heldFluid.copy();
+        copiedFluidStack.amount = fluidAmountTaken * additional;
+        tank.fill(copiedFluidStack, true);
+
+        itemStackEmptied.setCount(additional);
+        replaceCursorItemStack(itemStackEmptied);
+        playSound(heldFluid, true);
+        return itemStackEmptied;
+    }
+
+    private ItemStack drainTankFromStack(IFluidHandlerItem fluidHandler, FluidStack tankFluid, boolean tryFillAll) {
+        ItemStack heldItem = getSyncManager().getCursorItem();
+        if (heldItem.isEmpty()) return ItemStack.EMPTY;
+
+        ItemStack fluidContainer = fluidHandler.getContainer();
+        int filled = fluidHandler.fill(tankFluid, false);
+        if (filled > 0) {
+            tank.drain(filled, true);
+            fluidHandler.fill(tankFluid, true);
+            if (tryFillAll) {
+                // Determine how many more items we can fill. One item is already filled.
+                // Integer division means it will round down, so it will only fill equivalent fluid amounts.
+                // For example:
+                // Click with 3 cells, with 2500L of fluid in the tank.
+                // 2 cells will be filled, and 500L will be left behind in the tank.
+                int additional = Math.min(heldItem.getCount(), tankFluid.amount / filled) - 1;
+                tank.drain(filled * additional, true);
+                fluidContainer.grow(additional);
+            }
+            replaceCursorItemStack(fluidContainer);
+            playSound(tankFluid, false);
+            return fluidContainer;
+        }
+        return ItemStack.EMPTY;
+    }
+
+    /**
+     * Replace the ItemStack on the player's cursor with the passed stack. Use to replace empty cells with filled, or
+     * filled cells with empty. If it is not fully emptied/filled, it will place the new items into the player inventory
+     * instead, and shrink the held stack by the appropriate amount.
+     */
+    private void replaceCursorItemStack(ItemStack resultStack) {
+        int resultStackSize = resultStack.getMaxStackSize();
+        ItemStack playerStack = getSyncManager().getCursorItem();
+
+        if (!getSyncManager().isClient())
+            syncToClient(TRY_CLICK_CONTAINER, buffer -> NetworkUtils.writeItemStack(buffer, resultStack));
+
+        while (resultStack.getCount() > resultStackSize) {
+            playerStack.shrink(resultStackSize);
+            addItemToPlayerInventory(resultStack.splitStack(resultStackSize));
+        }
+        if (playerStack.getCount() == resultStack.getCount()) {
+            // every item on the cursor is mutated, so leave it there
+            getSyncManager().setCursorItem(resultStack);
+        } else {
+            // some items not mutated. Mutated items go into the inventory/world.
+            playerStack.shrink(resultStack.getCount());
+            getSyncManager().setCursorItem(playerStack);
+            addItemToPlayerInventory(resultStack);
+        }
+    }
+
+    /** Place an item into the player's inventory, or drop it in-world as an item entity if it cannot fit. */
+    private void addItemToPlayerInventory(ItemStack stack) {
+        if (stack == null) return;
+        var player = getSyncManager().getPlayer();
+
+        if (!player.inventory.addItemStackToInventory(stack) && !player.world.isRemote) {
+            EntityItem dropItem = player.entityDropItem(stack, 0);
+            if (dropItem != null) dropItem.setPickupDelay(0);
+        }
+    }
+
+    /**
+     * Play the appropriate fluid interaction sound for the fluid. <br />
+     * Must be called on server to work correctly
+     **/
+    private void playSound(FluidStack fluid, boolean fill) {
+        if (fluid == null) return;
+        SoundEvent soundEvent;
+        if (fill) {
+            soundEvent = fluid.getFluid().getFillSound(fluid);
+        } else {
+            soundEvent = fluid.getFluid().getEmptySound(fluid);
+        }
+        EntityPlayer player = getSyncManager().getPlayer();
+        player.world.playSound(null, player.posX, player.posY + 0.5, player.posZ,
+                soundEvent, SoundCategory.PLAYERS, 1.0F, 1.0F);
+    }
+}

src/main/java/gregtech/api/util/FluidTankSwitchShim.java

@@ -11,14 +11,17 @@
 // probably causes problems
 public class FluidTankSwitchShim implements IFluidTank, IFluidHandler {
 
-    IFluidTank tank;
+    @Nullable
+    private IFluidTank tank;
+    private static final FluidTankInfo NO_INFO = new FluidTankInfo(null, 0);
+    private static final IFluidTankProperties[] NO_PROPS = new IFluidTankProperties[0];
 
     public FluidTankSwitchShim(IFluidTank tank) {
         changeTank(tank);
     }
 
     public void changeTank(IFluidTank tank) {
-        if (!(tank instanceof IFluidHandler)) {
+        if (tank != null && !(tank instanceof IFluidHandler)) {
             throw new IllegalArgumentException("Shim tank must be both IFluidTank and IFluidHandler!");
         }
         this.tank = tank;
@@ -27,43 +30,49 @@ public void changeTank(IFluidTank tank) {
     @Nullable
     @Override
     public FluidStack getFluid() {
-        return tank.getFluid();
+        return tank == null ? null : tank.getFluid();
     }
 
     @Override
     public int getFluidAmount() {
-        return tank.getFluidAmount();
+        return tank == null ? 0 : tank.getFluidAmount();
     }
 
     @Override
     public int getCapacity() {
-        return tank.getCapacity();
+        return tank == null ? 0 : tank.getCapacity();
     }
 
     @Override
     public FluidTankInfo getInfo() {
-        return tank.getInfo();
+        return tank == null ? NO_INFO : tank.getInfo();
     }
 
     @Override
     public IFluidTankProperties[] getTankProperties() {
+        if (tank == null)
+            return NO_PROPS;
+
         return ((IFluidHandler) tank).getTankProperties();
     }
 
     @Override
     public int fill(FluidStack resource, boolean doFill) {
+        if (tank == null) return 0;
         return ((IFluidHandler) tank).fill(resource, doFill);
     }
 
     @Nullable
     @Override
     public FluidStack drain(FluidStack resource, boolean doDrain) {
+        if (tank == null) return null;
         return ((IFluidHandler) tank).drain(resource, doDrain);
     }
 
     @Nullable
     @Override
     public FluidStack drain(int maxDrain, boolean doDrain) {
+        if (tank == null) return null;
         return tank.drain(maxDrain, doDrain);
     }
 }