move updateFilterReader into base filter

don't return null in error filter

Author: ghzdude

src/main/java/gregtech/common/covers/filter/BaseFilter.java

@@ -19,14 +19,13 @@ public abstract class BaseFilter implements IItemComponent {
 
     public static final BaseFilter ERROR_FILTER = new BaseFilter() {
 
+        private final BaseFilterReader reader = new BaseFilterReader(0);
+
         @Override
         public BaseFilterReader getFilterReader() {
-            return null;
+            return reader;
         }
 
-        @Override
-        public void updateFilterReader(ItemStack stack) {}
-
         @Override
         public FilterType getType() {
             return FilterType.ERROR;
@@ -35,7 +34,9 @@ public FilterType getType() {
 
     public abstract BaseFilterReader getFilterReader();
 
-    public abstract void updateFilterReader(ItemStack stack);
+    public final void updateFilterReader(ItemStack stack) {
+        getFilterReader().readStack(stack);
+    }
 
     public BaseFilterUIManager getUI() {
         if (getContainerStack().getItem() instanceof MetaItem<?>metaItem) {

src/main/java/gregtech/common/covers/filter/OreDictionaryItemFilter.java

@@ -30,11 +30,6 @@ public OreDictFilterReader getFilterReader() {
         return filterReader;
     }
 
-    @Override
-    public void updateFilterReader(ItemStack stack) {
-        this.filterReader.readStack(stack);
-    }
-
     @NotNull
     public String getExpression() {
         return this.filterReader.getExpression();

src/main/java/gregtech/common/covers/filter/SimpleFluidFilter.java

@@ -2,7 +2,6 @@
 
 import gregtech.common.covers.filter.readers.SimpleFluidFilterReader;
 
-import net.minecraft.item.ItemStack;
 import net.minecraftforge.fluids.FluidStack;
 
 public class SimpleFluidFilter extends BaseFilter {
@@ -16,11 +15,6 @@ public SimpleFluidFilterReader getFilterReader() {
         return filterReader;
     }
 
-    @Override
-    public void updateFilterReader(ItemStack stack) {
-        this.filterReader.readStack(stack);
-    }
-
     public void configureFilterTanks(int amount) {
         this.filterReader.setFluidAmounts(amount);
     }

src/main/java/gregtech/common/covers/filter/SimpleItemFilter.java

@@ -15,11 +15,6 @@ public SimpleItemFilterReader getFilterReader() {
         return filterReader;
     }
 
-    @Override
-    public void updateFilterReader(ItemStack stack) {
-        this.filterReader.readStack(stack);
-    }
-
     @Override
     public MatchResult matchItem(ItemStack itemStack) {
         int matchedSlot = itemFilterMatch(filterReader, filterReader.isIgnoreDamage(), filterReader.isIgnoreNBT(),

src/main/java/gregtech/common/covers/filter/SmartItemFilter.java

@@ -24,11 +24,6 @@ public SmartItemFilterReader getFilterReader() {
         return filterReader;
     }
 
-    @Override
-    public void updateFilterReader(ItemStack stack) {
-        this.filterReader.readStack(stack);
-    }
-
     public SmartFilteringMode getFilteringMode() {
         return this.filterReader.getFilteringMode();
     }