Skip to content

Extract enabledMaterials map to BlockMaterialPipe class#2855

Merged
ALongStringOfNumbers merged 1 commit into
GregTechCEu:masterfrom
MCTian-mi:pipe-materials
Oct 26, 2025
Merged

Extract enabledMaterials map to BlockMaterialPipe class#2855
ALongStringOfNumbers merged 1 commit into
GregTechCEu:masterfrom
MCTian-mi:pipe-materials

Conversation

@MCTian-mi

Copy link
Copy Markdown
Contributor

What

All child classes of BlockMaterialPipe has such impl themselves, although it's not exactly the same.

@MCTian-mi MCTian-mi requested a review from a team as a code owner August 22, 2025 10:04
@Zorbatron Zorbatron added the type: refactor Suggestion to refactor a section of code label Aug 25, 2025
@Zorbatron

Copy link
Copy Markdown
Member

These common method using enabledMaterials can also be moved down to BlockMaterialPipe:

  • createProperties
  • getFallbackType
  • getSubBlocks
  • addPipeMaterial

@MCTian-mi

Copy link
Copy Markdown
Contributor Author

These common method using enabledMaterials can also be moved down to BlockMaterialPipe:

  • createProperties
  • getFallbackType
  • getSubBlocks
  • addPipeMaterial

Done!

Comment thread src/main/java/gregtech/common/pipelike/cable/BlockCable.java
@MCTian-mi MCTian-mi requested a review from a team as a code owner September 4, 2025 13:59
Comment thread settings.gradle
@ALongStringOfNumbers ALongStringOfNumbers merged commit 5c70731 into GregTechCEu:master Oct 26, 2025
3 checks passed
@MCTian-mi MCTian-mi deleted the pipe-materials branch November 24, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants