Implement Registry for Custom Coils#2874
Merged
Merged
Conversation
register coils to a list remove StoneVariantBlock property
move harvest level into own method
mostly working ignore .ase files
this conflicts with the render layer
create manager and registries like MTEs remove color method rollback custom rendering changes
add color back with material rgb
freeze/unfreeze in CoreModule add static reference in GregTechAPI add color and model register
simplify BlockWireCoil simplify texture
pass modid down to CoilStatBuilder split texture and generic make generic false by default add custom tooltips for custom coils
use boolean instead of client only class
M-W-K
requested changes
Oct 21, 2025
| import java.util.Map; | ||
| import java.util.function.BooleanSupplier; | ||
|
|
||
| public class BlockWireCoil extends VariantActiveBlock<BlockWireCoil.CoilType> { |
Contributor
There was a problem hiding this comment.
The existence of this class now leads to some level of duplication. It might be better to merge this and the custom coil class together so we don't have two systems to do the same thing.
create BuilderFactory so only `makeBuilder()` is visible remove event testing code
add javadoc to explain some methods
M-W-K
approved these changes
Nov 6, 2025
ALongStringOfNumbers
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements a registry for custom coils much like the MTE registry. Also implements a generic coil texture to be tinted by the material's RGB instead of a dedicated texture. Custom Coils can also have additional tooltips on top of the existing tooltips.
Implementation Details
The enum type restriction for the variant type paramater has been replaced by
IStringSerializableandComparable<>The enum property has been replaced by a new property class
PropertyIntMapCoilType is done with a builder and is no longer an enum
search for inner enum classes to reduce the usage of
getActualTypeParamaters()Outcome
Custom Coils are now much easier to create for addons (and potentially groovyscript)
Additional Information
using the generic texture causes a visual issue for CTM for some reason