Skip to content

feat: bulk write pipeline#68

Merged
fengjiachun merged 7 commits into
mainfrom
feat/write-pipeline
Apr 17, 2025
Merged

feat: bulk write pipeline#68
fengjiachun merged 7 commits into
mainfrom
feat/write-pipeline

Conversation

@fengjiachun
Copy link
Copy Markdown
Contributor

As the title

@fengjiachun fengjiachun force-pushed the feat/write-pipeline branch 7 times, most recently from 303e500 to 91a6305 Compare April 15, 2025 13:58
@fengjiachun fengjiachun force-pushed the feat/write-pipeline branch 3 times, most recently from e4a8c9a to 744b09f Compare April 16, 2025 06:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • ingester-bulk-protocol/pom.xml: Language not supported
  • ingester-example/src/main/resources/log4j2.xml: Language not supported
Comments suppressed due to low confidence (2)

ingester-bulk-protocol/src/main/java/io/greptime/BulkWriteService.java:161

  • Ensure that the ownership and lifecycle of metadataBuf is clearly documented and that listener.putNext(metadataBuf) consistently releases the buffer. This is important to avoid potential memory leaks if internal behavior changes in the future.
metadataBuf = this.allocator.buffer(metadata.length);

ingester-bulk-protocol/src/main/java/io/greptime/BulkWriteManager.java:141

  • The updated method signature no longer includes a database parameter. Please ensure this change is intentional and that all upstream consumers are updated accordingly.
public BulkWriteService intoBulkWriteStream(String table, Schema schema, long timeoutMs, CallOption... options) {

@fengjiachun fengjiachun force-pushed the feat/write-pipeline branch 2 times, most recently from 1bee031 to 0348827 Compare April 16, 2025 08:19
@fengjiachun fengjiachun force-pushed the feat/write-pipeline branch from 0348827 to ee7cfcf Compare April 16, 2025 12:47
@fengjiachun fengjiachun merged commit b045476 into main Apr 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants