feat: bulk write pipeline#68
Merged
Merged
Conversation
11 tasks
303e500 to
91a6305
Compare
e4a8c9a to
744b09f
Compare
There was a problem hiding this comment.
Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (2)
- ingester-bulk-protocol/pom.xml: Language not supported
- ingester-example/src/main/resources/log4j2.xml: Language not supported
Comments suppressed due to low confidence (2)
ingester-bulk-protocol/src/main/java/io/greptime/BulkWriteService.java:161
- Ensure that the ownership and lifecycle of metadataBuf is clearly documented and that listener.putNext(metadataBuf) consistently releases the buffer. This is important to avoid potential memory leaks if internal behavior changes in the future.
metadataBuf = this.allocator.buffer(metadata.length);
ingester-bulk-protocol/src/main/java/io/greptime/BulkWriteManager.java:141
- The updated method signature no longer includes a database parameter. Please ensure this change is intentional and that all upstream consumers are updated accordingly.
public BulkWriteService intoBulkWriteStream(String table, Schema schema, long timeoutMs, CallOption... options) {
1bee031 to
0348827
Compare
0348827 to
ee7cfcf
Compare
MichaelScofield
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title